[Bug 450164] Review Request: ace-tao - The ADAPTIVE Communication Environment (ACE) and The ACE ORB (TAO)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450164





--- Comment #31 from Johnny Willemsen jwillem...@remedy.nl  2009-05-31 
02:12:55 EDT ---
if you have a unified diff for the mentioned files to update, I can commit that
to the ACE repository. We are working towards ACE 5.7 which should be released
in June

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478922] Review Request: globus-ftp-control - Globus Toolkit - GridFTP Client Control Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478922


Mattias Ellert mattias.ell...@fysast.uu.se changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Mattias Ellert mattias.ell...@fysast.uu.se  2009-05-31 
02:17:20 EDT ---
Thank you for the review - I'll fix those warnings...

New Package CVS Request
===
Package Name: globus-ftp-control
Short Description: Globus Toolkit - GridFTP Client Control Library
Owners: ellert
Branches: F-9 F-10 F-11 EL-4 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478925] Review Request: globus-gass-transfer - Globus Toolkit - Globus Gass Transfer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478925


Mattias Ellert mattias.ell...@fysast.uu.se changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Mattias Ellert mattias.ell...@fysast.uu.se  2009-05-31 
02:17:26 EDT ---
Thank you for the review.

New Package CVS Request
===
Package Name: globus-gass-transfer
Short Description: Globus Toolkit - Globus Gass Transfer
Owners: ellert
Branches: F-9 F-10 F-11 EL-4 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 497251] Review Request: libstdc++-docs - Documentation in html for libstdc++

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497251


Alexey Torkhov atork...@gmail.com changed:

   What|Removed |Added

 CC||atork...@gmail.com




--- Comment #14 from Alexey Torkhov atork...@gmail.com  2009-05-31 05:09:34 
EDT ---
*** Bug 451619 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 475065] Review Request: givaro - C++ library for arithmetic and algebraic computations

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475065





--- Comment #15 from D Haley my...@yahoo.com  2009-05-31 05:24:14 EDT ---
I recommend emailing the three lead devs, probably in the one email. Their
addresses are on each of their profile sites. I'm sure they would be happy to
help, considering the time it would have taken to write their system. Also
their input here would clear up a few matters relatively quickly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655





--- Comment #42 from Paulo Roma Cavalcanti pro...@gmail.com  2009-05-31 
07:12:11 EDT ---
Thanks, Jochen


There are rpms available for Fedora here:

http://atrpms.net/name/yafaray/


Therefore, anyone willing to test them are welcome.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 492715] Review Request: KRadio4 - V4L/V4L2-Radio Application for KDE4

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492715





--- Comment #28 from Paulo Roma Cavalcanti pro...@gmail.com  2009-05-31 
08:34:35 EDT ---

 OK then. I tested application with my TV/FM card, and works just fine!
 

Good to know. kradio is really nice. You can import preset stations and
add image logos for each one of them.

 Please, see with upstream if the next release will be soon.
 
 I think that is wise to waiting for release (RC4 is out, so I concluded that
 the release is close :) )  

I talked to Ernst Whitte today, and he told me the final version is almost
done.
Therefore, it is really better to wait a little bit longer.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614


Byron Clark by...@theclarkfamily.name changed:

   What|Removed |Added

 CC||by...@theclarkfamily.name




--- Comment #2 from Byron Clark by...@theclarkfamily.name  2009-05-31 
09:00:57 EDT ---
I started on this package a while ago and just sent my patches upstream last
night.  If you're interested, here is a version with those patches.  It gets
rid of all the sed trickery.

Spec URL: http://theclarkfamily.name/fedora/stfl.spec
SRPM URL: http://theclarkfamily.name/fedora/stfl-0.20-3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503336] Review Request: newsbeuter - console based feed reader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503336


Byron Clark by...@theclarkfamily.name changed:

   What|Removed |Added

 Depends on||502614




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614


Byron Clark by...@theclarkfamily.name changed:

   What|Removed |Added

 Blocks||503336




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503336] New: Review Request: newsbeuter - console based feed reader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: newsbeuter - console based feed reader

https://bugzilla.redhat.com/show_bug.cgi?id=503336

   Summary: Review Request: newsbeuter - console based feed reader
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: by...@theclarkfamily.name
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://theclarkfamily.name/fedora/newsbeuter.spec
SRPM URL: http://theclarkfamily.name/fedora/newsbeuter-2.0-3.fc11.src.rpm
Description: Configurable text-based feed reader.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #11 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
09:52:12 EDT ---
Ok jussi i have done all that you have said plus some more, i also looked in
#fedora to see if anyone could help before you had chance to reply and was told
that i should include examples in the devel docs. So i tried to do this it took
a while as i am rather busy with exams at the minute as well however here is
the latest rev. and its changelog.
---
* Sun May 31 2009 Gareth John gareth.l.j...@googlemail.com 0.4.0-3
- Changed summary to recomendation
- Changed Build requirments to gtkmm24-devel only
- Use name  version macro in the Source0 line
- Dropped prefix from configure
- Removed checking for remove build root under install
- Added pkgconfig as requirement for devel package, for dir ownership.
- Dropped the doc line from -devel, as the devel package requires the main
package. 
- Tidy devel files as devel package should own the directories 
- Tidy package files. 
- Added chmod commands under install
- Removed attr lines under files
- Added patch to stop examples compiling
- Added examples to devel docs
- Added remove makefile from examples under prep

Rpmlint says:

$ rpmlint ../RPMS/i386/gtkmm-utils-devel-0.4.0-3.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../SRPMS/gtkmm-utils-0.4.0-3.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/i386/gtkmm-utils-0.4.0-3.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
-
Files:
http://garethsrpms.googlecode.com/files/gtkmm-utils.spec
http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-3.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #12 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
09:56:38 EDT ---
Just to explain sorry to leave it off, when inlcuding examples as documentation
i followed the example of
http://fedoraproject.org/wiki/Docs/Drafts/BuildingPackagesGuide#Case_Study:_leafpad,
i hope that this is the correct way of doing it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #3 from Thomas Janssen th.p.jans...@googlemail.com  2009-05-31 
10:01:33 EDT ---
You started earlier on that. You should maintain it. I just need it for
Newsbeuter. So if you're interested to maintain it in Fedora, please take it.

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #4 from Byron Clark by...@theclarkfamily.name  2009-05-31 
10:10:16 EDT ---
I was really only packaging it for newsbeuter, but I would be happy to maintain
the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655





--- Comment #43 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-05-31 
10:26:00 EDT ---
Can someone send me a picture of blender to see where the yafaray render option
take place... I've never seen this from the whole review... (at least on
x86_64).


yafaray should be at version 1.0. That a rather common sense that a stable
release have matching svn revision, that's very incorrect to have it mentioned
talking from a stable release.

quoting theses directories:
%{_datadir}/blender/scripts/*
%{_libdir}/libyafarayqt.so
%{_libdir}/libyafarayplugin.so
%{python_sitearch}/_yaf*.so

IMO, you should only uses one directory from the script and the _yaf*.so.

Again, that was meant to be asked with upstream blender/yafaray.

The current package provided above doesn't work at all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #13 from Jussi Lehtola jussileht...@fedoraproject.org  2009-05-31 
10:27:57 EDT ---
What's the purpose of the no.example patch?

Otherwise it's starting to look quite good. You shouldn't include INSTALL in
%doc, however, since it probably contains just instructions for installing from
source.

Also, use
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
to preserve time stamps in install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=175433


Simon Wesp cassmod...@fedoraproject.org changed:

   What|Removed |Added

   Flag|fedora-cvs- |fedora-cvs?




--- Comment #62 from Simon Wesp cassmod...@fedoraproject.org  2009-05-31 
10:37:39 EDT ---
okay, then me only

Package Change Request
==
Package Name: tor
New Branches: EL-5
Owners: cassmodiah

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 491490] Review Request: ghmm - A library with data structures and algorithms for Hidden Markov Models

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491490


D Haley my...@yahoo.com changed:

   What|Removed |Added

 CC||my...@yahoo.com




--- Comment #1 from D Haley my...@yahoo.com  2009-05-31 10:41:56 EDT ---
Its me again. Here are my comments for this package.

General comments:

* For ease of update, I recommend defining a svnrev macro, then using that
where appropriate.
* DTD is named in an unusual manner, with version number after .dtd --should
this be renamed?
*-config script needs correcting to produce appropriate output when called with
multiple flags. This is the same problem as for bug 475065 (why is this
identical to the other one?)

*# Commented out because it seems broken - is the check failing, or just not
running?

Review comments:

#  MUST: rpmlint must be run on every package. The output should be posted in
the review.
$ rpmlint -v ghmm.spec ../SRPMS/ghmm-0.7-1.svn2251.fc10.src.rpm
../RPMS/i386/ghmm-0.7-1.svn2251.fc10.i386.rpm
../RPMS/i386/ghmm-static-0.7-1.svn2251.fc10.i386.rpm
../RPMS/i386/ghmm-devel-0.7-1.svn2251.fc10.i386.rpm
../RPMS/i386/ghmm-debuginfo-0.7-1.svn2251.fc10.i386.rpm 
ghmm.spec:71: W: rpm-buildroot-usage %prep -e 's|$(PYTHON) setup.py
install.*$|$(PYTHON) setup.py install -O1 --skip-build --root
${RPM_BUILD_ROOT}|' \
ghmm.src: I: checking
ghmm.src:71: W: rpm-buildroot-usage %prep -e 's|$(PYTHON) setup.py
install.*$|$(PYTHON) setup.py install -O1 --skip-build --root
${RPM_BUILD_ROOT}|' \
ghmm.i386: I: checking
ghmm.i386: W: shared-lib-calls-exit /usr/lib/libghmm.so.1.0.0 e...@glibc_2.0
ghmm-static.i386: I: checking
ghmm-static.i386: W: no-documentation
ghmm-devel.i386: I: checking
ghmm-devel.i386: W: no-documentation
ghmm-debuginfo.i386: I: checking
5 packages and 1 specfiles checked; 0 errors, 5 warnings.

Please notify upstream about the exit() call, and ask for a fix; notification
of upstream is required, upstream response is not, although reply should be
given here if upstream responds.

# MUST: The package must be named according to the Package Naming Guidelines .
OK

# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
# MUST: The package must meet the Packaging Guidelines .
OK
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
FAIL : Running my quick and dirty grep (x`grep any later` != x) over the
files indicates that the following files don't have an LGPLv2+ boilerplate:
Bad: ./ghmmwrapper/ghmmwrapper_wrap.c
Bad: ./tests/two_states_three_symbols.c
Bad: ./tests/read_fa.c
Bad: ./tests/read_smodel.c
Bad: ./tests/label_higher_order_test.c
Bad: ./tests/randvar_test.c
Bad: ./tests/generate_PHI.c
Bad: ./tests/shmm_viterbi_test.c
Bad: ./tests/chmm_test.c
Bad: ./tests/libxml-test.c
Bad: ./tests/ghmmunittests.c
Bad: ./tests/sequences_old_format.c
Bad: ./tests/chmm.c
Bad: ./tests/root_finder_test.c
Bad: ./tests/test_gsl_ran_gaussian_tail.c
Bad: ./tests/sequences_test.c
Bad: ./tests/coin_toss_test.c
Bad: ./tools/smo2xml.c
Bad: ./tools/probdist.c
Bad: ./tools/scluster.c
Bad: ./tools/smix_hmm.c
Bad: ./tools/cluster.c
Bad: ./ghmm/mt19937ar.c
Bad: ./ghmm/psequence.h
Bad: ./ghmm/obsolete.h
Bad: ./win_config.h
Bad: ./config.h

./ghmm/mt19937ar.c appears to have BSD style licence, and others no licence at
all. 

* Also the copyright file says parts are from the Sun BSD style licence, but no
clear relation as to which source files this applies to is given.

* The COPYING links to the GPL, which is included but their website says LGPL.
This needs to be clarified by upstream.

* Requiring the GNU Scientific Library will make the package GPLv3(+?), not
LGPL.

* Finally the COPYING file must be bundled into %doc as this is the user
recieving a copy of the LGPL/GPL (additional to COPYRIGHT.txt).

This will all need to be fixed. At the very least you need to change the
licence field, as the licences are mixed. You should notify upstream about this
so they can relicence, and/or fix the missing licences.

# MUST: The License field in the package spec file must match the actual
license.
FAIL: see above
# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
FAIL: see above
# MUST: The spec file must be written in American English.
OK
# MUST: The spec file for the package MUST be legible.
OK
# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this pacKoji OKkage, please see the Source
URL Guidelines for how to deal with this.

[Bug 491490] Review Request: ghmm - A library with data structures and algorithms for Hidden Markov Models

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491490





--- Comment #2 from D Haley my...@yahoo.com  2009-05-31 10:45:10 EDT ---
Also, can you set the depends upon and blocks fields for this bug?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #14 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
10:52:20 EDT ---
PATCH:
Following the guidance for including examples i removed the makefiles for
examples, however when I went to compile it was hitting an error as it was
looking for the files. I looked for flags to turn examples off during configure
and make however couldnt make much from that so removed the lines from
configure and makefile.in that were looking for files in /example and made a
patch i figured as the guide did this and with examples compiled rpmlint gave
64 errors that they needed to come out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655





--- Comment #44 from Paulo Roma Cavalcanti pro...@gmail.com  2009-05-31 
10:49:56 EDT ---
(In reply to comment #43)
 Can someone send me a picture of blender to see where the yafaray render 
 option
 take place... I've never seen this from the whole review... (at least on
 x86_64).
 

I am also using x86_64. Here is the picture:

http://orion.lcg.ufrj.br/temp/blender-yafaray.png

This is an archive with some scenes prepared to be rendered with
blender/yafaray: 

http://orion.lcg.ufrj.br/temp/example_scenes.tar.bz2

The first one, bed_0001.blend, took more than 2 hours in a quadcore 2.4.

Therefore, I would try the other ones first.


 
 yafaray should be at version 1.0. That a rather common sense that a stable
 release have matching svn revision, that's very incorrect to have it mentioned
 talking from a stable release.

That is how upstream is doing. They moved from 1.0 - 305 to 1.0 - 315:

http://www.yafaray.org/download/yafaray

 
 quoting theses directories:
 %{_datadir}/blender/scripts/*
 %{_libdir}/libyafarayqt.so
 %{_libdir}/libyafarayplugin.so
 %{python_sitearch}/_yaf*.so
 
 IMO, you should only uses one directory from the script and the _yaf*.so.
 
 Again, that was meant to be asked with upstream blender/yafaray.

I have posted a message in yafaray Building forum and did not receive a
single reply. They are Debian oriented, and I do not think they are concerned
where we are going to install our files.

 
 The current package provided above doesn't work at all.  

What do you mean by that? It is working for me just fine. Have you tried
it? Does it segfault?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 492715] Review Request: KRadio4 - V4L/V4L2-Radio Application for KDE4

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492715





--- Comment #29 from Paulo Roma Cavalcanti pro...@gmail.com  2009-05-31 
11:00:47 EDT ---
Just a quick update.

The desktop entry has been added to the source.

I built revision 889, which is very close to the final release.

SPEC: http://orion.lcg.ufrj.br/RPMS/SPECS/kradio4.spec

SRPMS:
http://orion.lcg.ufrj.br/RPMS/src/fedora/kradio4-4.0.0-0.12.r889.20090531.fc10.src.rpm

This is the full version, which also creates a kradio4-internetradio:

SPEC: http://people.atrpms.net/~pcavalcanti/specs/kradio4.spec

SRPMS:
http://orion.lcg.ufrj.br/RPMS/src/kradio4-4.0.0-0.12.r889.20090531.fc10.src.rpm 

Both have the same version, and therefore, any 3th party repo
can build the full version and post just kradio4-internetradio rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655





--- Comment #45 from Paulo Roma Cavalcanti pro...@gmail.com  2009-05-31 
11:09:01 EDT ---
Another thing. Old models prepared for yafray 0.9
will not be rendered correctly. They must be adapted.

That is why I sent you some new models for you to run.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502477] Review Request: arista - Easy to use multimedia transcoder for the GNOME Desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502477


François Kooman fkoo...@tuxed.net changed:

   What|Removed |Added

 CC||fkoo...@tuxed.net




--- Comment #3 from François Kooman fkoo...@tuxed.net  2009-05-31 11:13:20 
EDT ---
arista-0.9.1-2.fc11.noarch

[fkoo...@localhost ~]$ arista-gtk 
Traceback (most recent call last):
  File /usr/bin/arista-gtk, line 1244, in module
arista.utils.get_path(locale))
  File /usr/lib/python2.6/site-packages/arista/utils.py, line 75, in get_path
path: path,
IOError: Can't find locale in any known prefix!
[fkoo...@localhost ~]$ 

Maybe a dependency missing?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #5 from Thomas Janssen th.p.jans...@googlemail.com  2009-05-31 
11:29:55 EDT ---
Ok. It's all yours. Thanks for your contribution :)

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 481536] Review Request: enano - Enano CMS, a php-based modular content management system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481536





--- Comment #17 from Dan Fuhry d...@enanocms.org  2009-05-31 12:13:11 EDT ---
Please excuse my confrontational disposition.

I'd like to know how MediaWiki made it into Fedora repositories, seeing as much
of the code it uses is also borrowed without being separately packaged. An
example of this would be phpWiki's diff engine - both Enano and MediaWiki use
this same code from phpWiki 1.3.3. By the standard you are holding us to,
MediaWiki would have had to split its diff engine out before it was accepted
into Fedora repositories. They don't even HAVE a centralized list of 3rd-party
code distributed with their package.

Like other web apps, Enano is not very much like a desktop application in the
way it is designed. It is a web application. We can't just distribute it with a
configure script that screams at you about dependent libraries until everything
is satisfied. On the Web, libraries are so small and APIs change so quickly
that bundling libraries is the only thing that makes sense. MediaWiki does it
like this, so why can't Enano?

We take security problems as seriously as anyone. Our turnaround time for
security releases is typically 4 hours from the time I'm alerted to it to the
time the tarballs are on the Web server and announcements are circulating. Neal
Gompa (King InuYasha), who built and plans to maintain the RPM, is the
second-highest person in the Enano project. If there's going to be a security
release, he knows about it as soon as I become aware of the vulnerability, and
sometimes sooner as he's our official QA contact.

Now on to API stabilization. Web developers love to break APIs. (Yes, I'm
guilty of this too.) By controlling the code ourselves, we ensure that there
are not any API changes that could cause Enano to break or somehow introduce a
security problem. When done properly - with proper porting and removal of
unneeded components, such as is done in Enano and MediaWiki - bundling can mean
that security is in fact INCREASED because only the core components involving
the heavy number crunching really stay; everything else is done by Enano.
Almost all GPL'ed PHP scripts are distributed as applications, not individual
libraries and toolkits. This is in contrast to Java applications, which you are
equating with PHP applications, but really are different in the sense that Java
components are separated into libraries rather than bundled and integrated
tightly with the core. This is an industry trend and not something the Enano
project really has control over. We have to go with the flow in this case.

Integration is crucial too: we also have our own API that bundled libraries
need to use, such as the code required to parse wikilinks and route CAPTCHA
images through Enano's URL and page management code. Proper integration doesn't
happen without this.

Another fun statistic: while Enano has a bunch of bundled libraries, none of
them ever make SQL queries or directly parse any sort of user input. So the two
biggest sources of security vulnerabilities - SQL injection and XSS - should
NEVER be present in any 3rd party code. The 80:20 rule applies to security
problems too: roughly 80% of security holes are caused by 20% of vulnerability
types.

In summary: we bundle for two reasons:
  1) We don't want API breakage, and
  2) Web apps are different from traditional ones; libraries often do too much
and need things to be stripped out in order to work correctly. We allow this
because the overhead, not the core functionality, is almost always where
security problems are.

If you're going to have someone review this package, it should be an
experienced web developer who understands this stuff. Web apps just are not
traditional desktop apps, and many web application security practices are
difficult to grasp from the perspective of someone who handles security of
desktop apps. They're not less secure, they're just different.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686





--- Comment #2 from Denis Arnaud denis.arnaud_fed...@m4x.org  2009-05-31 
12:20:37 EDT ---
When building on (a kqemu virtual machine set-up with an installation from
scratch of) CentOS 5.3, the RPM packages are well built.

However, rpmlint still complains on CentOS 5.3 (that libraries are delivered
in a noarch package), due the BuildArch: noarch directive of the doc
sub-package, though that directive is enclosed within proper %if 0%{fedora} =
10 [...] %endif clause, as per the following:
-
%package doc
Summary: HTML documentation for the %{name} library
Group: Documentation
%if 0%{?fedora} = 10
BuildArch: noarch
BuildRequires: texlive-latex
%endif
-

I have checked that 'rpm --eval %{fedora}' gives %{fedora} under CentOS 5.3
(i.e, the %{fedora} macro is not defined on that distribution), whereas it
gives 11 under Fedora Rawhide and 10 under Fedora 10 (as expected).
However, I'm not sure that the following assertion 0%{fedora} = 10 holds
false under CentOS 5.3.

Also, still on CentOS 5.3, the three %{rhel}, %{rhl} and %{el5} macros are
undefined, though they should be defined, according to
https://fedoraproject.org/wiki/Packaging:DistTag . Or, did I miss something?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686





--- Comment #3 from Michael Schwendt mschwe...@gmail.com  2009-05-31 12:56:27 
EDT ---
* The macros are Fedora EPEL specific. You need add-on packages:
http://buildsys.fedoraproject.org/buildgroups/

* Have you verified that CentOS builds all packages as noarch? Or is it just
rpmlint that returns a false positive? AFAIK, it only runs some regexp over the
spec file.

 'rpm --eval %{fedora}' gives %{fedora} 

In the spec it's %{?fedora} however (cf. rpm --eval %{?fedora}), which
expands to %nil if the macro is undefined. Hence 0%{?fedora} = 10 is false on
CentOS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478930] Review Request: globus-rls-client - Globus Toolkit - Replica Location Service Client

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478930


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||oget.fed...@gmail.com
 AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
   Flag||fedora-review?

Bug 478930 depends on bug 467237, which changed state.

Bug 467237 Summary: Review Request: globus-gssapi-gsi - Globus Toolkit - GSSAPI 
library
https://bugzilla.redhat.com/show_bug.cgi?id=467237

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



--- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-05-31 
14:07:14 EDT ---
There are some issues with this one:

- koji rawhide build seems fine
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1385823

! The file CHANGELOG can go to a %doc

* The source extraction guide is incomplete. The original source tree contains
a ./java directory, which is missing from your tarball. Is there a reason?

? There is some html documentation under the ./Doc directory. Currently there
is a doxygen documentation in the doc package which seemed to me rather
useless. Shall we replace it with the html documentation from the ./Doc
directory?

- rpmlint
   globus-rls-client-devel.x86_64: W: no-documentation
can be ignored. (Well, the CHANGELOG might fit in here)

* Please fix the compilation warnings of the type
   rpc.c:395: warning: format '%d' expects type 'int', but argument 3 has type
'globus_size_t'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 481536] Review Request: enano - Enano CMS, a php-based modular content management system

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481536





--- Comment #18 from Toshio Ernie Kuratomi a.bad...@gmail.com  2009-05-31 
14:10:46 EDT ---
(In reply to comment #17)
 Please excuse my confrontational disposition.
 
The problem with confrontational dispositions are that they leave the
impression that the party being confrontational is unwilling to learn and
adapt.  At that point, it's often not worthwhile to continue a conversation
because no progress will be made.

 I'd like to know how MediaWiki made it into Fedora repositories, seeing as 
 much
 of the code it uses is also borrowed without being separately packaged. An
 example of this would be phpWiki's diff engine - both Enano and MediaWiki use
 this same code from phpWiki 1.3.3. By the standard you are holding us to,
 MediaWiki would have had to split its diff engine out before it was accepted
 into Fedora repositories. They don't even HAVE a centralized list of 3rd-party
 code distributed with their package.
 
Sorry if my quick grep for license incompatibilities confused you.  Your
example falls outside the scope of the no bundled library requirement because
the file is not a library.  Even though no duplication of code would lead to
more security in an ideal world, there are a number of issues that prevent us
from doing this reasonably.  The requirement that libraries not be bundled is a
good compromise since libraries are packaged separately, released on their own
timelines, and exist to be used in this way.

Since the code you point out has been copy and pasted between three
applications, I'd say that it's a great candidate for spinning off into its own
library so all three projects can share the maintainance burden and addition of
new features.

If you can point out a place where Mediawiki is bundling a library I'll be
happy to open a bug report and pursue the mediawiki packager to get that fixed.

Incompatible licensing or even problems with people including unlicensed code
is a separate issue from bundled libraries as they can exist independent of
each other.  However, projects that bundle libraries often have license issues
as well as they stem from the same root cause: upstream not understanding all
the implications of including code that they do not originate.

 Like other web apps, Enano is not very much like a desktop application in the
 way it is designed. It is a web application. We can't just distribute it with 
 a
 configure script that screams at you about dependent libraries until 
 everything
 is satisfied. On the Web, libraries are so small and APIs change so quickly
 that bundling libraries is the only thing that makes sense.

This is certainly a developer way of looking at things.  However, the claim
that web applications are special is false.  There are web applications that
distribute with scripts that check that necessary functionality is available. 
There are desktop applications that have to deal with small libraries and
quickly changing APIs.  We've made the decision in Fedora that convenience in
this area does not trump security.  Instead we evolve solutions to the problems
you face.

Sometimes we port code to newer versions of libraries for you and send the
patches back to you.  In other instances we create parallel installable
versions of the libraries your application depends on.  Compromises that
address both API instability and security exist.

 MediaWiki does it
 like this, so why can't Enano?
 
If mediawiki bundles libraries, I'll file a bug and either the maintainer will
fix it or I'll talk with the PHP SIG about the best way to fix the issues.

 We take security problems as seriously as anyone. Our turnaround time for
 security releases is typically 4 hours from the time I'm alerted to it to the
 time the tarballs are on the Web server and announcements are circulating. 
 Neal
 Gompa (King InuYasha), who built and plans to maintain the RPM, is the
 second-highest person in the Enano project. If there's going to be a security
 release, he knows about it as soon as I become aware of the vulnerability, and
 sometimes sooner as he's our official QA contact.
 
This shows that you are good at reacting to security issues which is certainly
good.  It doesn't show that you are good at proactively designing secure
systems.  It doesn't show that you are paying attention to the security issues
that are popping up in the third-party code you are bundling.  It doesn't show
that you are evaluating the third party code you incorporate for security
issues.

 Now on to API stabilization. Web developers love to break APIs. (Yes, I'm
 guilty of this too.) By controlling the code ourselves, we ensure that there
 are not any API changes that could cause Enano to break or somehow introduce a
 security problem. When done properly - with proper porting and removal of
 unneeded components, such as is done in Enano 

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #15 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
15:03:22 EDT ---
---
* Sun May 31 2009 Gareth John gareth.l.j...@googlemail.com 0.4.0-4
- Removed install from package docs
- added preserve timestamp flag to make install

Rpmlint says:

$ rpmlint ../RPMS/i386/gtkmm-utils-devel-0.4.0-4.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../SRPMS/gtkmm-utils-0.4.0-4.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/i386/gtkmm-utils-0.4.0-4.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
-
Files:
http://garethsrpms.googlecode.com/files/gtkmm-utils.spec
http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-4.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #16 from Jussi Lehtola jussi.leht...@iki.fi  2009-05-31 15:17:39 
EDT ---
IMHO there's no need to patch anything. Drop the patch and after the install
just remove the examples/.libs directory and the makefiles.

In fact you could as well ship the example binaries, that way one wouldn't need
to compile them to see what they do. They can't be placed in %{_bindir} though,
since they have such generic names.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #17 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
15:46:38 EDT ---
$ rpmlint ../RPMS/i386/gtkmm-utils-devel-0.4.0-5.fc10.i386.rpm 

gtkmm-utils-devel.i386: E: arch-dependent-file-in-usr-share
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/logging.o

gtkmm-utils-devel.i386: E: arch-dependent-file-in-usr-share
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/tiles-simple.o

gtkmm-utils-devel.i386: E: arch-dependent-file-in-usr-share
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/multi-completion.o

gtkmm-utils-devel.i386: W: hidden-file-or-dir
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/.deps

gtkmm-utils-devel.i386: W: hidden-file-or-dir
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/.deps

gtkmm-utils-devel.i386: W: spurious-executable-perm
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/tiles-simple

gtkmm-utils-devel.i386: W: spurious-executable-perm
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/multi-completion

gtkmm-utils-devel.i386: W: spurious-executable-perm
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/logging

Should i remove all of the following file as well?(In reply to comment #16)
 IMHO there's no need to patch anything. Drop the patch and after the install
 just remove the examples/.libs directory and the makefiles.
 
 In fact you could as well ship the example binaries, that way one wouldn't 
 need
 to compile them to see what they do. They can't be placed in %{_bindir} 
 though,
 since they have such generic names.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502101] Review Request: agedu - An utility for tracking down wasted disk space

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502101


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:11:26 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502686] Review Request: wsdlpull - C++ Web Services client library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502686





--- Comment #4 from Denis Arnaud denis.arnaud_fed...@m4x.org  2009-05-31 
16:10:05 EDT ---
(In reply to comment #3)

I had added the EPEL RPM repository, and those macros were defined. But, as you
suggested, I made a typo when trying to evaluate them with 'rpm --eval' :)

However, I had it right in the specification file
(http://denisarnaud.fedorapeople.org/wsdlpull/123/wsdlpull.spec) and:
* All the packages, including the doc one, are generated under the specific
architecture (RPMS/x86_64 in my case) directory (as expected).
* Again as you suggested, it appears that it is just rpmlint returning a false
positive. It is certainly due to the rpmlint W:
libdir-macro-in-noarch-package bug
(https://bugzilla.redhat.com/show_bug.cgi?id=488930). That bug has been
corrected in version from 0.87-1, whereas the latest version available on
CentOS 5.3 (Fedora EPEL 5) is 0.85-3 (newer versions are not even available in
the epel-testing repository).


So, that package builds nicely on all the platforms (Fedora 10, 11, rawhide and
EPEL 5). For instance, for F11/F12:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1385925

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 468229] Review Request: python-wsgiref - WSGI (PEP 333) Reference Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468229


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #9 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:14:17 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 480999] Review Request: python-webflash - Portable flash messages for WSGI apps

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480999


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:13:15 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503197] Review Request: moserial - Serial terminal for the gnome desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503197


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:12:14 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502323] Review Request: perl-Class-DBI-Plugin-DeepAbstractSearch - SQL::Abstract for Class::DBI

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502323


Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #4 from Chris Weyl cw...@alumni.drew.edu  2009-05-31 16:12:09 EDT 
---
Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478925] Review Request: globus-gass-transfer - Globus Toolkit - Globus Gass Transfer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478925


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:15:54 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478922] Review Request: globus-ftp-control - Globus Toolkit - GridFTP Client Control Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478922


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:15:06 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=175433


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #63 from Jason Tibbitts ti...@math.uh.edu  2009-05-31 16:17:51 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #18 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
16:31:26 EDT ---
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/gtkmm-utils-devel-0.4.0/examples/.deps/
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/gtkmm-utils-devel-0.4.0/examples/.libs/
chmod 755 $RPM_BUILD_ROOT%{_libdir}/libglibmm-utils.so.2.0.0
chmod 755 $RPM_BUILD_ROOT%{_libdir}/libgtkmm-utils.so.2.0.0

--
I have tried this and nearly every combination of directory even hard coding
the relevant directory in and nothing gets removed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #19 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
16:33:57 EDT ---
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/gtkmm-utils-devel-0.4.0/examples/.deps/
rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/gtkmm-utils-devel-0.4.0/examples/.libs/
chmod 755 $RPM_BUILD_ROOT%{_libdir}/libglibmm-utils.so.2.0.0
chmod 755 $RPM_BUILD_ROOT%{_libdir}/libgtkmm-utils.so.2.0.0

--
I have tried this and nearly every combination of directory even hard coding
the relevant directory in and nothing gets removed? The .libs and .deps will
not shift is there any reason you could suggest as to why it isnt working
rpmlint hints (-i flag) dont give much guidance here and internet is being
friendly either.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #20 from Jussi Lehtola jussi.leht...@iki.fi  2009-05-31 17:12:50 
EDT ---
(In reply to comment #17)
 Should i remove all of the following file as well?

Yes, the .o files are object files resulting from compilation of the source
code units.

(In reply to comment #19)
 %install
 rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
 find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
 rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/gtkmm-utils-devel-0.4.0/examples/.deps/
 rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/gtkmm-utils-devel-0.4.0/examples/.libs/
 chmod 755 $RPM_BUILD_ROOT%{_libdir}/libglibmm-utils.so.2.0.0
 chmod 755 $RPM_BUILD_ROOT%{_libdir}/libgtkmm-utils.so.2.0.0
 
 --
 I have tried this and nearly every combination of directory even hard coding
 the relevant directory in and nothing gets removed? The .libs and .deps will
 not shift is there any reason you could suggest as to why it isnt working
 rpmlint hints (-i flag) dont give much guidance here and internet is being
 friendly either.  

You just need to
 rm -rf examples/.libs examples/.deps
as the %doc listing pulls them in after the install phase.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502920] Review Request: polkit-gnome - PolicyKit integration for the GNOME desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502920





--- Comment #13 from Matthias Clasen mcla...@redhat.com  2009-05-31 17:45:43 
EDT ---
 The main problem I see is that you rewrote the spec and based your review on
 the rewrite. This renders the review pretty useless because nobody will 
 realize
 his own errors.  

No, the main problem is that you have 'licked blood' now and go out of your way
to find issues where there are none.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502920] Review Request: polkit-gnome - PolicyKit integration for the GNOME desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502920





--- Comment #14 from Christoph Wickert fed...@christoph-wickert.de  
2009-05-31 18:02:45 EDT ---
You call a wrong license tag and missing parallel build no problems?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502920] Review Request: polkit-gnome - PolicyKit integration for the GNOME desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502920





--- Comment #15 from Matthias Clasen mcla...@redhat.com  2009-05-31 18:41:43 
EDT ---
The license tag was a minor oversight indeed. Thanks for finding that.
I don't see any problem with parallel build. Have you verified that there are
no race conditions in the package if you turn it on ? See, me neither...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #21 from Gareth John gareth.l.j...@googlemail.com  2009-05-31 
18:44:42 EDT ---
---
* Sun May 31 2009 Gareth John gareth.l.j...@googlemail.com 0.4.0-5
- Removed patch
- Added line remove example/.libs and example/.deps
- Dropped remove /example/makefiles

Rpmlint says:

$ rpmlint ../RPMS/i386/gtkmm-utils-devel-0.4.0-5.fc10.i386.rpm 
gtkmm-utils-devel.i386: W: spurious-executable-perm
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/tiles-simple
gtkmm-utils-devel.i386: W: spurious-executable-perm
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/multi-completion
gtkmm-utils-devel.i386: W: spurious-executable-perm
/usr/share/doc/gtkmm-utils-devel-0.4.0/examples/logging
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint ../SRPMS/gtkmm-utils-0.4.0-5.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/i386/gtkmm-utils-0.4.0-5.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
-
Files:
http://garethsrpms.googlecode.com/files/gtkmm-utils.spec
http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-5.fc10.src.rpm
-
The spurious-executable-perm warnings are due to the compiled files in the
examples directory, as they are in the correct dir for their purpose and not in
%{_bindir} i assume that this is an acceptable warning.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474787





--- Comment #12 from Denis Arnaud denis.arnaud_fed...@m4x.org  2009-05-31 
21:32:15 EDT ---
[My machine crashed just before I pressed the commit button of the review :( ]

Note that, as I have not the sponsor status, that is not an official review.
However, there are a number of issues (some important, some others less) that I
can point to you (in no particular order).

1. Doxygen, as it is configured, generates .map files (in the doc/html
sub-directory), due to the use of the DOT tool (belonging to the graphviz
package). On some configurations (e.g., my Fedora rawhide/11, with rpmbuild),
some of those files are generated with a zero-length, which rpmlint then
complains of.

There are, at least, two solutions/work-arounds:
  1.a. Just drop the use of DOT in the Doxygen configuration file:
  HAVE_DOT = NO
  as in
http://rmol.svn.sourceforge.net/viewvc/rmol/trunk/rmol/doc/doxygen_html.cfg.in?revision=183view=markup
  As Doxygen replaces with other, simpler, diagrams, that should not be a so
big issue.
  1.b. Keep the use of DOT, but:
- Add a 'BuildRequires: graphivz' directive.
- Remove any zero-length-map files after the Doxygen generation
(http://cvs.fedoraproject.org/viewvc/rpms/asterisk/F-11/asterisk.spec?revision=1.51view=markup):
  find doc/html -name '*.map' -size 0 -delete

Note that with mock, there is, as is, no zero-length-map-file issue, but the
.map files are not generated, due to the missing 'BuildRequires: graphviz'
directive. Note also that you can not see that in the build.log
(http://koji.fedoraproject.org/koji/getfile?taskID=1383290name=build.log) of
Koji, as you have re-directed the output log of Doxygen into a file removed by
mock.

2. Avoid re-directing the output log of Doxygen, so that that log be present in
the build.log generated by mock (and Koji):
make doxy  doxymake.log 2 doxymake.stderr
==
make doxy

3. You may consider creating a separate -doc sub-package for both the HTML
Doxygen-generated documentation and the Latex-generated tutorial
(https://fedoraproject.org/wiki/Packaging/Guidelines#Documentation).

4. I would rather keep the PDF version of the tutorial, rather than the DVI
one. Moreover, we could alter the Makefile so that it generates only the PDF
version (which is now the default with latex).

5. In the %files section, you should take ownership of the %{_includedir}/bits
directory
(https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership):
%dir %{_includedir}/bits/

6. Still in the %files sections, it may be better to use a wildcard for the
libraries, as it will still hold for future versions of the library:
%{_libdir}/libstxxl.so.*

7. You may replace instances of stxxl with the %{name} macro, and of 1.2.1 with
the %{version} macro
(https://fedoraproject.org/wiki/Packaging/Guidelines#Macros). For instance:
---
URL: http://%{name}.sourceforge.net
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
Patch0:  %{name}-build-shared.patch
Patch1:  %{name}-build-shared-makefile.patch
---

x. The build system (makefiles) appears to be very specific to that package,
and it may not be portable. For instance, you have to install the files
manually yourself in the specification file. If you consider to bring a GNU
Autotools environment (and submit the corresponding patch upstream), and if I
can help you, do not hesitate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474787





--- Comment #13 from Denis Arnaud denis.arnaud_fed...@m4x.org  2009-05-31 
21:37:09 EDT ---
If it may help, the above comments (plus a few small others) have been
integrated into a new version of the specification file:
Spec URL: http://denisarnaud.fedorapeople.org/stxxl/121/6/stxxl.spec
(as well as the corresponding Source RPM:
http://denisarnaud.fedorapeople.org/stxxl/121/6/stxxl-1.2.1-6.fc10.src.rpm)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 478930] Review Request: globus-rls-client - Globus Toolkit - Replica Location Service Client

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478930





--- Comment #4 from Mattias Ellert mattias.ell...@fysast.uu.se  2009-06-01 
00:48:16 EDT ---
(In reply to comment #3)
 ! The file CHANGELOG can go to a %doc

The CHANGELOG file's last entry is for version 2.1.3, the current version is
5.1. Since the CHANGELOG file is not maintained it doesn't make much sense to
include it.

 * The source extraction guide is incomplete. The original source tree contains
 a ./java directory, which is missing from your tarball. Is there a reason?

Yes, the java directory is not part of the globus-rls-client source package,
but a separate source package of its own. The build GPT build instructions in
the pkgdata directory does not contain information about how to build the java
package. The java directory contains its own pkgdata directory with build
instructions for the java package. I have added a line to the source extraction
guide that removes the java directory before packaging the source tarball.

 ? There is some html documentation under the ./Doc directory. Currently there
 is a doxygen documentation in the doc package which seemed to me rather
 useless. Shall we replace it with the html documentation from the ./Doc
 directory?

The bug is in the LAC_DOXYGEN call in configure.in - it points to the main
directory instead of the library subdirectory. Fixed.

 * Please fix the compilation warnings of the type
rpc.c:395: warning: format '%d' expects type 'int', but argument 3 has type
 'globus_size_t'  

Fixed.

http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client-5.1-2.fc10.src.rpm
http://www.grid.tsl.uu.se/repos/globus/info/new/globus-rls-client.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502978





--- Comment #3 from Parag AN(पराग) panem...@gmail.com  2009-06-01 00:53:46 
EDT ---
I think you can even follow suggestion given on that guidelines page
1. Rename scripts in %{_bindir} to not have a .py extension: For instance, from
/usr/bin/orient.py to /usr/bin/orient.
This will clean rpmlint output.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503298] Review Request: vim-bash-support - BASH-IDE for VIM

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503298





--- Comment #1 from Ricky Zhou rz...@redhat.com  2009-06-01 00:59:40 EDT ---
Some other package submissions from cga:
vim-c-support (bug 503300)
vim-nerdtree (bug 503301)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503189] Review Request: python-gnutls - Python wrapper for the GNUTLS library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503189





--- Comment #2 from Parag AN(पराग) panem...@gmail.com  2009-06-01 01:09:39 
EDT ---
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1386463

missing BuildRequires: python-setuptools-devel as per given at
https://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503189] Review Request: python-gnutls - Python wrapper for the GNUTLS library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503189


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-06-01 01:09:07 
EDT ---
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1386463

missing BuildRequires: python-setuptools-devel as per given at

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503300] Review Request: vim-c-support - C/C++ IDE for VIM

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503300


Ricky Zhou rz...@redhat.com changed:

   What|Removed |Added

 CC||rz...@redhat.com




--- Comment #2 from Ricky Zhou rz...@redhat.com  2009-06-01 01:14:42 EDT ---
I don't think the iconv in %prep is necessary in this one, since
README.csupport looks fine in the zip file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 469460] review request: gir-repository - GObject Introspection Repository

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469460





--- Comment #7 from Rakesh Pandit rpan...@redhat.com  2009-06-01 01:16:18 EDT 
---
May you import it as soon as possible, I am looking to package whole
gnome-shell and stack packages and dependencies and this is blocker .. please
update to latest stable release ?

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503175] Review Request: perl-Crypt-GPG - Perl Object Oriented Interface to GnuPG

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503175


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-06-01 01:27:23 
EDT ---
please enable tests. use
%check
make test

Can you resubmit spec that will follow
https://fedoraproject.org/wiki/Packaging/Perl?

Also, you can use 
cpanspec Crypt-GPG to create spec file. see
https://fedoraproject.org/wiki/Perl/cpanspec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503013] Review Request: gnaughty - Downloader for adult content

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503013


Simon Wesp cassmod...@fedoraproject.org changed:

   What|Removed |Added

Summary|Review Request: gnaughty -  |Review Request: gnaughty -
   |porn downloader |Downloader for adult
   ||content




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484485] Review Request: perl-Fedora-App-ReviewTool - Application classes for reviewtool

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484485





--- Comment #24 from Chris Weyl cw...@alumni.drew.edu  2009-06-01 01:45:24 
EDT ---
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Fedora-App-ReviewTool.spec
SRPM URL:
http://fedorapeople.org/~cweyl/review/perl-Fedora-App-ReviewTool-0.10-1.fc10.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1386504

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484485] Review Request: perl-Fedora-App-ReviewTool - Application classes for reviewtool

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484485





--- Comment #25 from Chris Weyl cw...@alumni.drew.edu  2009-06-01 01:47:22 
EDT ---
Apologies for the massive delays with everything as of late: $life and $work
are conspiring against free time.

There's a scratch build of the latest above; though I see I need to bump the
version of Module::Install (to avoid the CPAN spew) and make sure
Fedora::Bugzilla is at 0.10.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503202] Review Request: blueproximity - A tool that locks/unlocks your screen when your bluetooth devices gets away/near from your computer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503202


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-06-01 01:56:25 
EDT ---
1) use patch names prefixed with package name
Patch0: blueproximity-fedorization.diff
Patch1: blueproximity-fix-bash-script.diff
also, change %prep as
%patch0 -p0 -b .fedorization
%patch1 -p0 -b .fix-bash-script

2) no need to use vendor in desktop-file-install. See
http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage
Remove fedora word from fedora-blueproximity.desktop file name.

3) files section should look like
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc ChangeLog COPYING README doc/
%{_datadir}/%{name}
%{_bindir}/%{name}
%{_datadir}/applications/fedora-%{name}.desktop
%{_datadir}/pixmaps/%{name}_base.svg

4) fix following warning
fedora-blueproximity.desktop: key Categories is a list and does not have a
semicolon as trailing character

5) preserve timestamps by using install command as install -p

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review