[Bug 508523] Review Request: miredo - Tunneling of IPv6 over UDP through NATs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508523 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-07-01 01:58:57 EDT --- miredo-1.1.6-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/miredo-1.1.6-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508693] Review Request: perl-CGI-Application-Plugin-ConfigAuto - Easy config file management for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508693 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2009-07-01 02:00:45 EDT --- Review: + package builds in mock (rawhide i586). koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1446011 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1527cac938bc9730a30a91c03bae68715866e6dc CGI-Application-Plugin-ConfigAuto-1.30.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=11, 1 wallclock secs ( 0.04 usr 0.02 sys + 0.23 cusr 0.04 csys = 0.33 CPU) + Package perl-CGI-Application-Plugin-ConfigAuto-1.30-1.fc12.noarch = Provides: perl(CGI::Application::Plugin::ConfigAuto) = 1.30 Requires: perl(Carp) perl(Exporter) perl(strict) perl(vars) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507695] Review Request: python-sqlalchemy0.5 - Modular and flexible ORM library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507695 --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2009-07-01 02:20:09 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507773] Review Request: python-daemon - Library to implement a well-behaved Unix daemon process
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507773 --- Comment #4 from Parag AN(पराग) panem...@gmail.com 2009-07-01 02:21:36 EDT --- is this built for requested branches? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504744] Review Request: python-yams - An Entity Relationship Schema
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504744 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-07-01 02:50:42 EDT --- when installed and tried to use I got Traceback (most recent call last): File /usr/bin/yams-check, line 8, in module from yams.reader import SchemaLoader File /usr/lib/python2.5/site-packages/yams/__init__.py, line 74, in module from yams.schema import Schema, EntitySchema, RelationSchema File /usr/lib/python2.5/site-packages/yams/schema.py, line 1219, in module from logilab.common.logging_ext import set_log_methods ImportError: cannot import name set_log_methods -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482216] Review Request: Mayavi - The Mayavi scientific data 3-dimensional visualizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482216 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2009-07-01 02:54:15 EDT --- Mayavi-3.2.0-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/Mayavi-3.2.0-6.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482216] Review Request: Mayavi - The Mayavi scientific data 3-dimensional visualizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482216 --- Comment #27 from Fedora Update System upda...@fedoraproject.org 2009-07-01 02:53:10 EDT --- Mayavi-3.2.0-6.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/Mayavi-3.2.0-6.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 --- Comment #3 from Parag AN(पराग) panem...@gmail.com 2009-07-01 03:09:04 EDT --- Got any updates from upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503617] Review Request: senamirmir-washra-fonts - Fonts for the Geʼez (Ethiopic) script
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503617 --- Comment #6 from Parag AN(पराग) panem...@gmail.com 2009-07-01 03:09:35 EDT --- So is this package built for requested branches? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491980] Review Request: bauble - Biodiversity collection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491980 --- Comment #11 from Pierre-YvesChibon pin...@pingoured.fr 2009-07-01 03:13:33 EDT --- Could you upload a srpm ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508850] Review Request: hunspell-et - Estonian hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508850 Caolan McNamara caol...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503617] Review Request: senamirmir-washra-fonts - Fonts for the Geʼez (Ethiopic) script
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503617 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #7 from Nicolas Mailhot nicolas.mail...@laposte.net 2009-07-01 04:10:18 EDT --- It should have been, don't know why bodhi didn't close this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508082] Review Request: php-pear-Auth_HTTP - Class providing HTTP authentication methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508082 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-07-01 04:16:48 EDT --- php-pear-Auth_HTTP-2.1.6-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pear-Auth_HTTP-2.1.6-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508082] Review Request: php-pear-Auth_HTTP - Class providing HTTP authentication methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508082 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-07-01 04:16:54 EDT --- php-pear-Auth_HTTP-2.1.6-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-pear-Auth_HTTP-2.1.6-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507157] Review Request: efte - A lightweight, extendable, folding text editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507157
Christoph Wickert fed...@christoph-wickert.de changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Christoph Wickert fed...@christoph-wickert.de 2009-07-01
04:24:26 EDT ---
(In reply to comment #4)
Ugh, missing %{buildroot} before %{_bindir}. Fixed.
Ouch, I overlooked that one, too.
- better use pushd/popd instead of cd src/cd ..
Maybe, if the directory structure was more complicated. The stack operations
pushd/popd seem a like an overkill :)
Not to me but it's up to you.
- Categories=Development;TextEditor; in the desktop file looks a little
unconventional, but I guess in this case it is correct.
Yes, since this is an editor for programmers.
Yes, and the freedesktop spec does not know editors for programmers and thinks
all editors are utilities. For programming it only knows IDE, but this would
really be too much for this app. Nevertheless some desktops might react a
little strange to this and show it in both categories.
http://theory.physics.helsinki.fi/~jzlehtol/rpms/efte.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/efte-1.0-4.fc11.src.rpm
Looks good and fixes all issues. efte-1.0-4.fc11.src.rpm is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502692] Review Request: mingw32-libatomic_ops - MinGW Windows libatomic_ops compression library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502692 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Status|NEW |ASSIGNED CC||erik-fed...@vanpienbroek.nl AssignedTo|nob...@fedoraproject.org|erik-fed...@vanpienbroek.nl Flag||fedora-review? --- Comment #1 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2009-07-01 04:28:21 EDT --- - Please change the %define tags at the top of the spec file with %global (because of http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define ) - What does the patch libatomic_ops-1.2-ppclwzfix.patch do? According to the filename I think it's some ppc-specific fix which doesn't have any effect on Win32 - Is it true that this package only provides a static library and no shared library (.dll) ? If that's the case, some special exceptions apply: http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries (however, we may need to interpret these slightly different as we don't use -devel subpackages) - The version number in the ChangeLog doesn't match the version specified in the Version and Release tags -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506804] Package Review: anerley - Moblin widgets for people information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506804 --- Comment #2 from Peter Robinson pbrobin...@gmail.com 2009-07-01 04:40:24 EDT --- Upstream is already at 0.0.12 Yes. Its moving quite quickly but 0.0.9 is currently what upstream is using. The plan was to get the basic moblin working and then moving components to newer versions where its easier to see what broke. ./autogen.sh %configure --disable-static autogens tend to run configure, so here we have it twice which I think is best avoided, say ./autogen.sh --help /dev/null or looking at what autogen does autoreconf -v -i I leave it there in the dream that one day they will do releases with make dist :) Requires: gtk-doc doesn't seem to be necessary, no doc build setup upstream yet Yes, I'd already fixed that on my local copy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455227] Review Request: php-pecl-parsekit - PHP Opcode Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455227 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-07-01 04:57:02 EDT --- php-pecl-parsekit-1.2-3.CVS20090309.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pecl-parsekit-1.2-3.CVS20090309.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507157] Review Request: efte - A lightweight, extendable, folding text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507157 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi 2009-07-01 05:38:40 EDT --- Thanks for the review! New Package CVS Request === Package Name: efte Short Description: A lightweight, extendable, folding text editor for X11 Owners: jussilehtola Branches: EL-5 F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492203] Review Request: frinika - Music Workstation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492203
--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2009-07-01 05:35:16 EDT ---
(In reply to comment #7)
$ ant jar javadocs
I noticed that ant is pulled by other BR's. But I added it anyways.
Off course. In opposite it was not be built. But it is may be occasionaly and
this BR required by guidelines for ant-based packages.
The patch is not needed for the SevenZip that is in the frinika tarball. It is
specific for the SevenZip we have in Fedora.
If bundled SevenZip is not used anymore, you really need this patch?
From this I look again on this symlinks. I think instead of doing such
symlink
you should use build-classpath:
http://fedoraproject.org/wiki/Packaging:Java#build-classpath
build-classpath only works for jar files that go to %{_javadir}. As indicated
in
http://fedoraproject.org/wiki/Packaging:Java#Guideline
the JNI using jar files go to %{_libdir}/%{name} and build-classpath will not
work on them. They need to be added manually.
Cite from above URL:
If the package installs a wrapper script you'll need to manually add
%{_libdir}/%{name}/jar filename to CLASSPATH. If you are depending on a
JNI-using JAR file, you'll need to add it manually -- build-classpath will not
find it.
end cite
As I can understand it, it is about adding paths into CLASSPATH manually, not
create symlinks.
I'm not very similar with java (as you already known), sorry if it is not
correct.
I updated the package (also fixed the other issues you pointed):
Spec URL: http://oget.fedorapeople.org/review/frinika.spec
SRPM URL:
http://oget.fedorapeople.org/review/frinika-0.5.1-4.548svn.fc11.src.rpm
ChangeLog: 0.5.1-4.548svn
- Update to svn revision 548
- License is GPLv2+
- Add BR: ant
- Add more comments on sources patches
- Make the snapshot script nicer (thanks to Pavel Alexeev)
- Remove flexdock versioned symlink workaround
- Remove some unneeded sources
So, I removed the Dknob sources from src/com/dreamfabric/ . As far as I can
tell, they are not used by frinika. I think the only remaining issues are
these
additional sources. I asked about them (Dknob and others) upstream
https://sourceforge.net/forum/forum.php?thread_id=3319021forum_id=447356
They usually respond fast. Let us wait and see what will come out.
Ok, I'm not hurrying yum.
Meanwhile, on current stage some additional notes:
1) lib directory in tarball contains many binary jars and even library .so. It
is needed? I'm still do not do any investigation, but you are assured tha don't
used in build? What all built from sources? May be safely remove such binaries
in our svn-fetch script?
2) Just for note: In fetch script in latest option first fetch last revision
number to provide in -r option of svn. It is excessive. There may be HEAD. Or
just this key ommited (how you was used it in svn co previous). Like:
if [ 'latest' == $1 ]; then
REV=-rHEAD # OR just REV=
else
REV=-r$1
fi
svn export $REV
3) I see comment about all other sources. But what about fetch instruction to
Source0 (about what script with what parameter must be used)?
4) You remove DKnode, nice. But petersalomonsen component stil here.
5) Just intresting:
# Remove some unneded sources
rm -fr src/uk/ac/bath/gui/vamp/KnobWidget.java
rm -fr src/uk/ac/bath/gui/vamp/VAmp2Editor.java
for what them? Is there any legal issues? It is break build?
Most other seems good. I'll relook on it again after we got answer from Dknob
upstream and make decision what do with petersalomonsen.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455227] Review Request: php-pecl-parsekit - PHP Opcode Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455227 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-07-01 05:38:18 EDT --- php-pecl-parsekit-1.2-3.CVS20090309.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-pecl-parsekit-1.2-3.CVS20090309.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508523] Review Request: miredo - Tunneling of IPv6 over UDP through NATs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508523 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-07-01 05:43:50 EDT --- miredo-1.1.6-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/miredo-1.1.6-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502692] Review Request: mingw32-libatomic_ops - MinGW Windows port of the libatomic_ops library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502692 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Summary|Review Request: |Review Request: |mingw32-libatomic_ops - |mingw32-libatomic_ops - |MinGW Windows libatomic_ops |MinGW Windows port of the |compression library |libatomic_ops library --- Comment #2 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01 06:12:06 EDT --- Thx for the review: Spec URL: http://kwizart.fedorapeople.org/review/mingw32-libatomic_ops.spec SRPM URL: http://kwizart.fedorapeople.org/review/mingw32-libatomic_ops-1.2-2.fc11.src.rpm Description: MinGW Windows port of the libatomic_ops library Changelog: - - Drop the powerpc patch - Move to %%global from %%define - Provides -static as there is only one static library - Rsync with native package (Fix the License tag) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501251] Review Request: perl-Tk-Stderr - Capture standard error output, display in separate window for Perl::Tk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501251 --- Comment #16 from Xavier Lamien lxt...@gmail.com 2009-07-01 06:22:33 EDT --- David, you might miss some packaging steps. Here's how to request a push into FPC repositories: = https://fedoraproject.org/wiki/Package_update_HOWTO#Submit_your_update_to_Bodhi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505406] Review Request: rubygem-rake-compiler - Rake-based Ruby C Extension task generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505406 Xavier Lamien lxt...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Xavier Lamien lxt...@gmail.com 2009-07-01 06:42:34 EDT --- OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK Global are used. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package in part of reason has been given properly. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in koji (F-11 Rawhide -- noarch). OK rpmlint is silent. OK final provides and requires look sane. -- %check is present (however, test need more work, not a blocker). OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK huge %docs has been moved to sub-package OK package installed properly According to ruby guideline, the package uses proper ruby specific packaging. ** APPROVED ** ps: sorry for have been so long. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477683] Review Request: fltk2 - C++ user interface toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477683 --- Comment #18 from Michal Nowak mno...@redhat.com 2009-07-01 07:13:36 EDT --- http://mnowak.fedorapeople.org/fltk2/fltk2-2.0.x-0.12.r6793.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506339] Review Request: XZ Utils - LZMA Utils with newer file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506339 --- Comment #14 from Panu Matilainen pmati...@redhat.com 2009-07-01 07:30:16 EDT --- One possibility would be using a snapshot from the git repo instead of the official beta tarball, that would get the licensing straight from the start: commit 02ddf09bc3079b3e17297729b9e43f14d407b8fc Author: Lasse Collin lasse.col...@tukaani.org Date: Mon Apr 13 11:27:40 2009 +0300 Put the interesting parts of XZ Utils into the public domain. Some minor documentation cleanups were made at the same time. In addition to that, there are a few fairly important looking fixes, such as xz crashing when decompressing two files with a single xz command, and identifying some corrupted files as valid. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #2 from Bruno Wolff III br...@wolff.to 2009-07-01 08:07:20 EDT --- If I make the package noarch, do I need to take steps to block it from being compiled by gcj? I am not sure about javadoc. I don't believe the game is meant to export an interfaces to other stuff. There are important internal interfaces as it's client server and development is being done on a game lobby. But I don't know if that should show up in javadoc or not. When I watch the javadoc build I do get some warnings about references to stuff from jdom. I don't know if that's really an issue or not. Titan is currently being sold. It's a small operation, so that may not have paid to register the trademark. Also they are using new artwork. The guy who did the original artwork is kind of reclusive and they were going to want a more modern look. The original game had one color sheets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504478] Review Request: rubygem-diff-lcs - Provide a list of changes between two sequenced collections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504478 Michal Ingeli m...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@v3.sk AssignedTo|nob...@fedoraproject.org|m...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501251] Review Request: perl-Tk-Stderr - Capture standard error output, display in separate window for Perl::Tk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501251 --- Comment #17 from David Hannequin david.hanneq...@gmail.com 2009-07-01 08:26:30 EDT --- i done updates in bodhi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508239] Review Request: perl-Hash-Merge - Merges arbitrary deep hashes into a single hash
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508239 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag||fedora-cvs+ --- Comment #7 from Tom spot Callaway tcall...@redhat.com 2009-07-01 09:09:44 EDT --- New Package CVS Request === Package Name: perl-Hash-Merge Short Description: Merges arbitrary deep hashes into a single hash Owners: spot Branches: EL-4 EL-5 F-10 F-11 devel InitialCC: perl-sig ... and it's done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 --- Comment #2 from Darryl L. Pierce dpie...@redhat.com 2009-07-01 09:07:30 EDT --- (In reply to comment #1) - bad license. should be MIT [1] Fixed. - missing require for ruby(abi) Fixed. - file listed twice warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE - rubygem-state_machine.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 7) Hmmm. I don't see this error. I did a scratch build, then downloaded and ran rpmlint on the RPM and saw no complaints. Can you tell me how you produced this? (mcpie...@mcpierce-laptop:rubygem-state_machine)$ rpmlint ~/Download/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Updated spec: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1446813 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505406] Review Request: rubygem-rake-compiler - Rake-based Ruby C Extension task generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505406 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 09:16:30 EDT --- No problem, thank you for reviewing this ticket. New Package CVS Request === Package Name: rubygem-rake-compiler Short Description: Rake-based Ruby C Extension task generator Owners: mtasaka Branches: F-11 F-10 InitialCC: (nobody) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509121] New: Review Request: python-kaa-display - Python API providing Low level support for various displays
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-kaa-display - Python API providing Low level support for various displays https://bugzilla.redhat.com/show_bug.cgi?id=509121 Summary: Review Request: python-kaa-display - Python API providing Low level support for various displays Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/SPECS/python-kaa-display.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/python-kaa-display-0.1.0-1.fc11.src.rpm Description: Python API providing Low level support for various displays rpmlint is clean on installed file! Patch0 is a backport of what is currently in upstream svn Patch1 is a hack that seems needed when no X11 server is active on the buildhost. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502692] Review Request: mingw32-libatomic_ops - MinGW Windows port of the libatomic_ops library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502692 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Alias||libatomic_ops -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508082] Review Request: php-pear-Auth_HTTP - Class providing HTTP authentication methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508082 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 09:49:43 EDT --- Now closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504478] Review Request: rubygem-diff-lcs - Provide a list of changes between two sequenced collections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504478 Michal Ingeli m...@v3.sk changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Michal Ingeli m...@v3.sk 2009-07-01 09:49:29 EDT --- * naming OK * licensing OK * Clean, legible spec file, American English * source file matches upstream * file list, documentation, permissions OK * builds in mock * rpmlint warnd about Artistic license, but upstream also declares usage of Ruby and GPLv2+, and that's OK APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508126] Review Request: education-bookmarks - Education SIG spin bookmarks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508126 Sebastian Dziallas sebast...@when.com changed: What|Removed |Added Blocks||506597(EducationTracker) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508075] Review Request: php-pear-HTML_Javascript - Class for creating simple JS scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508075 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 10:09:40 EDT --- Okay. This package (php-pear-HTML_Javascript) is APPROVED by mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507052] Review Request: Panini - A tool for creating perspective views from panoramic and wide angle images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507052 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||kwiz...@gmail.com AssignedTo|nob...@fedoraproject.org|kwiz...@gmail.com Flag||fedora-review? --- Comment #1 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01 10:14:43 EDT --- - starting review - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481355] Review Request: nurbs++ - A C++ library to manipulate and create NURBS curves and surfaces.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481355 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 10:13:08 EDT --- Once I want to hear spot's opinion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492224] Review Request: gnome-mud - MUD client for GNOME desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492224 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(s...@middleditch. ||us) --- Comment #17 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 10:15:47 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 10:19:02 EDT --- spot, would you tell us your opinion for the comment 7? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507631] Review Request: rubygem-rubyzip - Ruby module for reading and writing zip files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507631 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(mastah...@gmail.c ||om) --- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 10:22:32 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507761] Review Request: rubygem-coderay - CodeRay is a fast syntax highlighter engine for many languages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507761 Bug 507761 depends on bug 504469, which changed state. Bug 504469 Summary: Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences https://bugzilla.redhat.com/show_bug.cgi?id=504469 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504469] Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01 10:20:12 EDT --- Closing this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504479] Review Request: rubygem-cucumber - Tool to execute plain-text documents as functional tests
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504479 Bug 504479 depends on bug 504469, which changed state. Bug 504469 Summary: Review Request: rubygem-term-ansicolor - Ruby library that colors strings using ANSI escape sequences https://bugzilla.redhat.com/show_bug.cgi?id=504469 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507915] Review Request: ldd-pdf - Linux Device Drivers, Third Edition Book in PDF format
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507915
steve st...@lonetwin.net changed:
What|Removed |Added
Summary|Review Request: ldd3-pdf - |Review Request: ldd-pdf -
|Linux Device Drivers, Third |Linux Device Drivers, Third
|Edition Book in PDF format |Edition Book in PDF format
--- Comment #16 from steve st...@lonetwin.net 2009-07-01 10:25:44 EDT ---
Just an FYI update to all those subscribed, I made a few changes:
a. Included the source code for the examples in the book from the o'rielly ftp
server.
b. changed the package name from ldd3-pdf to ldd-pdf (you make have noticed
that in the cvs request)
c. Changed the name installation dir from %{_docdir}/ldd3-pdf to
%{_docdir}/%{name}-%{version}
spec and srpm are checked into cvs
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507052] Review Request: Panini - A tool for creating perspective views from panoramic and wide angle images
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507052
--- Comment #2 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01
10:36:40 EDT ---
A new version is here : 0.71.100
%prep
try to keep timestamp when using %{__sed} -i 's/\r//'
It shouldn't be needed to use CFLAGS=${CFLAGS:-%optflags} ; export CFLAGS to
use our opt flags(at least on recent Fedora).
License Field is GPLv2+ (which match source code header) but GPLv3 text file is
redistributed. (need to check lastest version)
Please submit .desktop and icon upstream or pick the one from the package if
available.
Try to have the compiled binary / pixmaps installed with make install at
%install step.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508075] Review Request: php-pear-HTML_Javascript - Class for creating simple JS scripts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508075 Andrew Colin Kissa and...@topdog.za.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Andrew Colin Kissa and...@topdog.za.net 2009-07-01 10:44:22 EDT --- Thanks for the review Mamoru, New Package CVS Request === Package Name: php-pear-HTML_Javascript Short Description: Class for creating simple JS scripts Owners: topdog Branches: F-10 F-11 InitialCC: mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #12 from Tom spot Callaway tcall...@redhat.com 2009-07-01 10:59:38 EDT --- The meat of this license looks fine, but Red Hat Legal pointed out that the copyright holder in xsd appears to be both Boris Kolpackov and Code Synthesis Tools. Therefore, please change the text that says ... Boris Kolpackov gives permission ... to something like ... Boris Kolpackov and Code Synthesis Tools CC give permission ... to make sure we're covered in case Boris's employer is the copyright holder of some or all of the GPL-licensed code here. Once this is done, we should use this for the SPEC: # Exceptions permit otherwise GPLv2 incompatible combination with ASL 2.0 License: GPLv2 with exceptions and ASL 2.0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490061] Review Request: awesfx - Utility programs for AWE32/Emu10k1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490061 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2009-07-01 11:03:35 EDT --- awesfx-0.5.1c-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/awesfx-0.5.1c-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490061] Review Request: awesfx - Utility programs for AWE32/Emu10k1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490061 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-07-01 11:03:29 EDT --- awesfx-0.5.1c-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/awesfx-0.5.1c-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #13 from Boris Kolpackov bo...@codesynthesis.com 2009-07-01 11:14:07 EDT --- The xsd-3.2.0+dep package is actually the xsd compiler itself packaged with all its dependencies (there is also xsd-3.2.0 which is just the xsd compiler). Some of these dependencies are copyright Boris Kolpackov while the xsd compiler and the xsd-frontend library are copyright Code Synthesis Tools. The latter two (xsd and xsd-frontend) already include the exception that allows linking to Xerces-C++. It is the other packages (which are copyright Boris Kolpackov) that need the exception added. That's why the text uses Boris Kolpackov instead of Boris Kolpackov Code Synthesis Tools. Hope this clarifies things. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507761] Review Request: rubygem-coderay - CodeRay is a fast syntax highlighter engine for many languages
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507761
--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-07-01
11:17:12 EDT ---
For -2:
* License
- Now for this license the license tag should be LGPLv2+.
* Summary
- Now Fedora thinks writing the package name (Coderay) in
Summary is redundant.
* Directory ownership issue
- The directory %{geminstdir}/lib is not owned by this package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503297] Review Request: panoglview - Immersive viewer for spherical panoramas
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503297
Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||kwiz...@gmail.com
AssignedTo|nob...@fedoraproject.org|kwiz...@gmail.com
Flag||fedora-review?
--- Comment #3 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01
11:18:21 EDT ---
- starting review -
OK - rpmlint panoglview is quiet on installed package
OK - build in mock (fedora 11 x86_64 )
NEEDWORK - You aren't expected to run:
update-mime-database %{_datadir}/mime
Because this package doesn't bring any new mime type. But indeed
update-desktop-database is mandatory since the .desktop file use a MimeType=
field. As said:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
By the way, using || : at the end of each scriptlet filters the error code if
anything went wrong. So this only makes sense for the last line:
example :
first command /dev/null
second command /dev/null || :
That way, the rpm transaction will continue, even if update-desktop-database
failed.
NEEDWORK - License match source code : GPLv2+ but COPYING text is about GPLv3.
This would need clarification
NEEDWORK - url field cannot permit to download the source tarball (is it the
right url ?)
USABILITY test: I'm experiencing some refresh delay when moving the sphere.
I will try to reproduce on another workstation.
(Is it expected to see only from the inside despite of the outside of the
sphere ?)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509158] New: Review Request: gnat-project-common – files shared by Ada libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnat-project-common – files shared by Ada libraries https://bugzilla.redhat.com/show_bug.cgi?id=509158 Summary: Review Request: gnat-project-common – files shared by Ada libraries Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bj...@xn--rombobjrn-67a.se QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.rombobjörn.se/packages/gnat-project-common.spec SRPM URL: http://www.rombobjörn.se/packages/gnat-project-common-1-1.fc11.src.rpm Description: The gnat-project-common package contains some small files that help a GNAT project file to work for both 32-bit and 64-bit versions of an Ada library. The plan is that all -devel packages with Ada libraries will use these files. So far they are used by PragmARC-devel. The package also adds a couple of RPM macros to help with packaging Ada programs and libraries. RPMlint output: gnat-project-common.spec: E: no-buildroot-tag Since RPMbuild now ignores the buildroot tag I don't see why I would need one. gnat-project-common.noarch: W: no-url-tag This package contains 17 lines of code in total, written by me specifically for Fedora. Do I still need to set up a website for it? gnat-project-common.noarch: W: only-non-binary-in-usr-lib There are no compiled libraries in this package but there is a GNAT project file, and GNAT looks for project files in /usr/lib/gnat so that's where I need to put it. It could be argued that /usr/share/gnat would be a better location but that would require a change in GNAT. gnat-project-common.noarch: W: no-documentation There is documentation in the form of comments in the files, which is where I think it belongs for the time being. gnat-project-common.noarch: W: non-conffile-in-etc /etc/profile.d/gnat-project.sh gnat-project-common.noarch: W: non-conffile-in-etc /etc/profile.d/gnat-project.csh gnat-project-common.noarch: W: non-conffile-in-etc /etc/rpm/macros.gnat I suppose it could be debated whether those are configuration files or program code, but they need to be in these directories to be effective. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1447086 I should also mention that I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509159] New: Review Request: PragmARC – a component library for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: PragmARC – a component library for Ada https://bugzilla.redhat.com/show_bug.cgi?id=509159 Summary: Review Request: PragmARC – a component library for Ada Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bj...@xn--rombobjrn-67a.se QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.rombobjörn.se/packages/PragmARC.spec SRPM URL: http://www.rombobjörn.se/packages/PragmARC-20060427-1.fc11.src.rpm Description: The PragmAda Reusable Components (PragmARCs) is a library of containers, algorithms and utility components for Ada, ranging from the basic-but-essential to the high-level. This package depends on gnat-project-common, review request 509158. It won't work with gcc-gnat-4.4.0-4; see bug 507247 and the patch submitted there. RPMlint output: PragmARC.spec: E: no-buildroot-tag Since RPMbuild now ignores the buildroot tag I don't see why I would need one. I should also mention that I need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505965] Review Request: supybot-meetbot - Plugin for Supybot for handling IRC meetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505965 --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-07-01 11:31:37 EDT --- Yeah, sorry for the delay here. ;( He has just checked in a bunch of changes to his devel branch that he wants me to test before landing in stable. I will try and do that in the next few days and hopefully thats the version I can get imported. If not, he did tag version 0.1 in the stable repo with what we have now, so I can just check that in if there are problems with the new changes. :) Sorry again for the delay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509159] Review Request: PragmARC – a comp onent library for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509159 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Blocks||509160 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||509159 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509160] New: Review Request: mine_detector – a mine-finding game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mine_detector – a mine-finding game https://bugzilla.redhat.com/show_bug.cgi?id=509160 Summary: Review Request: mine_detector – a mine-finding game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: bj...@xn--rombobjrn-67a.se QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.rombobjörn.se/packages/mine_detector.spec SRPM URL: http://www.rombobjörn.se/packages/mine_detector-5.0-1.fc11.src.rpm Description: Mine Detector is a mine-finding game with somewhat different rules from other mine-finding games. Mine Detector rarely requires guessing. Only at the higher levels may guessing sometimes be the only way to win. The program uses the PragmAda Reusable Components, review request 509159. RPMlint output: mine_detector.spec: E: no-buildroot-tag Since RPMbuild now ignores the buildroot tag I don't see why I would need one. I should also mention that I need a sponsor. By the way, Mine Detector doesn't use a flag icon to mark cells as mines, so it should be politically safe. ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509158] Review Request: gnat-project-common – files shared by Ada libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509158 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Blocks||509159 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509158] Review Request: gnat-project-common – files shared by Ada libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509158 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509159] Review Request: PragmARC – a comp onent library for Ada
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509159 Björn Persson bj...@xn--rombobjrn-67a.se changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) Depends on||509158, 507247 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507915] Review Request: ldd-pdf - Linux Device Drivers, Third Edition Book in PDF format
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507915
Dennis Gregorovic dgre...@redhat.com changed:
What|Removed |Added
CC||dgre...@redhat.com
--- Comment #17 from Dennis Gregorovic dgre...@redhat.com 2009-07-01
11:37:51 EDT ---
(In reply to comment #10)
(In reply to comment #9)
I disaggree with you in this point. Even if alle the releases contains the
same
content, it may be helpful to use the %{dist} tag. For example for F-12 the
usage of LZMA to compress the rpm data is planed. So on the dist tag, you
can
see, if you can use a package for F-12 or not without a try to install it.
Not using the %dist tag doesn't mean the F12 package won't be LZMA compressed.
What matters is when one updates, say from F11 to F12 the packages that don't
have the %dist tag won't be updated (until a new version is available in the
updates repo) if the version and release in both distros is the same: say,
foo-1-1 in F11 and foo-1-1 in F12.
I'm not following the logic here.
With the dist tag: If you have foo-1-1.fc11 in F11 and don't rebuild it, then
you will have foo-1-1.f11 in F12. If you rebuild it, then you'll have
foo-1-1.f12 in F12.
Without the dist tag: If you have foo-1-1 in F11 and don't rebuild it, then you
will have foo-1-1 in F12. If you rebuild it, then you'll have foo-1-2 or
foo-1-1.1 in F12, depending on your numbering preference.
The dist tag doesn't cause any additional builds and only helps when you need
to rebuild.
When the dist tag is used the F12 package foo-1-1.fc12 will be newer than
foo-1-1.fc11 and thus will replace the old one.
In case the package is (close to) identical in both distros [no binaries
compiled], not using the dist tag saves some download and update time.
It sounds like there is some assumption that the dist tag ties a particular
build to a release. That's not the case. There are plenty of .fc9 package in
F10, for example.
Of course, generally speaking something is compiled in every package and the
%dist tag should be used, so from a stylistic point of view using it could be
advised in these cases too. However, if the package is as big as the SRPM (11
MB) I wouldn't put in a %dist tag since nothing is gained from it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502024] Review Request: xsd - W3C XML schema to C++ data binding compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502024 --- Comment #14 from Tom spot Callaway tcall...@redhat.com 2009-07-01 11:52:47 EDT --- Sure, that makes sense. Once the package is updated with the new license, I'll lift FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503252] Review Request: freepv - Immersive panorama viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503252 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added CC||kwiz...@gmail.com --- Comment #3 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01 11:50:10 EDT --- FE-Legal remains blocked, do we still need advices ? Searching about patent QuickTimeVR over the web seems to output a weird thing held by iPIX from 1999. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508239] Review Request: perl-Hash-Merge - Merges arbitrary deep hashes into a single hash
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508239 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-07-01 11:56:38 EDT --- perl-Hash-Merge-0.11-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Hash-Merge-0.11-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508239] Review Request: perl-Hash-Merge - Merges arbitrary deep hashes into a single hash
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508239 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-07-01 11:56:32 EDT --- perl-Hash-Merge-0.11-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Hash-Merge-0.11-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503297] Review Request: panoglview - Immersive viewer for spherical panoramas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503297 --- Comment #4 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01 12:13:31 EDT --- There isn't any icon from the package and .desktop file ! Is it possible to pick one ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503297] Review Request: panoglview - Immersive viewer for spherical panoramas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503297 --- Comment #5 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01 12:18:19 EDT --- OKay, package works with radeon (x600se hardware) i686 F-11 whereas gives problem with nvidia lastest 3D driver F-11 x86_64. I will consider usability test to have succeeded -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509171] New: Review Request: perl-String-RewritePrefix - Rewrite strings based on a set of known prefixes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-String-RewritePrefix - Rewrite strings based on a set of known prefixes https://bugzilla.redhat.com/show_bug.cgi?id=509171 Summary: Review Request: perl-String-RewritePrefix - Rewrite strings based on a set of known prefixes Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/String-RewritePrefix OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cw...@alumni.drew.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~cweyl/review/perl-String-RewritePrefix.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-String-RewritePrefix-0.004-1.fc11.src.rpm Description: Rewrite strings based on a set of known prefixes. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1447402 Additional Comment: This is a new requirement of the latest GA Catalyst::Runtime. *rt-0.10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #3 from Bruno Wolff III br...@wolff.to 2009-07-01 12:22:01 EDT --- Just to track this here, I noticed that the icon cache gets updated after javadoc is installed. If I end up needing to keep javadoc, I'll want to figureout how to attach the post and postun scripts just to the base package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #4 from Bruno Wolff III br...@wolff.to 2009-07-01 12:24:37 EDT --- Further note, the scripts aren't actually in the javadoc package, the output from yum just made it look that way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509158] Review Request: gnat-project-common – files shared by Ada libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509158 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added CC||joc...@herr-schmitt.de --- Comment #1 from Jochen Schmitt joc...@herr-schmitt.de 2009-07-01 12:24:30 EDT --- If the upstream sources are Fedora specific, it may be nice, if you can ask on fedorahosted.org for creating a project in which the sources may be hosted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503252] Review Request: freepv - Immersive panorama viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503252 Bruno Postle br...@postle.net changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED --- Comment #4 from Bruno Postle br...@postle.net 2009-07-01 12:25:16 EDT --- IPIX made various claims over panorama creation, I'm not aware that panorama viewers were ever threatened. Since submitting this package I discovered it doesn't compile with the xulrunner in F11, I patched it up but now it fails at runtime - This is something for upstream to fix I think, so I'll close and reopen if a fixed version becomes available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509178] New: Review Request: perl-namespace-autoclean - Keep imports out of your namespace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-namespace-autoclean - Keep imports out of your namespace https://bugzilla.redhat.com/show_bug.cgi?id=509178 Summary: Review Request: perl-namespace-autoclean - Keep imports out of your namespace Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/namespace-autoclean OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cw...@alumni.drew.edu QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~cweyl/review/perl-namespace-autoclean.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-namespace-autoclean-0.08-1.fc11.src.rpm Description: When you import a function into a Perl package, it will naturally also be available as a method. The 'namespace::autoclean' pragma will remove all imported symbols at the end of the current package's compile cycle. Functions called in the package itself will still be bound by their name, but they won't show up as methods on your class or instances. This module is very similar to namespace::clean, except it will clean all imported functions, no matter if you imported them before or after you 'use'd the pagma. It will also not touch anything that looks like a method, according to 'Class::MOP::Class::get_method_list'. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1447435 Additional Comment: This is a new requirement of the latest GA Catalyst::Runtime. *rt-0.10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503252] Review Request: freepv - Immersive panorama viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503252 --- Comment #5 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-01 12:38:25 EDT --- Okay, please cc'd wherever this package ends. I would be interested in it given the GSoC link at videolan.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509158] Review Request: gnat-project-common – files shared by Ada libraries
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=509158
--- Comment #2 from Jochen Schmitt joc...@herr-schmitt.de 2009-07-01
12:41:44 EDT ---
here are some point of my pre-review:
Good:
+ Basename of the SPEC file matches with package name
+ Package doesn't contains subpackages
+ Local build works fine
+ Package has no %doc stanza
+ BuildRoot will be cleaned at the beginning of %clean and %install
Bad:
- Because the package should be fedora specific, it should be named as
fedora-gnat-...
- Source tag contains not a fully qualified URI. Submitter should create
a project on fedorahosted.org
- Could not check packaged tar ball agains upstream.
- Package doesn#t contains a URL tag
- License tag say 'Copyright only' this is not a valid OSS license
- Package contains not a verbatin copy of the license text
- Pleace use %{_sysconfdir} instead of /etc in the %files stanza
- you should use a version like 0.1 instead of 1, because I'm assume
your are the upstream and this is the first release of the software
- Package has no proper BuildRoot definition
If you have any question, you may contact me via email
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #4 from Jochen Schmitt joc...@herr-schmitt.de 2009-07-01 12:50:37 EDT --- your explaination make sense for me. for formal reason I will notifiy a FESCo member about this situation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508691] Review Request: perl-CGI-Application-Dispatch - Dispatch requests to CGI::Application based objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508691 --- Comment #2 from Emmanuel Seyman emmanuel.sey...@club-internet.fr 2009-07-01 13:06:42 EDT --- (In reply to comment #1) APPROVED. Can I ask you to raise the flag fedora‑review ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507260] Review Request: wordpress-mu-plugin-defaults - WordPress MU Plugin to set new blog default settings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507260 Ian Weller i...@ianweller.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|i...@ianweller.org Flag||fedora-review? --- Comment #3 from Ian Weller i...@ianweller.org 2009-07-01 13:24:24 EDT --- I still can't sponsor you but Toshio will on my recommendation, he says, so I guess I'll assign this to me. - Check your %description, it's a bit messy. Everything else looks good to me, and rpmlint is quiet. Full review after you fix the description. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507260] Review Request: wordpress-mu-plugin-defaults - WordPress MU Plugin to set new blog default settings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507260 --- Comment #4 from Nick Bebout n...@fedoraproject.org 2009-07-01 13:29:11 EDT --- RPM: http://nb.fedorapeople.org/wordpress-mu-plugin-defaults-1.2.3-2.fc11.noarch.rpm SRPM: http://nb.fedorapeople.org/wordpress-mu-plugin-defaults-1.2.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #5 from Jochen Schmitt joc...@herr-schmitt.de 2009-07-01 13:40:12 EDT --- Good: + Basename of the SPEC files matches with package name + Package name fullfill naming guidelines + Package contains several subpackages + Package has proper license tag + Could download upstream sources via spectool -g + Package files matches with upstream (md5sum: 882ec96bef41962a33a24d6ee5821a29 volume_key-0.2.tar.bz2 0910632173fb960252412bf7342b42fc cryptsetup-1.0.7-rc1.tar.bz2) + License tag state GPLv2 as a valid OSS license + Package contains verbatin copy of the license tag + Copyrigh note in the source files matches with license tag + Consitantly usage of rpm macors + Package has proper BuildRoot definition + BuildRoot will be cleaned at the beginning of %clean and %install + Mock build works fine agains fedora-devel-x86_64 + Package nonour rpmootflags + Rpmlint is silent for source rpm + Scratch build on koji works fine + Files has proper files permissions + %files stanza contains no dupblicated entries + All packaged files belongs to this package + No packaged files are own by another package + %doc stanza is small + package has proper changelog Bad: - Application is linked staticly agains a patched release of cryptsetup. This is accepted temporarly to avoid un official changes of the programming interfaces - Could not find libblkid-devel as BR - you mas include the crypsetup patch via a Patch statement - some warnings from rpmlint on binary packages $ rpmlint volume_key-devel-0.2-1.x86_64.rpm volume_key-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [s450...@zeus result]$ rpmlint python-volume_key-0.2-1.x86_64.rpm python-volume_key.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - Verbatin copy of the license will no included in the %doc stanza - Please remove the *.la files instead of exclude it in the %files stanza -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489014] Review Request: gnome-do-plugins - Plugins for Gnome Do
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 --- Comment #36 from Paul Lange pala...@gmx.de 2009-07-01 13:47:06 EDT --- Juan, I'm sorry. i made some mistakes but it should work right now. New build has been done and the update is issued. See https://admin.fedoraproject.org/updates/flickrnet-2.1.5-4.fc11) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #6 from Miloslav Trmač m...@redhat.com 2009-07-01 13:53:43 EDT --- Thanks for the review. (In reply to comment #5) - Could not find libblkid-devel as BR Provided by util-linux-ng in rawhide, see e.g. http://koji.fedoraproject.org/koji/buildinfo?buildID=105530 - you mas include the crypsetup patch via a Patch statement I do: | # http://code.google.com/p/cryptsetup/issues/detail?id=15 | Patch0: https://fedorahosted.org/releases/v/o/volume_key/cryptsetup-svn-r62.patch - some warnings from rpmlint on binary packages $ rpmlint volume_key-devel-0.2-1.x86_64.rpm volume_key-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [s450...@zeus result]$ rpmlint python-volume_key-0.2-1.x86_64.rpm python-volume_key.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. I'm afraid there really is no documentation (well, I have a sample Python program, but not a documentation of the interface). - Verbatin copy of the license will no included in the %doc stanza See the libs subpackage - if any subpackage is installed, volume_key-libs will be installed as well. - Please remove the *.la files instead of exclude it in the %files stanza Why? Does it make any difference? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #7 from Jochen Schmitt joc...@herr-schmitt.de 2009-07-01 14:01:21 EDT --- (In reply to comment #6) - Please remove the *.la files instead of exclude it in the %files stanza Why? Does it make any difference? Rpm should have a bug which cause a wrong calculation of the required space, if you are excluding files in the %files stanza. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #8 from Miloslav Trmač m...@redhat.com 2009-07-01 14:09:20 EDT --- (In reply to comment #7) (In reply to comment #6) - Please remove the *.la files instead of exclude it in the %files stanza Why? Does it make any difference? Rpm should have a bug which cause a wrong calculation of the required space, if you are excluding files in the %files stanza. #247374 indicates this is fixed in Fedora = 10. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491980] Review Request: bauble - Biodiversity collection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491980 --- Comment #12 from Simon Wesp cassmod...@fedoraproject.org 2009-07-01 14:18:11 EDT --- first i have to build it... ehm, i have the same error as in bashstyle i have to look at the weekend. in the week it's hard because i have a time-consuming job -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509178] Review Request: perl-namespace-autoclean - Keep imports out of your namespace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509178 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added Blocks||504538 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509171] Review Request: perl-String-RewritePrefix - Rewrite strings based on a set of known prefixes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509171 Chris Weyl cw...@alumni.drew.edu changed: What|Removed |Added Blocks||504538 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #5 from Jason Tibbitts ti...@math.uh.edu 2009-07-01 15:04:52 EDT --- (In reply to comment #2) If I make the package noarch, do I need to take steps to block it from being compiled by gcj? I'm not sure I understand the question. If you don't call the compiler in your %build section, it doesn't get called. However, if you want to look into it, the guidelines are at http://fedoraproject.org/wiki/Packaging/GCJGuidelines. They say that you should (but aren't required to) call aot-compile-rpm. In that case your package does need to be arch-specific. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508836] Review Request: colossus - computer implementation of Titan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508836 --- Comment #6 from Bruno Wolff III br...@wolff.to 2009-07-01 15:21:52 EDT --- What I am not sure of is if someone does a build with the gcj stuff installed, but not openjdk stuff, can they get arch dependent output? If that can't happen without doing something specific to make it happen, then I definitely should build noarch. I'll plan on switching to noarch and doing some more reading. I'll also do some more reading about javadoc. I thought this was pretty much required, but it really doesn't make much sense for stand alone programs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492203] Review Request: frinika - Music Workstation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492203 --- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-07-01 15:56:55 EDT --- (In reply to comment #8) (In reply to comment #7) The patch is not needed for the SevenZip that is in the frinika tarball. It is specific for the SevenZip we have in Fedora. If bundled SevenZip is not used anymore, you really need this patch? The patch is applied to frinika source that make the call to SevenZip library. It doesn't directly patch SevenZip. The SevenZip is bundled in frinika's source and frinika doesn't need the patch if it uses this bundled source. However we are not using the SevenZip that comes with frinika. Instead, we are using Fedora's SevenZip. In order to use Fedora's SevenZip we need to patch frinika sources. This is what the patch is for. As I can understand it, it is about adding paths into CLASSPATH manually, not create symlinks. I'm not very similar with java (as you already known), sorry if it is not correct. There are two ways of handling this: With build-classpath or with build-jar-repository The build system of frinika (the build.xml stuff) looks into the directory lib/ and adds the jar files in this directory to classpath. So I use build-jar-repository for this purpose. I could also use build-classpath, but this will require a bigger modification of the build system of frinika. We don't really need that. The difference is explained in http://fedoraproject.org/wiki/Packaging:Java#build-classpath Meanwhile, on current stage some additional notes: 1) lib directory in tarball contains many binary jars and even library .so. It is needed? I'm still do not do any investigation, but you are assured tha don't used in build? What all built from sources? May be safely remove such binaries in our svn-fetch script? In the fetch script, I only remove the parts that are known to be nonfree. The rest of .so, .jar, .exe binaries is removed in %prep to make sure that we are not using them. 2) Just for note: In fetch script in latest option first fetch last revision number to provide in -r option of svn. It is excessive. There may be HEAD. Or just this key ommited (how you was used it in svn co previous). Like: if [ 'latest' == $1 ]; then REV=-rHEAD # OR just REV= else REV=-r$1 fi svn export $REV But I can't get the revision number to append to the filename this way. i.e. $ sh frinka-snapshot.sh latest --- frinika-550.tar.bz2 Is there another way? 3) I see comment about all other sources. But what about fetch instruction to Source0 (about what script with what parameter must be used)? I believe that I have been quite verbose in terms of comments. Also the fetch script gives an output for usage. I don't think we need more. There is no room for confusion. 4) You remove DKnode, nice. But petersalomonsen component stil here. Upstream responded that all these sources petersalomonsen src/uk/ac/bath/* are all written by them and they are going to be maintained in frinika. We don't need to package them separately. 5) Just intresting: # Remove some unneded sources rm -fr src/uk/ac/bath/gui/vamp/KnobWidget.java rm -fr src/uk/ac/bath/gui/vamp/VAmp2Editor.java for what them? Is there any legal issues? It is break build? It broke the build. However: After my email, they removed DKnode src/uk/ac/bath/gui/vamp/ from their sources since they are not using them. So I packaged svn revision 550 with these sources removed. Ref: https://sourceforge.net/forum/forum.php?thread_id=3319021forum_id=447356 SPEC: http://oget.fedorapeople.org/review/frinika.spec SRPM: http://oget.fedorapeople.org/review/frinika-0.5.1-5.550svn.fc11.src.rpm changelog 0.5.1-5.550svn - Update to svn revision 550 I think that everything you mentioned is addressed now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 492203] Review Request: frinika - Music Workstation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492203 --- Comment #10 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-07-01 16:07:20 EDT --- I need to add that all the dependencies (including SevenZip and toot stuff) are in the stable branches now :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503252] Review Request: freepv - Immersive panorama viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503252 --- Comment #6 from Bruno Postle br...@postle.net 2009-07-01 16:19:35 EDT --- Just updating the status of this project: VLC is getting QTVR playback via freepv as part GSoC 2009, which was my incentive for submitting freepv. However it looks possible that in order to use the internal VLC QuickTime parser the code will be ported rather than link to libfreepv. It's only mid-term so this isn't certain. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #9 from Jochen Schmitt joc...@herr-schmitt.de 2009-07-01 16:28:33 EDT --- I have create https://fedorahosted.org/fesco/ticket/175 on the response of the FESCo member. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499486] Review Request: python-repoze-what-pylons - A plugin providing utilities for Pylons applications using repoze.what
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499486 --- Comment #8 from Tom spot Callaway tcall...@redhat.com 2009-07-01 16:41:04 EDT --- I doublechecked the URL issue, and it is definitely the correct upstream URL (it is the closest thing to a homepage that this project has). New SRPM: http://www.auroralinux.org/people/spot/review/new/python-repoze-what-pylons-1.0-3.fc12.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/python-repoze-what-pylons.spec The rpmlint errors are fixed, and there is a clear Requires: python-decorator = 3.0. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
