[Bug 514548] Review Request: rubygem-flexmock - Mock object library for ruby

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514548


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-03 
02:05:50 EDT ---
Thank you!

New Package CVS Request 
===
Package Name:   rubygem-flexmock
Short Description:  Mock object library for ruby
Owners: mtasaka
Branches:   F-11 F-10
InitialCC:  (nobody)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457279] Review Request: cerebro - Cerebro provides mesh network services and presence information

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457279


Rakesh Pandit rpan...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #29 from Rakesh Pandit rpan...@redhat.com  2009-08-03 02:18:39 
EDT ---
Sorry for delay,

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513797] Review Request: gnome-applet-cpufire - GNOME panel applet showing the CPU load as a fire

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513797


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #13 from Jason Tibbitts ti...@math.uh.edu  2009-08-03 02:30:02 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #10 from Jason Tibbitts ti...@math.uh.edu  2009-08-03 02:31:17 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 505259] Review Request: python-utmp - Python modules for utmp records

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505259


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514548] Review Request: rubygem-flexmock - Mock object library for ruby

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514548


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-08-03 02:31:52 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515090] Review Request: moblin-menus - Moblin config and data file for desktop menus

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515090





--- Comment #2 from Peter Robinson pbrobin...@gmail.com  2009-08-03 02:38:39 
EDT ---
(In reply to comment #1)
 Why are you running /sbin/ldconfig in %post and %postun?
 
 This package conflicts with redhat-menus. You should prefix the files with
 moblin- to avoid this.
 
 Forgive me this question, buf is this package really needed? Why not stick 
 with
 redhat-menus and have a consistent menu layout through all desktops?  

I'll review the differences and re-assess.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #11 from Rahul Sundaram sunda...@redhat.com  2009-08-03 02:50:24 
EDT ---
Peter Robinson,

Please fix the issues noted by Christopher Wickert and then import

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 457279] Review Request: cerebro - Cerebro provides mesh network services and presence information

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457279





--- Comment #30 from Rakesh Pandit rpan...@redhat.com  2009-08-03 02:48:31 
EDT ---
Just missed one point ... do clean the SPEC file before importing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #12 from Peter Robinson pbrobin...@gmail.com  2009-08-03 03:55:21 
EDT ---

 Please fix the issues noted by Christopher Wickert and then import  

I will when I actually get the time to read what's written :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 477683] Review Request: fltk2 - C++ user interface toolkit

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477683





--- Comment #20 from Michal Nowak mno...@redhat.com  2009-08-03 04:23:57 EDT 
---
Updated to r6834:

http://mnowak.fedorapeople.org/fltk2/fltk2-2.0.x-0.14.r6834.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514548] Review Request: rubygem-flexmock - Mock object library for ruby

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514548


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-03 
04:26:34 EDT ---
Rebuild done, push request submitted on bodhi, closing.

Thank you for the review and CVS procedure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515147] Review Request: gstreamer-rtsp-server - A rtsp streaming server using gstreamer

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515147


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||WONTFIX




--- Comment #2 from Peter Robinson pbrobin...@gmail.com  2009-08-03 05:15:07 
EDT ---
Excellent! I did a quick search but obv not quite good enough :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515147] Review Request: gstreamer-rtsp-server - A rtsp streaming server using gstreamer

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515147


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 CC||lemen...@gmail.com




--- Comment #1 from Peter Lemenkov lemen...@gmail.com  2009-08-03 05:13:24 
EDT ---
Already included

https://admin.fedoraproject.org/pkgdb/packages/name/gstreamer-rtsp

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515143] Review Request: mtkbabel - Program to Operate the i-Blue 747 GPS Data Logger

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515143


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515144] Review Request: vifir - A viewer for electronic aviation charts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515144


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lemen...@gmail.com
 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Peter Lemenkov lemen...@gmail.com  2009-08-03 05:17:16 
EDT ---
I'll review it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 452427] Review Request: awesome - Extremely fast, small, dynamic and awesome floating and tiling window manager

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452427





--- Comment #61 from Michal Nowak mno...@redhat.com  2009-08-03 05:32:04 EDT 
---
Ben:

Correct awesome-2 does not need XCB aware cairo. 

2.3 was released 14 months ago, but having small fixes till now, and is called
deprecated in favor of v3.

Problem with your approach is that awesome v2 is really old, upstream support
might end anytime, and thus is far from Fedora's close-to-upstream. Note that
cairo-xcb is far from being soon-supported upstream (still experimental), that
means we would have awesome-2 for months, if not even years. That's waste of
time, from my POV.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515144] Review Request: vifir - A viewer for electronic aviation charts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515144


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #2 from Peter Lemenkov lemen...@gmail.com  2009-08-03 05:40:52 
EDT ---
REVIEW:

+ rpmlint is silent
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[pe...@sulaco SOURCES]$ sha256sum vifir-0.4.tar.gz*
340db9360c8f3710192fd8b773736e11c992cd3dad855ba848887a15f7d06607 
vifir-0.4.tar.gz
340db9360c8f3710192fd8b773736e11c992cd3dad855ba848887a15f7d06607 
vifir-0.4.tar.gz.1
[pe...@sulaco SOURCES]$ 

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See link above.
+ All build dependencies are listed in BuildRequires.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code or permissible content.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ The packages includes a %{name}.desktop file, and that file is properly
installed with desktop-file-install in the %install section.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages must be valid UTF-8

Don't forget to add it to the list of GIS-related applications on the dedicated
wiki-page.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 503490] Review Request: ayttm - Universal Instant Messaging Client

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503490





--- Comment #9 from Parag AN(पराग) panem...@gmail.com  2009-08-03 05:45:12 
EDT ---
Thanks for the update.

1)I think we should rename file ayttm_streamer_wrapper.sh to
ayttm_streamer_wrapper
This can be done in %install as

mv $RPM_BUILD_ROOT%{_bindir}/ayttm_streamer_wrapper.sh
$RPM_BUILD_ROOT%{_bindir}/ayttm_streamer_wrapper

2)To use webcam we need 
Requires: xawtv
as /usr/bin/webcam path used in above script is provided by xawtv package

3) You can remove
BuildRequires: libtool-ltdl

4) should follow only one type of macros
either use everywhere $RPM_BUILD_ROOT or %{buildroot}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515144] Review Request: vifir - A viewer for electronic aviation charts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515144


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-08-03 
05:52:42 EDT ---
New Package CVS Request
===
Package Name: vifir
Short Description: A viewer for electronic aviation charts
units
Owners: fab
Branches: F-10 F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515144] Review Request: vifir - A viewer for electronic aviation charts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515144





--- Comment #3 from Fabian Affolter fab...@bernewireless.net  2009-08-03 
05:50:56 EDT ---
Thanks Peter for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225694] Merge Review: dictd

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225694


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||lemen...@gmail.com
 Resolution||NEXTRELEASE




--- Comment #6 from Peter Lemenkov lemen...@gmail.com  2009-08-03 05:51:28 
EDT ---
I think that we may close this ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514150] Review Request: ibus-qt - The qt support tools for ibus

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514150


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jussi.leht...@iki.fi
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




--- Comment #9 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 06:24:27 
EDT ---
(In reply to comment #8)
 Spec URL: http://dvisvgm.sourceforge.net/fedora/dvisvgm.spec
 SRPM URL: http://dvisvgm.sourceforge.net/fedora/dvisvgm-0.8.1-1.fc11.src.rpm
 
 Thanks for all your comments and support. 
 
 I've updated the spec file and added the GPL v2 LICENSE file to the tarball.
 However, I'm not quite sure about the license constraints because the sources
 contain some unmodified, third-party files that are licensed under GPL v2+.
 Even if I'd like to publish my own code under GPL v3, do the bundled files
 affect the license of the complete package, e.g. force it to be GPL v2+ too
 (which wouldn't be a problem for me)? For now, I stay with GPL v2+.

You can license your own files as GPLv3+. Then the binary will be formed out of
GPLv2+ and GPLv3+ parts, so the License: tag would be either GPLv2+ and
GPLv3+ or just GPLv3+ since that's the license of the binary that's
produced.

 I didn't change the headers of the third-party files, so some of them still
 don't mention their GPL version.  

If they don't mention a version, they're GPL+.

**

Drop
 gzip -9 ${RPM_BUILD_ROOT}%{_mandir}/*/*
as RPM will do this for you automatically.

**


I am willing to sponsor you if you show me your knowing of the Fedora 
guidelines, most importantly
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

This you can do by making at least one other submission and performing a couple
of informal reviews of packages of other people. Please review only packages
*not* marked with FE-NEEDSPONSOR, as I will have to do the full formal review
after you to check that you have got everything correctly. Once I have
sponsored you you will be able to do formal reviews of your own.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #13 from Peter Robinson pbrobin...@gmail.com  2009-08-03 06:35:04 
EDT ---
I've updated the spec file using 'cp -p' as per the above guidelines it looks
like from my reading and testing install is only usable for individual files
rather than directory structure like in an icon theme.

I've also removed the Makefile.am files that are copied as well.

A side point I'm not sure how this script from the packaging guidelines works

%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor /dev/null
gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
fi

As post uninstall the theme.index wouldn't exist. I think it needs a -t option.

Thanks for the pointers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #14 from Peter Robinson pbrobin...@gmail.com  2009-08-03 06:36:58 
EDT ---

 As post uninstall the theme.index wouldn't exist. I think it needs a -t 
 option.

I meant index.theme

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 491497] Review Request: dmapd - A server that provides DAAP and DPAP shares

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491497





--- Comment #5 from Fabian Affolter fab...@bernewireless.net  2009-08-03 
06:38:37 EDT ---
BTW, your spec file is hard to read because it doesn't follow the 'standard' 
conventions.  Of course, is your way not wrong, just unusual.  Most packager
follows more or less the template that can be created with 'rpmdev-newspec
blablabla' (looks a bit like this
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Creating_a_blank_spec_file)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462176] Review Request: hybserv - Hybrid IRC Services

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462176


Marek Mahut mma...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||WONTFIX
   Flag|needinfo?(mma...@redhat.com |
   |)   |




--- Comment #3 from Marek Mahut mma...@redhat.com  2009-08-03 06:43:22 EDT ---
Sorry, I don't wish to maintain this package anymore.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #10 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 06:45:17 
EDT ---
Also, you are using the potrace library which needs to be packaged separately.
http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802


Nils Philippsen nphil...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|nphil...@redhat.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514699] Review Request: jemmy - Java UI testing library

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514699


Guido Grazioli guido.grazi...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|guido.grazi...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507377] Review Request: jana - An interface library for time-related PIM

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507377


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #6 from Parag AN(पराग) panem...@gmail.com  2009-08-03 06:52:56 
EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=1575074
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514699] Review Request: jemmy - Java UI testing library

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514699





--- Comment #7 from Guido Grazioli guido.grazi...@gmail.com  2009-08-03 
06:51:04 EDT ---
ok then, i'm working on the package review right now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507377] Review Request: jana - An interface library for time-related PIM

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507377


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Peter Robinson pbrobin...@gmail.com  2009-08-03 06:57:20 
EDT ---
Thanks :-)

New Package CVS Request
===
Package Name: jana
Short Description: An interface library for time-related PIM
Owners: pbrobinson
Branches: F-11 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on||515206




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] New: Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: potrace - Transform bitmaps into vector graphics

https://bugzilla.redhat.com/show_bug.cgi?id=515206

   Summary: Review Request: potrace - Transform bitmaps into
vector graphics
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jussi.leht...@iki.fi
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/potrace.spec

SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/potrace-1.8-1.fc11.src.rpm

Upstream URL:
http://potrace.sourceforge.net

Description:
Potrace(TM) is a utility for tracing a bitmap, which means, transforming a
bitmap into a smooth, scalable image. The input is a bitmap (PBM, PGM, PPM, or
BMP format), and the default output is an encapsulated PostScript file (EPS).
A typical use is to create EPS files from scanned data, such as company or
university logos, handwritten notes, etc. The resulting image is not jaggy
like a bitmap, but smooth. It can then be rendered at any resolution.

Potrace can currently produce the following output formats: EPS, PostScript,
PDF, SVG (scalable vector graphics), Xfig, Gimppath, and PGM (for easy
antialiasing). Additional backends might be added in the future.

Mkbitmap is a program distributed with Potrace which can be used to pre-process
the input for better tracing behavior on greyscale and color images. See the
mkbitmap examples page.


rpmlint output is clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

  Alias||dvisvgm




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 502699] Review Request: crosstool-ng - A toolchain building utility

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502699


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 CC||fab...@bernewireless.net




--- Comment #1 from Fabian Affolter fab...@bernewireless.net  2009-08-03 
07:01:25 EDT ---
Version 1.4.1 was released a while ago.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||cbal...@redhat.com
 Blocks||515049




--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 07:02:52 
EDT ---
*** Bug 251710 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 251710] Review Request: potrace - Transforming bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=251710


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||jussi.leht...@iki.fi
 Resolution||DUPLICATE




--- Comment #5 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 07:02:52 
EDT ---
This bug hasn't moved in almost a year. Repackaged at bug #515206.

*** This bug has been marked as a duplicate of 515206 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515143] Review Request: mtkbabel - Program to Operate the i-Blue 747 GPS Data Logger

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515143





--- Comment #5 from Daniel Rindt dan...@rindt.name  2009-08-03 07:04:26 EDT 
---
(In reply to comment #2)
 Notes:
 
 * Url should point to its new home, at SF.
 * Ver. 0.8 is out. Please, update.
 * Field Release must not contain .fc10 postfix. Use %{?dist} macro instead.
 * No such group Hardware/Mobile. Take a look at the
 /usr/share/doc/rpm-*/GROUPS for the ull list of allowed values.
 * Use full path to the source.
 * Field License should contain GPLv2+
 
 Other things looks sane. Please update your srpm, and I'll continue. 
Please recheck it at:
http://www.rindt.name/fileadmin/rpmbuild/SRPMS/mtkbabel-0.8-1.fc10.src.rpm
http://www.rindt.name/fileadmin/rpmbuild/SPECS/mtkbabel.spec

changes executed as you mentioned. the 0.8 is the latest release peter. 

My ID is drindt yes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

  Alias||potrace




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||131850




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #11 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 07:07:12 
EDT ---
(In reply to comment #10)
 Also, you are using the potrace library which needs to be packaged separately.
 http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries
   

I have packaged potrace in bug #515206, you need to make this package use that
version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 266001] Review Request: webunit - Python web testing framework

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=266001


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 CC||fab...@bernewireless.net




--- Comment #3 from Fabian Affolter fab...@bernewireless.net  2009-08-03 
07:07:38 EDT ---
Some comment after a quick look at your spec file.

- Don't mix '$RPM_BUILD_ROOT' and '%{buildroot}'
 
http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- README is missing in %doc
- Is there any note about the license in the source?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206


Guido Grazioli guido.grazi...@gmail.com changed:

   What|Removed |Added

 CC||guido.grazi...@gmail.com




--- Comment #2 from Guido Grazioli guido.grazi...@gmail.com  2009-08-03 
07:21:50 EDT ---
Hello Jussi, you specfile seems to be in a very good shape; you only need to 
adjust main package comment:

Packagers should be careful how they use trademarks in Summary or Description.
There are a few rules to follow:

* Never use (TM) or (R) (or the unicode equivalents, ™/®). It is
incredibly complicated to use these properly, so it is actually safer for us to
not use them at all. 

Maybe the last line about examples page could go away too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515143] Review Request: mtkbabel - Program to Operate the i-Blue 747 GPS Data Logger

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515143





--- Comment #6 from Peter Lemenkov lemen...@gmail.com  2009-08-03 07:35:46 
EDT ---
I just found some more issues - seems, that these are the last remaining
issues:

* You don't need to explicitly add Requires: perl-Some-Extension since
rpmbuild can find them automatically (it scans sources for use Some::Thing 
directives and for shebangs, and adds them as Requires: perl(Some::Thing). So,
I advise you to remove all explicit Requires directives.

* No need to add perl as BuildRequires.

* Please, don't mark man-files ad %doc, e.g. remove %doc directive before
%{_mandir}/man1/*.* in the %files section.

* Blocker issue. You must add rm -rf $RPM_BUILD_ROOT to the head of your
install section.

* I advice you to shorten %install section by exploiting the magic power of
install utility - it can create necessary directories by user's demand, while
installing. E.g. instead of

install -d $RPM_BUILD_ROOT%{_bindir}
install mtkbabel $RPM_BUILD_ROOT%{_bindir}/
install -d $RPM_BUILD_ROOT%{_mandir}/man1
install -m0644 mtkbabel.1 $RPM_BUILD_ROOT%{_mandir}/man1/

you may simply write (note -D switch added):

install -D -m 0755 mtkbabel $RPM_BUILD_ROOT%{_bindir}/mtkbabel
install -D -m 0644 mtkbabel.1 $RPM_BUILD_ROOT%{_mandir}/man1/mtkbabel.1


I'm sorry, for not to pointing you to all these issues before - seems that I
looked to your first srpm very inattentively.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476829] Review Request: foomatic-db - Database of printers and printer drivers

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476829





--- Comment #5 from Tim Waugh twa...@redhat.com  2009-08-03 07:39:01 EDT ---
(In reply to comment #3)
 - you can drop setting the CFLAGS for the make commands in %build, there is
 no C/C++ code built, if I see it right

Yep.

 - are the INSTALLSITELIB and INSTALLSITEARCH really required for the make
 commands in %install? They looks like some pythonic paths.

No, removed.

 - what is the upstream versioning scheme? Does the version in the included
 archive mean that it is a snapshot made 20081124 after the 3.0 release? Then
 you should apply post-release package guideline -
 https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages
 (version=3.0, release=1.20081124)

It's daily snapshots and very infrequent version releases.  I've switch to the
post-release scheme now.

 - according to the README in foomatic-db, there should be files licensed under
 MIT too, please recheck and update the License tag to GPLv2+ and MIT

Fixed (new sub-package carries MIT license).

 - using only rm -rf %{buildroot} is sufficient for the %clean section

Fixed.

 - is the database useful for other purpose then for cups?  

No.

I've updated the package to match the current devel foomatic package (newer
snapshot, oki4linux obsoleted, etc), and also split out a 'ppds' sub-package
for bug #461234.

Spec URL: http://twaugh.fedorapeople.org/foomatic-db/foomatic-db.spec
SRPM URL:
http://twaugh.fedorapeople.org/foomatic-db/foomatic-db-4.0-1.20090702.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206





--- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 07:40:42 
EDT ---
Right, thanks.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/potrace.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/potrace-1.8-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802


Nils Philippsen nphil...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review?  |fedora-review+




--- Comment #12 from Nils Philippsen nphil...@redhat.com  2009-08-03 07:54:38 
EDT ---
Items marked GOOD or PASS fulfil the guidelines or they don't apply to this
package.
Items marked CHECK aren't covered by the guidelines but you should check and
fix them anyway in my opinion.
Items marked BAD violate the guidelines in some point and need to be fixed.

- GOOD: rpmlint run on vacation-1.2.7.0-5.fc11.src.rpm doesn't flag
errors/warnings
- GOOD: package name according to guidelines
- GOOD: spec file named properly
- BAD: package doesn't meet packaging guidelines: the source URL is wrong, it
should be downloads.sourceforge.net/... (just verified it with spectool)
- GOOD: licensed according to licensing guidelines (be it GPLv2 or GPLv2+, see
below).
- BAD: license in spec file doesn't match license in package, as the licensing
in the source tarball isn't really clear: the README file states that it's
under the GPL (see file COPYING in the directory) which could be construed as
GPLv2 only (as that is the version shipped) but also GPLv2+ (as they didn't
specify a specific version). Please consult upstream about this, they really
should clarify if they mean GPLv2 or GPLv2+ and state it in the source files
themselves. BTW, Comment #6 isn't really correct about the original source
being incompatible with the GPL as the source files are really under BSD
without advertising clause (or MIT), i.e. there is no issue with this being
licensed incompatibly, just that we can't be quite sure what license this is
under. You can flag it as GPLv2 in the meantime, just to stay on the safe
side. If upstream tells you that it really is GPLv2+ (as I assume), then
include documentation that they did tell you that (e.g. a copy of the mail) in
the package documentation when changing it in this version in a future release
(this is not necessary if they clarify it in the shipped sources themselves in
a future version).
- GOOD: license shipped as documentation
- GOOD: the spec file is written in American English
- GOOD: the spec file is legible
- GOOD: sources used to build the package match upstream source
- GOOD: builds in mock for x86_64/Rawhide
- GOOD: all build dependencies listed
- PASS: doesn't ship locale files
- PASS: no libraries shipped
- GOOD: package is not relocatable
- GOOD: all shipped directories owned by package, direct dependency or
filesystem
- GOOD: no duplicates in %files
- GOOD: permissions on files are set properly
- GOOD: package has a %clean section
- GOOD: package uses macros consistently
- GOOD: the package contains code, not content
- PASS: no large documentation files
- GOOD: %doc doesn't affect runtime
- PASS: no header files
- PASS: no static libraries
- PASS: no pkgconfig files
- PASS: no libraries included
- PASS: no devel package
- GOOD: no *.la libtool archives
- PASS: no desktop file
- GOOD: doesn't own files or directories owned by other packages
- GOOD: build root is cleaned at the beginning of %install
- GOOD: all file names are valid UTF-8
- CHECK: from now on, please state in the changelog what you changed (e.g. -
changed license to GPLv2 until licensing is clarified with upstream
(#474802)), just referring to a BZ ticket number doesn't explain it
sufficiently.

This package is APPROVED, provided that you fix the license tag to GPLv2
(temporarily, until this is clarified with upstream) and the source URL before
importing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515143] Review Request: mtkbabel - Program to Operate the i-Blue 747 GPS Data Logger

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515143





--- Comment #7 from Daniel Rindt dri...@visetics.com  2009-08-03 08:05:41 EDT 
---
(In reply to comment #6)
 I'm sorry, for not to pointing you to all these issues before - seems that I
 looked to your first srpm very inattentively.  
It's no problem. The files are updated for your review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476435] Review Request: sugar-record - Recording tool for Sugar

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476435





--- Comment #14 from Peter Robinson pbrobin...@gmail.com  2009-08-03 08:17:56 
EDT ---
Fabian, is there a status update on this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #12 from Martin Gieseking martin.giesek...@uos.de  2009-08-03 
08:24:33 EDT ---
Spec URL: http://dvisvgm.sourceforge.net/fedora/dvisvgm.spec
SRPM URL: http://dvisvgm.sourceforge.net/fedora/dvisvgm-0.8.1-1.fc11.src.rpm

Thanks for your comments and for providing the potrace-devel package. 
I've removed the gzip line from the spec file and added a patch that changes
the Makefile to link the separately packaged potrace library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802





--- Comment #13 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 08:28:38 
EDT ---
$ licensecheck.pl  -r vacation-1.2.7.0/
vacation-1.2.7.0/tzfile.h: BSD (3 clause) 
vacation-1.2.7.0/rfc822.c: *No copyright* UNKNOWN
vacation-1.2.7.0/html2man.pl: UNKNOWN
vacation-1.2.7.0/strlcpy.c: ISC 
vacation-1.2.7.0/vacation.c: BSD (3 clause) 
vacation-1.2.7.0/vacation.h: BSD (3 clause) 
vacation-1.2.7.0/strlcat.c: ISC 

rfc822.c is under MIT license. Only the man page has any mention of a GPL
(GPLv2+) license. Please ask upstream to clarify this.

**

The current GPLv2+ license marking is correct: if the source code or COPYING
doesn't specify a version (released under GPL), then the license tag is GPL+.
The same is used if the COPYING is some version of the GPL without a
specification what license the program is under.
https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515143] Review Request: mtkbabel - Program to Operate the i-Blue 747 GPS Data Logger

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515143


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515143] Review Request: mtkbabel - Program to Operate the i-Blue 747 GPS Data Logger

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515143


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #8 from Peter Lemenkov lemen...@gmail.com  2009-08-03 08:54:11 
EDT ---
I sponsored you. Don't hesitate to contact me directly via xmpp or email (
lemen...@gmail.com ) for any question regarding rules of slightly complex
role-playing game, named Fedora package maintainership

REVIEW:

+ rpmlint is silent

[pe...@workplace Desktop]$ rpmlint mtkbabel-0.8-1.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[pe...@workplace Desktop]$ 

+ The package is named according to the  Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
+ The package meets the Packaging Guidelines. 
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[pe...@sulaco SOURCES]$ sha256sum mtkbabel-0.8.tar.gz*
591597c0787822c9fd56c7a3da214e81edd3c98f32d16858221e02dfc0f63779 
mtkbabel-0.8.tar.gz
591597c0787822c9fd56c7a3da214e81edd3c98f32d16858221e02dfc0f63779 
mtkbabel-0.8.tar.gz.1
[pe...@sulaco SOURCES]$

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1575556


+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT). 

- The package must consistently use macros. So, I advice you to change rm -rf
%{buildroot} to rm -rf $RPM_BUILD_ROOT in the %install section.

+ The package contains code, or permissible content.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages must be valid UTF-8.

Please make a last change mentioned above regarding simultaneous using of
%{buildroot} and $RPM_BUILD_ROOT (easyfix). Fix it and proceed with the
https://fedoraproject.org/wiki/CVS_admin_requests 

Please, also use 


This package is


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515230] Review Request: python-dmidecode - python extension module to access DMI data

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515230


David Sommerseth dav...@redhat.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515230] New: Review Request: python-dmidecode - python extension module to access DMI data

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-dmidecode - python extension module to access 
DMI data

https://bugzilla.redhat.com/show_bug.cgi?id=515230

   Summary: Review Request: python-dmidecode - python extension
module to access DMI data
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: dav...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


This is my first Fedora package, so I presume I'll need a sponsor for this
package

Spec URL:
http://projects.autonomy.net.au/python-dmidecode/export/392a9976b14d558d4b2f331b5a44ee97912fc5e3/contrib/python-dmidecode.spec
SRPM URL:
http://src.autonomy.net.au/python-dmidecode/python-dmidecode-3.10.6-6.fc11.src.rpm

Description: python-dmidecode is a python extension module that uses the
code-base of the 'dmidecode' utility, and presents the data
as python data structures or as XML data using libxml2.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 505356] Review Request: php-PHPMailer - PHP email transport class with a lot of features

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505356





--- Comment #10 from Patrick Monnerat p...@datasphere.ch  2009-08-03 09:00:45 
EDT ---
Many thanks for the review, Remi.

New SRPM: http://monnerat.fedorapeople.org/php-PHPMailer-5.0.2-3.fc10.src.rpm
Fixes URL, description and dependency
rpmlint silent
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1575575

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 466183] Review Request: sblim-sfcb - Small Footprint CIM Broker

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466183





--- Comment #21 from Praveen K Paladugu praveen_palad...@dell.com  2009-08-03 
09:18:01 EDT ---
Hey Emily, 

  Could you please find time to make the above suggested changes?

Praveen

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468329] Review Request: sblim-indication_helper - Toolkit for CMPI Indication Providers

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468329


Praveen K Paladugu praveen_palad...@dell.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468329] Review Request: sblim-indication_helper - Toolkit for CMPI Indication Providers

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468329





--- Comment #9 from Praveen K Paladugu praveen_palad...@dell.com  2009-08-03 
09:37:15 EDT ---
New Package CVS Request
===
Package Name:sblim-indication_helper
Short Description: libraries for writing CMPI providers 
Owners: praveenp,srini
Branches:F-9 F-10 F-11 EL-4 EL-5
InitialCC: mdomsch,srini

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802





--- Comment #14 from Nils Philippsen nphil...@redhat.com  2009-08-03 09:33:57 
EDT ---
(In reply to comment #13)
 $ licensecheck.pl  -r vacation-1.2.7.0/
 vacation-1.2.7.0/tzfile.h: BSD (3 clause) 
 vacation-1.2.7.0/rfc822.c: *No copyright* UNKNOWN
 vacation-1.2.7.0/html2man.pl: UNKNOWN
 vacation-1.2.7.0/strlcpy.c: ISC 
 vacation-1.2.7.0/vacation.c: BSD (3 clause) 
 vacation-1.2.7.0/vacation.h: BSD (3 clause) 
 vacation-1.2.7.0/strlcat.c: ISC 

Neato. Where do I find this?

 rfc822.c is under MIT license. Only the man page has any mention of a GPL
 (GPLv2+) license. Please ask upstream to clarify this.
 
 **
 
 The current GPLv2+ license marking is correct: if the source code or COPYING
 doesn't specify a version (released under GPL), then the license tag is 
 GPL+.
 The same is used if the COPYING is some version of the GPL without a
 specification what license the program is under.
 https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
   

Only that the README doesn't say under the GPL, but under the GPL (see file
COPYING in the directory) which could be interpreted as under the GPL as
found in the file COPYING (which would be specifying a version as this is
exactly version 2 and nothing else). IANAL and all that stuff, but IMO better
be safe than sorry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 479763] Review Request: seam - The Simple Extensible Abstract Machine

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479763





--- Comment #2 from Fabian Affolter fab...@bernewireless.net  2009-08-03 
09:39:08 EDT ---
I will take a new look.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468329] Review Request: sblim-indication_helper - Toolkit for CMPI Indication Providers

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468329





--- Comment #10 from Praveen K Paladugu praveen_palad...@dell.com  2009-08-03 
09:40:58 EDT ---
New Package CVS Request
===
Package Name:sblim-indication_helper
Short Description: libraries for writing CMPI providers 
Owners: praveenp
Branches:F-10 F-11 EL-4 EL-5
InitialCC: mdomsch srini

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802





--- Comment #15 from Till Bubeck t.bub...@reinform.de  2009-08-03 09:42:35 
EDT ---
Again, thanks for the comments.

changelog:
- changed license to GPLv2 until licensing is clarified with upstream
- changed source URL from download... to downloads

I've uploaded again an updated SPEC/SRPMs to:
Spec URL: http://www.reinform.de/download/rpm/vacation/vacation.spec
SRPM URL:
http://www.reinform.de/download/rpm/vacation/vacation-1.2.7.0-6.fc11.src.rpm

Please review, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507805] Review Request: perl-Flickr-Upload - Flickr upload tool

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507805


Michal Ingeli m...@v3.sk changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Michal Ingeli m...@v3.sk  2009-08-03 09:43:48 EDT ---
New Package CVS Request
===
Package Name: perl-Flickr-Upload
Short Description: Flickr upload tool
Owners: ksyz
Branches: F-11 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802





--- Comment #16 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 09:52:15 
EDT ---
(In reply to comment #14)
 (In reply to comment #13)
  $ licensecheck.pl  -r vacation-1.2.7.0/
  vacation-1.2.7.0/tzfile.h: BSD (3 clause) 
  vacation-1.2.7.0/rfc822.c: *No copyright* UNKNOWN
  vacation-1.2.7.0/html2man.pl: UNKNOWN
  vacation-1.2.7.0/strlcpy.c: ISC 
  vacation-1.2.7.0/vacation.c: BSD (3 clause) 
  vacation-1.2.7.0/vacation.h: BSD (3 clause) 
  vacation-1.2.7.0/strlcat.c: ISC 
 
 Neato. Where do I find this?

It's a Debian utility, e.g.
http://packages.debian.org/source/sid/devscripts

It's going to be in the next rpmdevtools release:
https://bugzilla.redhat.com/show_bug.cgi?id=466353

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478372] Review request: Mathgl - Scientific plotting library.

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478372


Bug 478372 depends on bug 513744, which changed state.

Bug 513744 Summary: Swig update required
https://bugzilla.redhat.com/show_bug.cgi?id=513744

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||CURRENTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515247] New: Review Request: tint2 - a lightweight X11 desktop panel and task manager

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: tint2 - a lightweight X11 desktop panel and task 
manager

https://bugzilla.redhat.com/show_bug.cgi?id=515247

   Summary: Review Request: tint2 - a lightweight X11 desktop
panel and task manager
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ch...@chessgriffin.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://chessgriffin.com/files/pkgs/fedora/tint2/tint2.spec
SRPM URL:
http://chessgriffin.com/files/pkgs/fedora/tint2/tint2-0.7.1-1.fc11.src.rpm
Description: tint2 is a simple X11 desktop panel and taskbar intentionally made
for Openbox3, but that should work with other window managers.  tint2 is
intended to be unintrusive and light in resource utilization, while following
freedestkop specifications.

Home page:  http://code.google.com/p/tint2

This is my second submission.  Rpmlint -vi is clean on spec, SRPM, and RPM. 
Builds cleanly in mock.  Built cleanly on koji scratch build for f11
(https://koji.fedoraproject.org/koji/taskinfo?taskID=1575660) and f12
(https://koji.fedoraproject.org/koji/taskinfo?taskID=1576012).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515247] Review Request: tint2 - a lightweight X11 desktop panel and task manager

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515247


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jussi.leht...@iki.fi
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515247] Review Request: tint2 - a lightweight X11 desktop panel and task manager

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515247





--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-03 10:32:26 
EDT ---
I suggest that you drop
 --docdir=%{_docdir}/%{name}-%{version}
and just run
 rm -rf %{buildroot}%{_docdir}
explicitly at the end of install, since rpm anyway removes the documentation
directory.

**

rpmlint output is clean.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A

MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
- You may want to change
 %{_mandir}/man1/tint2.1.gz
to
 %{_mandir}/man1/tint2.1.*
in case the man page compression format changes in the future.

MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Add COPYING to %doc.

MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

**

You still need to do the informal reviews. Please review only bugs not marked
with FE-NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515032] Review Request: nss-util - Utilities for Network Security Services (NSS)

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515032


Elio Maldonado Batiz emald...@redhat.com changed:

   What|Removed |Added

  Status Whiteboard|NotReady|Ready




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515034] Review Request: nss-softokn - Cryptographic Module of NSS

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515034


Elio Maldonado Batiz emald...@redhat.com changed:

   What|Removed |Added

  Status Whiteboard||Ready




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515032] Review Request: nss-util - Utilities for Network Security Services (NSS)

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515032





--- Comment #6 from Elio Maldonado Batiz emald...@redhat.com  2009-08-03 
10:36:04 EDT ---
Since this is for Fedora 12 a more adequate source rpm would be
http://fedorapeople.org/~emaldonado/nss-util/devel/nss-util-3.12.3.99.3-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515032] Review Request: nss-util - Utilities for Network Security Services (NSS)

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515032


Elio Maldonado Batiz emald...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474802] Review Request: vacation - Automatic mail answering program

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802





--- Comment #17 from Nils Philippsen nphil...@redhat.com  2009-08-03 10:45:24 
EDT ---
(In reply to comment #15)
 Again, thanks for the comments.
 
 changelog:
 - changed license to GPLv2 until licensing is clarified with upstream
 - changed source URL from download... to downloads
 
 I've uploaded again an updated SPEC/SRPMs to:
 Spec URL: http://www.reinform.de/download/rpm/vacation/vacation.spec

That is actually the -5 release ;-)...

 SRPM URL:
 http://www.reinform.de/download/rpm/vacation/vacation-1.2.7.0-6.fc11.src.rpm

the spec file in the SRPM contains the changes.

 Please review, thanks!  

You wouldn't have had to put these up for review again, it would have been okay
if you just requested CVS for your package and fixed these items in there.

Anyway (and again): APPROVED. Now go, make your CVS request ;-).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515034] Review Request: nss-softokn - Cryptographic Module of NSS

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515034





--- Comment #3 from Elio Maldonado Batiz emald...@redhat.com  2009-08-03 
10:45:32 EDT ---
Given that it is for f12 this one would be more appropriate 
http://fedorapeople.org/~emaldonado/nss-util/devel/nss-softokn-3.12.3.99.3-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #16 from Christoph Wickert fed...@christoph-wickert.de  
2009-08-03 10:51:41 EDT ---
Created an attachment (id=356041)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=356041)
updated spec to incorporate all changes from comment # 15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #15 from Christoph Wickert fed...@christoph-wickert.de  
2009-08-03 10:50:38 EDT ---
(In reply to comment #13)
 I've updated the spec file using 'cp -p' as per the above guidelines it looks
 like from my reading and testing install is only usable for individual files
 rather than directory structure like in an icon theme.

This is correct. Just stick with cp, create-icon-theme.sh takes care of the
permissions. Sorry for the noise.

 As post uninstall the theme.index wouldn't exist. I think it needs a -t 
 option.

No, if index.theme doesn't exist, gtk-update-icon-cache is not run - this is
what we want. It will complain about the missing dir, but this is why we have 
/dev/null || : at the end. (Well, at least we *should* have this at the end,
you only have || : because your scriptlets are outdated. See 
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
for the most recent version.)

BTW: icon-theme.cache is not part of this package, so it wont get removed when
the package uninstalled. You need to
touch %{buildroot}/%{_datadir}/icons/moblin/icon-theme.cache
during install and include it ghosted in the files section.

Another thing I realized while looking at the source: You are not creating any
symlinks for the icons, so many apps will have no stock icons. Add the
following to your spec at the end of %install, when the Makefile.am files are
already removed:

# create symlinks for gtk stock icons, these are not really 'legacy'
# this uses the legacy-icon-mapping.xml file
cd $RPM_BUILD_ROOT/usr/share/icons/moblin
for size in 16x16 24x24 48x48; do
  (
  cd $size
  for context in *; do
if [ -d $context ]; then
  (
  cd $context
  INU_DATA_DIR=%{_builddir}/%{name}-%{version} /usr/bin/icon-name-mapping
-c $context
  )
fi
  done
  )
done

Voila, now the icon theme contains more than 3 times more files.

Last but not least create-icon-theme.sh should be running during %build. Not
that it makes a difference, I'm just pedantic. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #17 from Christoph Wickert fed...@christoph-wickert.de  
2009-08-03 10:54:29 EDT ---
Well, all changes except preserving the timestamps. Sorry.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 462458] Review Request: drupal-workspace - Allows users to have a central place to view and manage their content

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462458





--- Comment #2 from Jon Ciesla l...@jcomserv.net  2009-08-03 11:07:17 EDT ---
No, there isn't, I flubbed that. :)

Here's the new version:

SRPM:
http://zanoni.jcomserv.net/fedora/drupal-workspace/drupal-workspace-6.x.1.4-0.rc1.fc11.src.rpm
SPEC: http://zanoni.jcomserv.net/fedora/drupal-workspace/drupal-workspace.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 355981] Review Request: poker3d-data - Data files for the poker3d package

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=355981


Miroslav Grepl mgr...@redhat.com changed:

   What|Removed |Added

 CC||faithinfamil...@yahoo.com




--- Comment #14 from Miroslav Grepl mgr...@redhat.com  2009-08-03 11:11:33 
EDT ---
*** Bug 515188 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #18 from Peter Robinson pbrobin...@gmail.com  2009-08-03 11:21:04 
EDT ---
Excellent, I'll have a look a this shortly. Thanks :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515280] New: Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme

https://bugzilla.redhat.com/show_bug.cgi?id=515280

   Summary: Review Request: gnome-colors-icon-theme - GNOME-Colors
icon theme
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mno...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://mnowak.fedorapeople.org/gnome-colors-icon-theme/gnome-colors-icon-theme.spec
SRPM URL:
http://mnowak.fedorapeople.org/gnome-colors-icon-theme/gnome-colors-icon-theme-5.2.2-1.fc11.src.rpm
Description: 

The GNOME-Colors is a project that aims to make the GNOME desktop as
elegant, consistent and colorful as possible.

The current goal is to allow full color customization of themes, icons,
GDM logins and splash screens. There are already seven full color-schemes
available; Brave (Blue), Human (Orange), Wine (Red), Noble (Purple), Wise
(Green), Dust (Chocolate) and Illustrious (Pink). An unlimited amount of
color variations can be rebuilt and recolored from source, so users need
not stick to the officially supported color palettes.

GNOME-Colors is mostly inspired/based on Tango, GNOME, Elementary,
Tango-Generator and many other open-source projects. More information
can be found in the AUTHORS file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 511966] Review Request: zbar - bar code reader

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511966


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #28 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-03 
11:24:44 EDT ---
Now closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515280] Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515280





--- Comment #1 from Michal Nowak mno...@redhat.com  2009-08-03 11:23:34 EDT 
---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1576200

new...@dhcp-lab-124 SPECS $ rpmlint
/home/newman/rpmbuild/SRPMS/gnome-colors-icon-theme-5.2.2-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 505928] Review Request: hdapsd - Protects hard drives by parking head when fall is detected

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505928


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag||needinfo?(zdzi...@irc.pl)




--- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-03 
11:07:22 EDT ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515280] Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515280


Michal Nowak mno...@redhat.com changed:

   What|Removed |Added

  Alias||gnome-colors




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541





--- Comment #27 from Ashay ashay.hum...@gmail.com  2009-08-03 11:32:48 EDT ---
Ok, I added that:

http://ashay.info/rpm/cpulimit.spec
http://ashay.info/rpm/cpulimit-1.1-8.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 505354] Review Request: php-captchaphp - PHP very user-friendly CAPTCHA solution

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505354





--- Comment #5 from Patrick Monnerat p...@datasphere.ch  2009-08-03 11:37:28 
EDT ---
New SRPM: http://monnerat.fedorapeople.org/php-captchaphp-2.0-4.fc10.src.rpm
PHP requirements minimized.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1576229
Rpmlint silent.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514549] Review Request: lyx-fonts - Math Symbol fonts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514549


Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG




--- Comment #8 from Rex Dieter rdie...@math.unl.edu  2009-08-03 11:34:25 EDT 
---
Meh, looks like upstream intentions are to continue bundling the fonts, which
makes me think that simply doing all this inside of the existing lyx pkg is
preferable.

Closing-NOTABUG

(Unless anyone feels strongly otherwise, speak up!)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206


Guido Grazioli guido.grazi...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|guido.grazi...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469470] Review Request: mausezahn - A fast versatile packet generator

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469470





--- Comment #35 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-03 
11:46:43 EDT ---
Well, 

(In reply to comment #34)
 Spec URL: http://bonii.fedorapeople.org/spec/mausezahn.spec
 SRPM URL: http://bonii.fedorapeople.org/srpms/mausezahn-0.34.8-1.fc9.src.rpm  

This does not build (at least) on x86_64:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1576215

From diff:
--
diff -uNr mausezahn-0.34.6-2.fc9.src/mz-0.34.6/CMakeLists.txt
mausezahn-0.34.8-1.fc9.src/mz-0.34.8/CMakeLists.txt
--- mausezahn-0.34.6-2.fc9.src/mz-0.34.6/CMakeLists.txt 2008-09-05
17:16:54.0 +0900
+++ mausezahn-0.34.8-1.fc9.src/mz-0.34.8/CMakeLists.txt 2009-07-30
01:33:28.0 +0900
@@ -5,6 +5,8 @@
cmake_policy(SET CMP0003 NEW)
 endif(COMMAND cmake_policy)

+SET(CMAKE_C_FLAGS -Wall -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -
fasynchronous-unwind-tables)
+
 ADD_CUSTOM_TARGET(uninstall
COMMAND ${CMAKE_COMMAND} -E echo Use 'xargs rm  install_manifest.txt'
to uninstall this program
)
@@ -13,3 +15,6 @@

 add_subdirectory (src)
 add_subdirectory (doc)
+
+
+
-

Well, this CMAKE_C_FLAGS is wrong on x86_64, and on rawhide even
on i686 (on rawhide build target is for i686, x86_64, ppc, ppc64).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514549] Review Request: lyx-fonts - Math Symbol fonts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514549





--- Comment #9 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-08-03 
12:07:58 EDT ---
then the changes will be done in lyx pkg? (just asking, I'm multitasking badly
while packing for summer vacations)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 514549] Review Request: lyx-fonts - Math Symbol fonts

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514549





--- Comment #10 from Rex Dieter rdie...@math.unl.edu  2009-08-03 12:12:24 EDT 
---
Yes, that's my tentative plan at the moment.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507675] Review Request: poppler-data - Encoding files

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507675





--- Comment #9 from Rex Dieter rdie...@math.unl.edu  2009-08-03 12:14:34 EDT 
---
fair nuff, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206





--- Comment #5 from Guido Grazioli guido.grazi...@gmail.com  2009-08-03 
12:29:29 EDT ---
Yep, zlib-devel seems to be enough

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206





--- Comment #4 from Guido Grazioli guido.grazi...@gmail.com  2009-08-03 
12:28:58 EDT ---
Hello Jussi, build in koji fails:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1576283

You need at least to include zlib-devel in BRs

guido

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 505356] Review Request: php-PHPMailer - PHP email transport class with a lot of features

2009-08-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505356


Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #11 from Remi Collet fed...@famillecollet.com  2009-08-03 
12:29:09 EDT ---
+ Home page change : ok
+ Package description from new home page. : OK
+ Requires php-mbstring : OK


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   3   >