[Bug 525358] Review Request: python-assets - Cache-friendly asset management via content-hash-naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525358 Jason Gerard DeRose jder...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525361] Review Request: python-wehjit - A Python web-widget library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525361 Jason Gerard DeRose jder...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520246] Review Request: python-sysv_ipc - System V IPC for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520246 --- Comment #2 from steve st...@lonetwin.net 2009-09-24 02:38:14 EDT --- Thanks, Jason. New Package CVS Request === Package Name: python-sysv_ipc Short Description: System V IPC for Python Owners: lonetwin Branches: F-10 F-11 InitialCC: - steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520246] Review Request: python-sysv_ipc - System V IPC for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520246 steve st...@lonetwin.net changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516906] Review Request: frePPLe - Free Production Planning Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516906 Johan De Taeye jdeta...@users.sourceforge.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #18 from Johan De Taeye jdeta...@users.sourceforge.net 2009-09-24 02:59:47 EDT --- New Package CVS Request === Package Name: frepple Short Description: Free Production Planning Library Owners: jdetaeye Branches: F-10 F-11 F-12 InitialCC: salimma -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520343] Review Request: clc - command line client for MUDs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520343 Jan Klepek jan.kle...@hp.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Jan Klepek jan.kle...@hp.com 2009-09-24 03:05:57 EDT --- approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525151 --- Comment #3 from Mario Basic ma...@information-hq.org 2009-09-24 03:04:54 EDT --- This is the correct URL for both SPEC nad SRPM. SPEC URL: http://www.information-hq.org/data/projects/CLconverter/Spec/CLconverter-0.4.7.spec SRPM URL: http://www.information-hq.org/data/projects/CLconverter/RPMs/CLconverter-0.4.7-3.fc11.i586.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525358] Review Request: python-assets - Cache-friendly asset management via content-hash-naming
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525358
kashyap chamarthy kcham...@redhat.com changed:
What|Removed |Added
CC||kcham...@redhat.com
--- Comment #1 from kashyap chamarthy kcham...@redhat.com 2009-09-24
03:23:09 EDT ---
Hi, here is my /informal/ review,
**NOK** - rpmlint output
-
[bu...@f12-alpha SPECS]$ rpmlint python-assets.spec
python-assets.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line
6)
-
Please fix the above.(use consistently either tabs or spaces)
OK - %{?dist} tag is used in release
OK - The package must be named according to the Package Naming Guidelines.
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
OK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines (license is GPLv2)
NA - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun
OK - The package MUST successfully compile and build
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1702920
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL.
sha256sum: eef40e4714f019d76bf9ab44c0fe27e3e6ec5980918012caf81b2e3693c78d09
assets-0.1.0.tar.gz
NA - The spec file MUST handle locales properly (no translations)
NA - The package is not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissible content
OK - Large documentation files must go in a -doc subpackage -- No large
documentation
OK - If a package includes something as %doc, it must not affect the runtime of
the application
NA - Header files must be in a -devel package -- no devel package
NA - Static libraries must be in a -static package -- no static package
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications MUST include a .desktop file
OK - No file conflicts with other packages and no general names.
OK- At the beginning of %install, each package MUST run rm -rf %{buildroot}
**NOTE**: I think you can avoid the rm -rf %{buildroot} in %install section,
if you're building _only_ for F11 and above.(IIRC,this guideline is not /yet/
updated in the packaging guidelines )
OK - All file names in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.
Please correct me, if I'm wrong somewhere.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525151 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #4 from Ralf Corsepius rc040...@freenet.de 2009-09-24 03:25:41 EDT --- (In reply to comment #3) SRPM URL: http://www.information-hq.org/data/projects/CLconverter/RPMs/CLconverter-0.4.7-3.fc11.i586.rpm You posted an URL to a binary RPM. Something, which is pretty much pointless in a package review. You are supposed to post an SRPM URL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #22 from Fedora Update System upda...@fedoraproject.org 2009-09-24 03:37:20 EDT --- firehol-1.273-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/firehol-1.273-5.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #21 from Fedora Update System upda...@fedoraproject.org 2009-09-24 03:36:42 EDT --- firehol-1.273-5.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/firehol-1.273-5.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523104] Review Request: ghc-cgi - Haskell library for writing cgi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523104 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #5 from Jens Petersen peter...@redhat.com 2009-09-24 03:37:59 EDT --- Package imported and building http://koji.fedoraproject.org/koji/taskinfo?taskID=1703007 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523883] Review Request: haskell-platform - Standard Haskell distribution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523883 Bug 523883 depends on bug 523104, which changed state. Bug 523104 Summary: Review Request: ghc-cgi - Haskell library for writing cgi https://bugzilla.redhat.com/show_bug.cgi?id=523104 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2009-09-24 03:37:54 EDT --- firehol-1.273-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/firehol-1.273-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 465636] Review Request: FireHOL - a Linux iptables packet filtering firewall builder for humans
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465636 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2009-09-24 03:38:28 EDT --- firehol-1.273-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/firehol-1.273-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515046] Review Request: perl-XML-Parser-Lite-Tree-XPath - XPath access to XML::Parser::Lite::Tree structures
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515046 Michal Ingeli m...@v3.sk changed: What|Removed |Added CC||m...@v3.sk --- Comment #9 from Michal Ingeli m...@v3.sk 2009-09-24 03:48:08 EDT --- 0.12 is the newest version of perl-XML-Parser-Lite-Tree and was pushed for testing just now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525151 --- Comment #5 from Mario Basic ma...@information-hq.org 2009-09-24 03:49:05 EDT --- SRPM URL: http://www.information-hq.org/data/projects/CLconverter/Srpm/CLconverter-0.4.7-3.fc11.src.rpm Thanks, I've got it mixed up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523886] Review Request: ghc-time - Haskell time library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523886 --- Comment #2 from Jens Petersen peter...@redhat.com 2009-09-24 03:46:06 EDT --- Spec: http://petersen.fedorapeople.org/ghc-time/ghc-time.spec SRPM: http://petersen.fedorapeople.org/ghc-time/ghc-time-1.1.2.4-2.fc11.src.rpm Fixed the doc conflict with ghc-doc like for ghc-network with versioned ghcdocdir. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520343] Review Request: clc - command line client for MUDs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520343 Sean Middleditch s...@middleditch.us changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Sean Middleditch s...@middleditch.us 2009-09-24 03:54:13 EDT --- New Package CVS Request === Package Name: clc Short Description: Very simplistic MUD client for command line usage Owners: elanthis Branches: F12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added Flag|needinfo?(pa...@hubbitus.in | |fo) | --- Comment #17 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-09-24 03:55:45 EDT --- You are shure? I try check it: # repoquery --whatprovides /bin/xls2csv but nothing found... In what branches you found this conflict? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] New: Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip https://bugzilla.redhat.com/show_bug.cgi?id=525389 Summary: Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: atork...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://atorkhov.fedorapeople.org/madwimax.spec SRPM URL: http://atorkhov.fedorapeople.org/madwimax-0.1.1-1.local12.src.rpm Description: madWiMAX is a reverse-engineered Linux driver for mobile WiMAX (802.16e) devices based on Samsung CMC-730 chip. These devices are currently supported: * Samsung SWC-U200 * Samsung SWC-E100 * Samsung SWM-S10R (built in Samsung NC-10 netbook) Note that is not kernel module, but rather user-space daemon. Koji builds: F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1700668 F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1700717 Rpmlint output: madwimax.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/z60_madwimax.rules - this is a script 3 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 --- Comment #18 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-09-24 04:09:16 EDT --- Not '/bin/xls2csv' but actually '/usr/bin/xls2csv'. catdoc (in Fedora) includes this file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521909
Stefan Schulze Frielinghaus ste...@seekline.net changed:
What|Removed |Added
CC||ste...@seekline.net
--- Comment #2 from Stefan Schulze Frielinghaus ste...@seekline.net
2009-09-24 04:14:07 EDT ---
A few comments about the spec file:
- Tabs aren't aligned properly
- I'm not sure about this comment:
# It still required for EPEL5
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRoot is required on Fedora too or do I miss something?
- What about this comment (line 15)?
#Requires:
- You should write a patch instead of using sed here:
# Hack to correct install on 64-bit systems.
sed -i ...
sed will return 0/no error if it substitutes something or even does nothing but
patch will fail if it cannot be applied. With a patch you are on the save side.
- The example package only contains 7 CPP files. Maybe you want to pack them
into the main package as docs too? What do you think?
- I guess it is a typo in the Changelog
Fix installation on 54-bit systems.
should be
Fix installation on 64-bit systems.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521719] Review Request: pycryptopp - Python wrappers for the Crypto++ library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521719 --- Comment #5 from Ruben Kerkhof ru...@rubenkerkhof.com 2009-09-24 04:20:35 EDT --- Sure, new version here: Spec URL: http://ruben.fedorapeople.org/pycryptopp.spec SRPM URL: http://ruben.fedorapeople.org/pycryptopp-0.5.17-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 --- Comment #19 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-09-24 04:34:20 EDT --- Oh, yes /usr/bin/xls2csv there... So, what you think how I should name it? xlsTOcsv convertxls2csv convertXls2csv convertXls2Csv something other? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517191] Review Request: php-symfony-symfony - Open-Source PHP Web Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517191 --- Comment #12 from Christof Damian chris...@damian.net 2009-09-24 04:33:13 EDT --- Same mistake as in https://bugzilla.redhat.com/show_bug.cgi?id=517643#c7 (wrong pear provide) is fixed now: Spec URL: http://rpms.damian.net/SPECS/php-symfony-symfony.spec SRPM URL: http://rpms.damian.net/SRPMS/php-symfony-symfony-1.2.8-4.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 515898] Review Request: imapfilter - A flexible client side mail filtering utility for IMAP servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515898 --- Comment #9 from David Sommerseth dav...@redhat.com 2009-09-24 04:34:22 EDT --- Thanks again for a very quick feedback! I've added the $RPM_OPT_FLAGS as requested. In addition I also removed the renaming of the configure script. I hope I haven't missed anything else ... Spec URL: http://people.redhat.com/dsommers/imapfilter/imapfilter.spec SRPM URL: http://people.redhat.com/dsommers/imapfilter/imapfilter-2.0.11-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517643
--- Comment #8 from Christof Damian chris...@damian.net 2009-09-24 04:33:55
EDT ---
(In reply to comment #7)
Provides: php-pear(doctrine/%{pear_name}) = %{version}
Shouldn't that be:
Provides: php-pear(pear.doctrine-project.com/%{pear_name}) = %{version}
That is fixed now:
Spec URL: http://rpms.damian.net/SPECS/php-doctrine-Doctrine.spec
SRPM URL:
http://rpms.damian.net/SRPMS/php-doctrine-Doctrine-1.1.3-4.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523326] Review Request: gnome-applet-window-picker - Window picker applet for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523326 --- Comment #17 from Christoph Wickert cwick...@fedoraproject.org 2009-09-24 04:49:40 EDT --- (In reply to comment #15) (In reply to comment #14) Michel, AFAICS you did not fix any of the issues I pointed out in comment #7: - rpmlint is not clean Not sure what you mean; it is clean here: Please see comment # 7 or run rpmlint on the srpm: $ rpmlint Downloads/gnome-applet-window-picker-0.5.6-2.fc10.src.rpm gnome-applet-window-picker.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. (In reply to comment #16) Not sure that is the correct reading. The guideline uses that versioned dependency as an example, and it actually recommended removing the version requirement, once the oldest supported Fedora release exceeds that requirement. I read this different: Since non of the downsides apply to this package, a versioned dep should be used here. However... In this case, since there is a SONAME dependency that will pull in the correct version of gnome-panel-libs, the correct version of gnome-panel would be pulled in as well (because of the same SONAME dependency between gnome-panel and libpanel-applet) ... I fully agree with you in this special case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522732 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2009-09-24 04:52:02 EDT --- perl-Text-Diff-Parser-0.1001-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Text-Diff-Parser-0.1001-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522732 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-09-24 04:52:08 EDT --- perl-Text-Diff-Parser-0.1001-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Text-Diff-Parser-0.1001-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525210] Review Request: rubygem-trollop - A command-line option parsing library for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525210 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-09-24 05:01:11 EDT --- Well, the version is 1.14, 1.14.2. For 1.14-0: * License - Well README says the license is the same as Ruby, lib/trollop.rb says it is under GPLv2. So the license tag should be GPLv2 * Redundant macro - Is the definition of %ruby_sitelib needed? * %check - As this gem contains test/ directory, please add %check stage and execute a test program. * Directory ownership issue - The directory %geminstdir itself is not owned by any packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525210] Review Request: rubygem-trollop - A command-line option parsing library for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525210 --- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-09-24 05:15:42 EDT --- Also please see my comments on bug 525211 comment 2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525211] Review Request: rubygem-ditz - A command-line issue tracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525211 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-09-24 05:13:08 EDT --- Well, as I said in bug 525210, rubygem-trollop is under GPLv2. However this (rubygem-ditz) is under GPLv3+, which is incompatible with GPLv2, so for now this package cannot be distributed. Note that even if rubygem-trollop is under GPLv2 or Ruby, it is still incompatible with GPLv3+. https://fedoraproject.org/wiki/Licensing Blocking FE-Legal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 Jan Klepek jan.kle...@hp.com changed: What|Removed |Added Flag||needinfo?(pa...@hubbitus.in ||fo) --- Comment #20 from Jan Klepek jan.kle...@hp.com 2009-09-24 05:16:16 EDT --- convertxls2csv sounds fine. please take in mind that you need to rename man pages too -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458866 --- Comment #21 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-09-24 05:21:18 EDT --- I don't know this package well so for renaming I will leave it to you (convertxls2csv seems fine also for me) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516464] Review Request: adtool - Active Directory administration utility for Unix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516464 Rahul Sundaram sunda...@redhat.com changed: What|Removed |Added CC||sunda...@redhat.com --- Comment #12 from Rahul Sundaram sunda...@redhat.com 2009-09-24 05:41:16 EDT --- Akshay, you need to apply for cvs next http://fedoraproject.org/wiki/CVS_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516717] Review Request: viewnior - Elegant Image Viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516717 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2009-09-24 05:48:11 EDT --- viewnior-0.7-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/viewnior-0.7-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516717] Review Request: viewnior - Elegant Image Viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516717 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2009-09-24 05:48:54 EDT --- viewnior-0.7-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/viewnior-0.7-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525151
--- Comment #6 from Ralf Corsepius rc040...@freenet.de 2009-09-24 06:06:28
EDT ---
(In reply to comment #5)
SRPM URL:
Thanks.
As you seem to be new to Fedora packaging, let's start with some basic remarks
on your package:
1) Fedora *.spec's are supposed to be named package.spec.
You are using package-version.spec
Please change this.
2) Your *.spec contains hard-coded /usr/bin.
Please use %{_bindir} instead.
3) The compilation being applied by your spec doesn't apply the CFLAGS, all
packages in Fedora are supposed to use.
One way to achieve this with your package is to explicitly set CFLAGS:
make CFLAGS=${RPM_OPT_FLAGS}
4) You are stripping the application in %install. Fedora applications need to
be built and installed unstripped.
Please remove the -s from install.
5) The source files inside of your tarball carry bogus permissions (they are
executable). As you seem to be upstream of the tarball, I'd recommend
upstream to fix this in the upstream tarball.
If this should not be applicable, the permissions should be fixed in %build.
Hint: Are you familiar with rpmlint? If not, please make yourself familiar
with it - Though this tool is far from being perfect and occasionally produces
bogus warning, it helps avoiding the worst packaging mistakes.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525412] New: Review Request: mediaproxy - NAT traversal solution for compatible SIP-routers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mediaproxy - NAT traversal solution for compatible SIP-routers https://bugzilla.redhat.com/show_bug.cgi?id=525412 Summary: Review Request: mediaproxy - NAT traversal solution for compatible SIP-routers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lemen...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://peter.fedorapeople.org/mediaproxy.spec SRPM URL: http://peter.fedorapeople.org/mediaproxy-2.3.5-1.fc11.src.rpm Description: MediaProxy is a distributed far end NAT traversal solution for media streams of SIP calls. MediaProxy has a dispatcher running on the same host with the SIP-proxy and multiple media relays distributed over the network. The media relays work by manipulating conntrack rules in the Linux kernel to create paths that forward the media streams between the 2 SIP user agents participating in the call. Because it avoids to copy stream data from kernel space to user space and back to kernel space like other implementations, MediaProxy can handle much more media streams at a time, limited only to the network interface bandwidth and the Linux kernel network layer processing speed. MediaProxy features secure encrypted communication between the dispatcher and the relays, advanced accounting capabilities using multiple backends, support for any combination of audio and video streams, realtime statistics, T.38 fax support as well as automatic load balancing and redundancy among the active relays. Koji scratchbuild for F-11 http://koji.fedoraproject.org/koji/taskinfo?taskID=1703283 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2009-09-24 06:22:02 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 524545] Review Request: snacc - Sample Neufeld ASN.1 to C Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524545 --- Comment #3 from Alex Musolino musoli...@gmail.com 2009-09-24 06:35:28 EDT --- Shakthi, Two more suggestions from me... - The snacc-libs package should not require the snacc package. - I've realised that it should be 'Sample' - Sample and Neufeld are the names of the creators. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516717] Review Request: viewnior - Elegant Image Viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516717 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #20 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-09-24 07:08:03 EDT --- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517366] Review Request: emacs-haskell-mode - Haskell editing mode for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517366 --- Comment #17 from Arun SAG saga...@gmail.com 2009-09-24 07:11:36 EDT --- (In reply to comment #15) Hi, any more unofficial reviews you done? I reviewed https://bugzilla.redhat.com/show_bug.cgi?id=501101 ; -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521909
--- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2009-09-24 07:15:47 EDT ---
(In reply to comment #2)
A few comments about the spec file:
- Tabs aren't aligned properly
Tabs aligned properly. Just you use another tab with (see first post).
- I'm not sure about this comment:
# It still required for EPEL5
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRoot is required on Fedora too or do I miss something?
Yes BuildRoot is obsoleted for Fedora.
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- What about this comment (line 15)?
#Requires:
This is atavism. Deleted.
- You should write a patch instead of using sed here:
# Hack to correct install on 64-bit systems.
sed -i ...
sed will return 0/no error if it substitutes something or even does nothing
but
patch will fail if it cannot be applied. With a patch you are on the save
side.
Yes, there sed behavior is preferred.
1) We must be conditionally apply patch only on 64-bit systems.
2) sed always replace in this string, even if lib to lib. So, it is normal.
- The example package only contains 7 CPP files. Maybe you want to pack them
into the main package as docs too? What do you think?
For what? Especially when work to split it was done.
- I guess it is a typo in the Changelog
Fix installation on 54-bit systems.
should be
Fix installation on 64-bit systems.
Off course. Thank you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525432] New: Review Request: openxcap - Fully featured XCAP server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: openxcap - Fully featured XCAP server https://bugzilla.redhat.com/show_bug.cgi?id=525432 Summary: Review Request: openxcap - Fully featured XCAP server Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lemen...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://peter.fedorapeople.org/openxcap.spec SRPM URL: http://peter.fedorapeople.org/openxcap-1.1.2-1.fc11.src.rpm Description: Fully featured XCAP server. An XCAP server is used by SIP SIMPLE clients and servers to manage buddy lists and policy for subscriptions to presence or other type of events published using SIP protocol. XCAP protocol allows a client to read, write and modify application configuration data stored in XML format on a server. XCAP maps XML document sub-trees and element attributes to HTTP URIs, so that these components can be directly accessed by HTTP. An XCAP server is used by the XCAP clients to store data like Presence policy in combination with a SIP Presence server that supports PUBLISH/SUBSCRIBE/NOTIFY methods to provide a complete SIP SIMPLE server solution. Koji scratchbuild for F-11 http://koji.fedoraproject.org/koji/taskinfo?taskID=1703461 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521909
--- Comment #4 from Stefan Schulze Frielinghaus ste...@seekline.net
2009-09-24 07:51:11 EDT ---
(In reply to comment #3)
Tabs aligned properly. Just you use another tab with (see first post).
I red your first comment and just wanted to encourage you to use normal tabs
or 8 whitespaces. I guess this not a big problem but why do you want to go a
different why than most of the other packages? In a very strict sense this may
fell under
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_note-5
- I'm not sure about this comment:
# It still required for EPEL5
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
BuildRoot is required on Fedora too or do I miss something?
Yes BuildRoot is obsoleted for Fedora.
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
Oh. Haven't noticed that before. Thanks.
- You should write a patch instead of using sed here:
# Hack to correct install on 64-bit systems.
sed -i ...
sed will return 0/no error if it substitutes something or even does nothing
but
patch will fail if it cannot be applied. With a patch you are on the save
side.
Yes, there sed behavior is preferred.
1) We must be conditionally apply patch only on 64-bit systems.
2) sed always replace in this string, even if lib to lib. So, it is
normal.
Then why not write a patch and wrap it with a conditional for 64bit like you
already mentioned? This would solve it. I'm not that familiar with this package
but what does upstream say about this? Maybe they have the same problem?
- The example package only contains 7 CPP files. Maybe you want to pack them
into the main package as docs too? What do you think?
For what? Especially when work to split it was done.
Since it is a library the example files may help developers to build against
it. But again this is not a problem and I guess up to the packagers freedom.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489424] Review Request: editarea - EditArea is a free javascript editor for source code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489424 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2009-09-24 07:57:53 EDT --- editarea-0.8.1.1-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/editarea-0.8.1.1-5.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489424] Review Request: editarea - EditArea is a free javascript editor for source code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489424 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2009-09-24 07:57:47 EDT --- editarea-0.8.1.1-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/editarea-0.8.1.1-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489424] Review Request: editarea - EditArea is a free javascript editor for source code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489424 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-09-24 07:57:41 EDT --- editarea-0.8.1.1-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/editarea-0.8.1.1-5.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521851] Review Request: perl-Nagios-Plugin-Beanstalk - Nagios plugin to observe Beanstalkd queue server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521851
Jose Pedro Oliveira j...@di.uminho.pt changed:
What|Removed |Added
CC||j...@di.uminho.pt
--- Comment #5 from Jose Pedro Oliveira j...@di.uminho.pt 2009-09-24
08:01:14 EDT ---
Re-opening this ticket as I've a couple of doubts about the this package.
Being this a nagios plugin
1) why isn't is called nagios-plugin-beanstalk
(maybe splitting the perl module to a subpackage)
and
2) installs its script in %{_libdir}/nagios/plugins
(requiring the nagios-plugins package)
/jpo
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 519512] Review Request: cmusphinx3 - Large vocabulary speech recognition in C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519512
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
Flag||fedora-review?
--- Comment #8 from Martin Gieseking martin.giesek...@uos.de 2009-09-24
08:10:09 EDT ---
Here's my full review. I couldn't find any further issues that need to be
fixed. Just a minor suggestion:
Personally, I prefer adding the BRs to the subpackage they actually belong to
because then it's easier to reproduce the dependencies. So I would move
- BR: doxygen = -doc subpackage
- BR: python-devel = -python subpackage
- BR: pkgconfig= -devel subpackage
$ rpmlint /var/lib/mock/fedora-11-i386/result/cmusphinx3-*
cmusphinx3-devel.i586: W: no-documentation
cmusphinx3-libs.i586: W: shared-lib-calls-exit /usr/lib/libs3decoder.so.0.0.6
e...@glibc_2.0
cmusphinx3-libs.i586: W: no-documentation
cmusphinx3-python.i586: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 4 warnings.
All warnings are expected and can be ignored.
-
keys used in following checklist:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
- The name sphinx is already in use for a full-text search engine
- there are several release series (Sphinx-2, -3, -4, PocketSphinx)
- upstream URL is www.cmusphinx.org = cmusphinx3 is a proper name
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- BSD two clause variant (according to COPYING and source headers)
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: File(s) containing the text of the license(s) for the package must be
included in %doc.
- COPYING listed in %doc
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ sha1sum sphinx3-0.8.zip*
343af9767342129e1d673423e9bf1a523eff2254 sphinx3-0.8.zip
343af9767342129e1d673423e9bf1a523eff2254 sphinx3-0.8.zip.1
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1703288
[.] MUST: If the package does not successfully compile, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
- no locales
[+] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
- shared libs are placed in subpackage -libs
- ldconfig is called in %post and %postun for subpackage -libs
[.] MUST: If the package is designed to be relocatable,...
- not relocatable
[+] MUST: A package must own all directories that it creates.
[+] MUST: Files must not be listed more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
- building of static libraries disabled
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
symlink libs3decoder.so put in -devel
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
- .la files are removed
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
- no GUI
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the
[Bug 476247] Review Request: log4cpp - logging library for c++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476247 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2009-09-24 08:23:59 EDT --- log4cpp-1.0-4.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/log4cpp-1.0-4.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476247] Review Request: log4cpp - logging library for c++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476247 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-09-24 08:25:36 EDT --- log4cpp-1.0-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/log4cpp-1.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525151
--- Comment #7 from Mario Basic ma...@information-hq.org 2009-09-24 08:27:08
EDT ---
Thanks a lot for this, really helped. I used it as a checklist.
1.done
2.done
3.I think I've done this because I had to write CFLAGS=${RPM_OPT_FLAGS} to
work. When I wrote make CFLAGS=${RPM_OPT_FLAGS} It would report an error.
4.done
5.done
I used rpmlint to check the spec file and package, and now it reports 0 error
and warnings. I used rpmlint CLconverter CLconverter.spec to check it.
SPEC URL:
http://www.information-hq.org/data/projects/CLconverter/Spec/CLconverter.spec
SRPM URL:
http://www.information-hq.org/data/projects/CLconverter/Srpm/CLconverter-0.4.7-8.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521909 --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 2009-09-24 08:27:09 EDT --- (In reply to comment #4) (In reply to comment #3) Tabs aligned properly. Just you use another tab with (see first post). I red your first comment and just wanted to encourage you to use normal tabs or 8 whitespaces. I guess this not a big problem but why do you want to go a different why than most of the other packages? In a very strict sense this may fell under https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_note-5 No most of the other!!! I tired say about it. There was discussion on this theme - http://thread.gmane.org/gmane.linux.redhat.fedora.extras.packaging/6214/focus=6224 And accordingly it proposed draft guidelines change - https://fedoraproject.org/wiki/PackagingDrafts/Tabs So, until it is not part Guidelines it can not be required. Then why not write a patch and wrap it with a conditional for 64bit like you already mentioned? This would solve it. Sed also solve problem. So, I have opposite question - why I should write additionally patch? And what of benefit of it over sed solution?? I'm not that familiar with this package but what does upstream say about this? Maybe they have the same problem? No, they have-not. According to mail, he mention about /lib as symlink to /lib64. I don't known what system they use. Since it is a library the example files may help developers to build against it. But again this is not a problem and I guess up to the packagers freedom. Thanks. I think external package give more flexibility to user in any case. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466183] Review Request: sblim-sfcb - Small Footprint CIM Broker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466183 --- Comment #30 from IBM Bug Proxy bugpr...@us.ibm.com 2009-09-24 08:39:38 EDT --- Kevin, Yes, it is ok with me with many thanks to Srini and Praveen for stepping up. Thanks! Emily -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525146] Review Request: PDCurses - Public Domain curses library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525146 --- Comment #6 from Jon Ciesla l...@jcomserv.net 2009-09-24 08:39:18 EDT --- So it would seem that PDCurses has major, major issues. Not sure how I missed the conflicts with ncurses-devel. Odd. Anyway, IMHO we have no need for another curses implementation in Fedora, ncurses works wonderfully. The only reason I've submitted this is that asciiportal needs it. Given the above, I see three courses of action. 1. Fix the above. Yow. 2. Create an asciiportal package that bundles PDCurses. Since asciiportal builds against PDCurses statically (ick!) and I've not succeeded in getting it to build dynamically yet, this may work. While bundling libs is to be avoided at all costs, I wonder about doing it when there's no intention of putting the lib in Fedora. Food for thought. 3. Port asciiportal to ncurses. Paradoxically, this might be the least work, if it's possbile. Haven't looked into it in any depth, however. Any thoughts on these options? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459874] Review Request: zeromq - Fast messaging system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459874 --- Comment #28 from Peter Lemenkov lemen...@gmail.com 2009-09-24 09:13:33 EDT --- Ver. 1.0.1 http://peter.fedorapeople.org/zeromq.spec http://peter.fedorapeople.org/zeromq-1.0.1-1.fc11.src.rpm The upstream introduced Tcl, Lua and Ruby bindings. Unfortunately, the make install target for these bindings is broken. I'll plan to fix these issues (as well as issue with unused-direct-shlib-dependency) in the nearest future (this weekend or next week, if time permits). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525346] Review Request: papi - Performance Application Programming Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525346 --- Comment #3 from William Cohen wco...@redhat.com 2009-09-24 09:12:46 EDT --- perf_counter.h is not expected to change. However, there could be multiple perf_counter.h files. The PERF_HEAD was written so that it would just pick one for the symbolic link. The kernel-headers would be more appropriate. However, kernel-headers doesn't currently include perf_counter.h. Need to get that added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521909 --- Comment #6 from Stefan Schulze Frielinghaus ste...@seekline.net 2009-09-24 09:14:43 EDT --- (In reply to comment #5) (In reply to comment #4) (In reply to comment #3) Tabs aligned properly. Just you use another tab with (see first post). I red your first comment and just wanted to encourage you to use normal tabs or 8 whitespaces. I guess this not a big problem but why do you want to go a different why than most of the other packages? In a very strict sense this may fell under https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_note-5 No most of the other!!! I tired say about it. There was discussion on this theme - http://thread.gmane.org/gmane.linux.redhat.fedora.extras.packaging/6214/focus=6224 And accordingly it proposed draft guidelines change - https://fedoraproject.org/wiki/PackagingDrafts/Tabs So, until it is not part Guidelines it can not be required. You pointed to the right discussion and if you read the last few posts you will see my point of view. Then why not write a patch and wrap it with a conditional for 64bit like you already mentioned? This would solve it. Sed also solve problem. So, I have opposite question - why I should write additionally patch? And what of benefit of it over sed solution?? Like I already said e.g. if a new release is made available extra attention should always go to the sed line because sed my return without an error even when it didn't change a single bit. A patch would automate this. It would fail and raise an error. What about the next ten upstream releases? If they change the line e.g. from install(TARGETS net7ssh LIBRARY DESTINATION lib) to install(TARGETS net7ssh LIBRARY DESTINATION LIB) your sed section wouldn't fail and build fine e.g. on PPC. But then you should really make sure that you tested your package on every supported architecture. I'm not sure if it's worth that. If you submit your package to koji and automatically build for all supported architectures then koji would raise an error for 64bit. I would say it is more clean. But that's up to you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521909] Review Request: ne7ssh - SSH Library is a Secure Shell client software written in C++
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521909
--- Comment #7 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2009-09-24 09:27:10 EDT ---
(In reply to comment #6)
You pointed to the right discussion
I known :)
and if you read the last few posts you will see my point of view.
You also known my point. I think its all now. I do not see any problem change
tab width if you want in any editor what you like.
I think you favorite editor can do it. If not, I wrote
little script for that on PHP:
http://hubbitus.net.ru/rpm/Fedora11/x11vnc/tab-convert.phps
Yo may use it like:
$ cat ne7ssh.spec | ./tab-convert.php x11vnc.spec.spaces
Or, with power of UNIX-WAY, off course directly in shell f.e:
$ cat ne7ssh.spec | php -r 'define(TAB_WIDTH, 5);foreach(file(php://stdin)
as $l){preg_match_all(/\t+/, $l, $m, PREG_OFFSET_CAPTURE);foreach($m[0] as
$mm){$l = str_replace($mm[0],str_repeat( , (TAB_WIDTH - ($mm[1] % TAB_WIDTH))
+ ( TAB_WIDTH * ( strlen($mm[0]) - 1 ) )), $l);}echo $l;}'
ne7ssh.spec.spaces
Like I already said e.g. if a new release is made available extra attention
should always go to the sed line because sed my return without an error even
[snip]
I'm not sure if it's worth that. If you submit your package to koji and
automatically build for all supported architectures then koji would raise an
error for 64bit. I would say it is more clean. But that's up to you.
Yes, there no problem in any case, because koji build fails in case if
something changed there.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525453] New: Review Request: yum-rhn-plugin - RHN support for yum
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: yum-rhn-plugin - RHN support for yum Alias: yum-rhn-plugin https://bugzilla.redhat.com/show_bug.cgi?id=525453 Summary: Review Request: yum-rhn-plugin - RHN support for yum Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: msu...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Blocks: 452450 Estimated Hours: 0.0 Classification: Fedora Target Release: --- SPEC: http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin.spec SRPM: http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin-0.7.2-1.src.rpm Description: This yum plugin provides support for yum to access a Red Hat Network server for software updates. rpmlint is silent Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1703680 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521851] Review Request: perl-Nagios-Plugin-Beanstalk - Nagios plugin to observe Beanstalkd queue server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521851 --- Comment #6 from Ruben Kerkhof ru...@rubenkerkhof.com 2009-09-24 09:30:58 EDT --- I thought about calling it nagios-plugin-beanstalk, but it still is a perl Module, all files are perl scripts. Creating a subpackage seemed unnecessary bloat to me, especially since the main package wouldn't work without the subpackage. As for point 2, that makes sense, I'll adjust the location. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525146] Review Request: PDCurses - Public Domain curses library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525146 --- Comment #7 from Ralf Corsepius rc040...@freenet.de 2009-09-24 10:05:20 EDT --- (In reply to comment #6) Any thoughts on these options? Which parts of PDCurses does asciiportal actually need? Theoretically, all curses implementations should be (more or less) compatible, so porting asciiportal to ncurses would be another option, i.e. I would definitely prefer your option 3). Wrt. 1): Fixing the Makefile.in irons out many of the issues mentioned above, however there are parts, I don't see any way to fix, in particular the SDL bindings (IMO, they are a flawed, immature design. Upstream PDcurses was right in not integrating them into their nominal configuration) 2) is a non-go/no-way, non-option to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521851] Review Request: perl-Nagios-Plugin-Beanstalk - Nagios plugin to observe Beanstalkd queue server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521851
--- Comment #7 from Jose Pedro Oliveira j...@di.uminho.pt 2009-09-24
10:24:35 EDT ---
(In reply to comment #6)
I thought about calling it nagios-plugin-beanstalk, but it still is a perl
Module, all files are perl scripts. Creating a subpackage seemed unnecessary
bloat to me, especially since the main package wouldn't work without the
subpackage.
So are several of the core nagios-plugins and they were all splited in
subpackages using names in the nagios-plugins namespace. This makes a lot
easier to locate nagios-plugins (core and third-party) doing something like
yum search nagios-plug
Besides, this package main purpose is to provide a nagios plugin.
As for point 2, that makes sense, I'll adjust the location.
You can try this:
%{__perl} Makefile.PL INSTALLDIRS=vendor
INSTALLSCRIPT=%{_libdir}/nagios/plugins
although this can cause problems with possible man pages.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 524105] Review Request: fence-virt - Modular virtual machine fencing daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524105 --- Comment #12 from Lon Hohberger l...@redhat.com 2009-09-24 11:45:19 EDT --- New Package CVS Request === Package Name: fence-virt Short Description: Pluggable Virtual Machine Fencing Owners: lon Branches: F-12 InitialCC: fabbione -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508126] Review Request: education-bookmarks - Education SIG spin bookmarks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508126 --- Comment #17 from Chitlesh GOORAH chitl...@gmail.com 2009-09-24 11:22:49 EDT --- Anyone want to step in for alternatives http://dailypackage.fedorabook.com/index.php?/archives/6-Wednesday-Why-The-Alternatives-System.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521851] Review Request: perl-Nagios-Plugin-Beanstalk - Nagios plugin to observe Beanstalkd queue server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521851
--- Comment #8 from Jose Pedro Oliveira j...@di.uminho.pt 2009-09-24
11:14:05 EDT ---
IIRC packages can no longer be noarch when they install files under %{_libdir}
(/usr/lib | /usr/lib64). You may need to add this to the specfile:
# No binaries in this package
%define debug_package %{nil}
/jpo
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 524545] Review Request: snacc - Sample Neufeld ASN.1 to C Compiler
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524545
--- Comment #4 from Chitlesh GOORAH chitl...@gmail.com 2009-09-24 11:42:46
EDT ---
#001: move the contents of the -lib subpackage to the main package.
The -lib subpackage is meant for multilibs hence support multiarchitectures.
IF you want to keep the -lib subpackage you will need to
1. add a require N-libs-V-R to the base package
2. move the binaries to the -libs package
3. make the base package a noarch
I prefer to eliminate the -lib subpackage entirely.
#002: Documentation:
*.tex and *.bib are pretty useless and inefficient for the user. I propose to
build a PDF out of it in the %prep section and ship only the PDF and not the
sources.
For best practices, all documentations of the same package should be provided
by the same package. This helps the user find the documentation quickly and
efficiently.
#003: Directory ownership in base package
%dir %{_includedir}/%{name}/
#004: .m4
should this go to -devel ?
%{_datadir}/aclocal/snacc.m4
#005: Patches naming should start with a %{name} prefix, if not they will
overwrite other patches with the same name.
FYI: automake17 is provided by Fedora to maintain compatibility with own
software. The last real update of automake17 on Fedora is back in 2007. It is
recommended for upstream to tune their sources with respect to the newer
versions.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525151
--- Comment #8 from Ralf Corsepius rc040...@freenet.de 2009-09-24 10:47:52
EDT ---
(In reply to comment #7)
3.I think I've done this because I had to write CFLAGS=${RPM_OPT_FLAGS} to
work. When I wrote make CFLAGS=${RPM_OPT_FLAGS} It would report an error.
make CFLAGS=${RPM_OPT_FLAGS} CLconverter
would have been it.
5.done
You seem to have rebuilt the tarball without incrementing the version.
A reasonable upstream increments the version each time it releases a new
tarball, because people are checking tarballs for changes and will yell at you
when a tarball is being replaced without incrementing the version.
BTW1: Did you consider to add a Makefile to your package? It would help
packagers of various distros and OSes, and assist them to avoid having to
figure out how your package is supposed to be built.
BTW2: Do you have another package on review? Based on this package review
alone, I am not yet sufficiently convinced about your packaging expertise to
sponsor you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478749 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525358] Review Request: python-assets - Cache-friendly asset management via content-hash-naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525358 --- Comment #2 from Jason Gerard DeRose jder...@redhat.com 2009-09-24 10:56:44 EDT --- Oops, not sure how that got in there. Fixed and uploaded to fedorapeople. Also fixed in python-wehjit.spec. Thanks for catching this! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517643 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|tcall...@redhat.com Flag||fedora-review+ --- Comment #9 from Tom spot Callaway tcall...@redhat.com 2009-09-24 11:09:27 EDT --- Review === Good: - rpmlint checks return nothing - package meets naming guidelines (PHP) - package meets packaging guidelines (PHP) - license (LGPLv2+ and MIT and BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (53d644dd56fbe58056ba33ff42a58482c86f330e92c9aceefdd86788171a1da2) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501101 --- Comment #3 from Arun SAG saga...@gmail.com 2009-09-24 07:10:23 EDT --- Ok, everything should be fixed now. Check the new files in http://people.freedesktop.org/~fargiolas/emacs-color-theme-fixed/ Yes, rebuilt and checked no issues. Sure, if you already have packager privileges, go ahead. Thank you! I am not a packager yet, waiting for sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 524346] Review Request: avra - ATmel AVR 8-bit RISC microcontroller assembler
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524346
--- Comment #8 from Chitlesh GOORAH chitl...@gmail.com 2009-09-24 10:58:56
EDT ---
#001: the following should be in the %prep section
aclocal
autoconf
automake -a
# Fix up encoding of documentation
dos2unix -k AUTHORS
iconv -f ISO-8859-1 -t UTF-8 README -o README.new
touch -r README README.new
mv README.new README
# Unpack include files
unzip AVR000.zip -d include
# Fix permissions and encoding of examples
chmod 644 Example/*
dos2unix -k Example/*
#002: %doc
For example, do the following
%doc Example
instead
%doc Example/*
This will preserve the examples in a separate directory and not mixing it with
other files
#003: use %{_datadir} macro instead of /usr/share
#004: Directory ownership
in %files,
add
%dir %{_datadir/%{name}-%{version}
#004: Preserve timestamps during make install process by adding
INSTALL=%{_bindir}/install -p to your make install
Also add -p to your
install -m 0644 *.inc .
#005: Add a small on %description stating that fedora also ships some deviced
definition *.inc files in %{_datadir/%{name}-%{version}.
It will be helpful to the user
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525146] Review Request: PDCurses - Public Domain curses library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525146 --- Comment #8 from Jon Ciesla l...@jcomserv.net 2009-09-24 10:45:52 EDT --- I agree that 3 is best and 2 is awful. I just put 2 out there since it is technically possible. Re 1 and 3, is is the SDL bindings that are the critical part, and, AFAICT, the reason PDCurses was selected of ncurses. I'm not aware of any ncurses SDL bindings. In a few cases in my own code, where I need both, I just use both, for instance I've written but not yet released a game using ncurses and SDL_mixer. I think 3 would basically mean porting the PDCurses SDL bindings to ncurses. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525304] Review Request: notification-daemon-engine-slider - The Slider theme engine for the notification daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525304 William Jon McCann jmcc...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from William Jon McCann jmcc...@redhat.com 2009-09-24 11:13:17 EDT --- Ok updated to fix the empty files. Requesting cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525358] Review Request: python-assets - Cache-friendly asset management via content-hash-naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525358 --- Comment #3 from kashyap chamarthy kcham...@redhat.com 2009-09-24 11:59:34 EDT --- Jason, thanks. yes, rpmlint is clean now. On a side note, even I'm new to packaging. As you may already be aware of, only a registered sponsor can approve/review officially the first package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525304] Review Request: notification-daemon-engine-slider - The Slider theme engine for the notification daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525304 --- Comment #4 from William Jon McCann jmcc...@redhat.com 2009-09-24 12:01:35 EDT --- New Package CVS Request === Package Name: notification-daemon-engine-slider Short Description: The Slider theme engine for the notification daemon Owners: mccann Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 524105] Review Request: fence-virt - Modular virtual machine fencing daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524105 --- Comment #13 from Lon Hohberger l...@redhat.com 2009-09-24 12:08:06 EDT --- Strange; I've had fedora CVS package commit access for some time, yet I can't set fedora-cvs? ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525304] Review Request: notification-daemon-engine-slider - The Slider theme engine for the notification daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525304 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-09-24 12:23:38 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522777] Review Request: perl-Verilog-Perl - Verilog parsing routines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522777 --- Comment #3 from Chitlesh GOORAH chitl...@gmail.com 2009-09-24 12:21:33 EDT --- (In reply to comment #2) So this is just a rename review request? I'll do a quick runthrough. Yes it is just a rename review request. The Obsoletes: and Provides: done There are a couple of provides which look a bit odd. I think that for some bizarre reason the automatic dependency finder actually parses package statements in some verilog source (installed as documentation) as perl package statements, and so you end up with the bogus perl(imp_test_pkg) and perl(mypackage). That's pretty bad behavior from rpmbuild almost certainly worthy of a bug, but you'll still need to filter those dependencies. Unfortunately you can't use the general dependency filtering mechanism just introduced because this package is arch-specific. Perhaps the mechanism at http://fedoraproject.org/wiki/Packaging:Perl#Filtering_Requires:_and_Provides will work for you. done The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. I'm doing my package reviews regularly :) Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-Perl.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-Perl-3.213-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502854] Review Request: sblim-cmpi-nfsv3 - SBLIM nfsv3 instrumentation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502854
Matt Domsch matt_dom...@dell.com changed:
What|Removed |Added
Flag|needinfo?(matt_dom...@dell. |
|com)|
--- Comment #5 from Matt Domsch matt_dom...@dell.com 2009-09-24 12:24:50 EDT
---
Matt, the 'libLinux_NFSv3SystemConfigurationUtil.so' should be in
%{_libdir}/cmpi/ too?
yes. All CMPI plugins should be in /usr/%{_libdir}/cmpi/.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520246] Review Request: python-sysv_ipc - System V IPC for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520246 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #3 from Kevin Fenzi ke...@tummy.com 2009-09-24 12:26:32 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 466183] Review Request: sblim-sfcb - Small Footprint CIM Broker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466183 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #31 from Kevin Fenzi ke...@tummy.com 2009-09-24 12:25:03 EDT --- Thanks! cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 520343] Review Request: clc - command line client for MUDs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520343 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-09-24 12:27:17 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 516906] Review Request: frePPLe - Free Production Planning Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516906 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #19 from Kevin Fenzi ke...@tummy.com 2009-09-24 12:28:07 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 519512] Review Request: cmusphinx3 - Large vocabulary speech recognition in C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519512
--- Comment #9 from Martin Gieseking martin.giesek...@uos.de 2009-09-24
12:34:18 EDT ---
I just noticed that you can drop %attr(0755,root,root) from
%attr(0755,root,root) %{python_sitearch}/_sphinx3.so
because it's applied automatically.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 523650] Package Review: qmpdclient
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523650 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #9 from Rex Dieter rdie...@math.unl.edu 2009-09-24 12:37:43 EDT --- for desktop-file-install, just add BuildRequires: desktop-file-utils -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522747] Review Request: skrooge - Personal finances manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522747 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #11 from Rex Dieter rdie...@math.unl.edu 2009-09-24 12:36:18 EDT --- This is built and in the repos, I think we can close this now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525510] New: Review Request: geda-gaf - Design Automation toolkit for electronic design
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: geda-gaf - Design Automation toolkit for electronic design https://bugzilla.redhat.com/show_bug.cgi?id=525510 Summary: Review Request: geda-gaf - Design Automation toolkit for electronic design Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: chitl...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://chitlesh.fedorapeople.org/RPMS/geda-gaf.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/geda-gaf-1.5.4-1.fc11.src.rpm Description: The GPL Electronic Design Automation (gEDA) project has produced and continues working on a full GPL'd suite and toolkit of Electronic Design Automation tools. These tools are used for electrical circuit design, schematic capture, simulation, prototyping, and production. Currently, the gEDA project offers a mature suite of free software applications for electronics design, including schematic capture, attribute management, bill of materials (BOM) generation, netlisting into over 20 netlist formats, analog and digital simulation, and printed circuit board (PCB) layout. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 521851] Review Request: perl-Nagios-Plugin-Beanstalk - Nagios plugin to observe Beanstalkd queue server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521851 --- Comment #9 from Jason Tibbitts ti...@math.uh.edu 2009-09-24 12:45:09 EDT --- We have no guidelines for nagios plugins, so the perl naming guidelines would seem to override. Certainly worth discussing, I guess, and you are quite welcome to present some draft guidelines to the packaging committee. The package as I reviewed it didn't violate any existing guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525510] Review Request: geda-gaf - Design Automation toolkit for electronic design
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525510 --- Comment #1 from Chitlesh GOORAH chitl...@gmail.com 2009-09-24 12:49:36 EDT --- This package will obsolete all the geda packages available under the fedora repositories. With the upcoming releases, the geda community will provide only big tarball instead of smaller packages. Hence in accordance to fedora packaging guidelines, I have to file another package review before obsoleting the existing fedora geda-gaf packages. Please note that upstream releases, the tarball under the name of gEDA-gaf, however in order to maintain consistency between various distributions, Packagers of various distributions have agreed to use the name geda-gaf as the debian community does not accept capital letters. That said, upstream agreed to release the next release under geda-gaf without any capital letters. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 504261] Review Request: mailody - Simple KDE-based IMAP mail client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504261 --- Comment #18 from Ben Boeckel maths...@gmail.com 2009-09-24 12:52:13 EDT --- Can this be built for F10 and F11? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 522657] Review Request: kmymoney2-aqbanking - Online banking plugin for KMyMoney
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522657 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added CC||chitl...@gmail.com AssignedTo|nob...@fedoraproject.org|chitl...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525510] Review Request: geda-gaf - Design Automation toolkit for electronic design
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525510 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 517643] Review Request: php-doctrine-Doctrine - PHP Object Relational Mapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517643 Christof Damian chris...@damian.net changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Christof Damian chris...@damian.net 2009-09-24 12:57:25 EDT --- New Package CVS Request === Package Name: php-doctrine-Doctrine Short Description: PHP Object Relational Mapper Owners: cdamian Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 524105] Review Request: fence-virt - Modular virtual machine fencing daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524105 Fabio Massimo Di Nitto fdini...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Fabio Massimo Di Nitto fdini...@redhat.com 2009-09-24 13:01:16 EDT --- setting fedora-cvs? for lon -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
