[Bug 180571] Review Request: puppet

2006-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-07-11 21:11 EST ---
The ruby(abi) is provided by ruby-libs, not ruby (!) Since the package contains
scripts that want /usr/bin/ruby, I added the explicit R: ruby, analogous to what
python packages do (e.g., yum requires both python and /usr/bin/python) If
that's not the right thing to do, I'll fix it in the next release.

Imported and built successfully as job 12479

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571


Bug 180571 depends on bug 182064, which changed state.

Bug 182064 Summary: Review Request: facter
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182064

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-08 00:03 EST ---
Built against 1.3.3-1 facter.

rpmlint is noisy.

E: puppet zero-length /usr/share/doc/puppet-0.18.2/examples/root/etc/configfile
E: puppet zero-length /usr/share/doc/puppet-0.18.2/examples/root/etc/otherfile
Ignore.

E: puppet non-standard-uid /var/lib/puppet puppet
E: puppet non-standard-gid /var/lib/puppet puppet
E: puppet non-standard-uid /var/log/puppet puppet
E: puppet non-standard-gid /var/log/puppet puppet
E: puppet non-standard-uid /var/run/puppet puppet
E: puppet non-standard-gid /var/run/puppet puppet
The user/group was added. Ignore.

W: puppet doc-file-dependency
/usr/share/doc/puppet-0.18.2/examples/root/bin/sleeper /usr/bin/ruby
Required for puppet, ok.

E: puppet incoherent-subsys /etc/rc.d/init.d/puppet puppet}

W: puppet mixed-use-of-spaces-and-tabs
Cosmetic.

W: puppet-server no-documentation
Fine.

W: puppet-server incoherent-init-script-name puppetmaster
Not puppet, ok.


Defines %ruby_sitelibdir as per guidlines.

- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR

Do you need both of:
Requires: ruby >= 1.8.1 and
Requires: ruby(abi) = 1.8 ?
Merely redundant if so.

- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-07-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571





--- Additional Comments From [EMAIL PROTECTED]  2006-07-06 13:59 EST ---
* Updated to latest upstream release 0.18.2

Spec: http://people.redhat.com/dlutter/yum/spec/puppet.spec
SRPM: http://people.redhat.com/dlutter/yum/SRPMS/puppet-0.18.2-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-06-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-22 16:11 EST ---
Unblocking FE-NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-06-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571





--- Additional Comments From [EMAIL PROTECTED]  2006-06-20 19:38 EST ---
* Updated to latest upstream release 0.18.0

Spec: http://people.redhat.com/dlutter/yum/spec/puppet.spec
SRPM: http://people.redhat.com/dlutter/yum/SRPMS/puppet-0.18.0-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571





--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 12:17 EST ---
Did you rebuild facter after the problems you had on bug 182064 ? Can you paste
the output of 'rpm -ql facter' in this ticket ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571





--- Additional Comments From [EMAIL PROTECTED]  2006-05-06 13:48 EST ---
Not running on FC5, x86_64, ruby-1.8.4-3.2

$ puppet
/usr/lib64/site_ruby/1.8/puppet/server/filebucket.rb:8:in `require': no such
file to load -- facter (LoadError)
from /usr/lib64/site_ruby/1.8/puppet/server/filebucket.rb:8
from /usr/lib64/site_ruby/1.8/puppet/server.rb:180
from /usr/lib64/site_ruby/1.8/puppet.rb:332
from /usr/bin/puppet:58

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 180571] Review Request: puppet

2006-05-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: puppet


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571





--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 20:08 EST ---
* Updated to latest upstream release 0.16.5

Spec: http://people.redhat.com/dlutter/yum/spec/puppet.spec
SRPM: http://people.redhat.com/dlutter/yum/SRPMS/puppet-0.16.5-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review