[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/show_bug.cgi?id=185951 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 Bug 185951 depends on bug 186327, which changed state. Bug 186327 Summary: Review Request: tcltls https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186327 What|Old Value |New Value Resolution|NEXTRELEASE | Status|CLOSED |NEW -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 Bug 185951 depends on bug 186327, which changed state. Bug 186327 Summary: Review Request: tcltls https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186327 What|Old Value |New Value Resolution||NEXTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 Bug 185951 depends on bug 193853, which changed state. Bug 193853 Summary: avoid using abbreviated sub-commands https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193853 What|Old Value |New Value Resolution||ERRATA Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: amsn : msn messenger clone
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951
--- Additional Comments From [EMAIL PROTECTED] 2006-06-20 03:30 EST ---
(In reply to comment #31)
(In reply to comment #27)
(In reply to comment #25)
* Missing Requires: mozilla. I would recommend, however, changing the
default browser command from 'mozilla $url' to 'htmlview $url' and
adding Requires: htmlview. This will launch the url in the
user's preferred web browser.
I changed mozilla to htmlview but I am not sure about requiring it. aMSN
runs
fine without it, only when you try to open an url it tells you you should
check
your preferences. People not having htmlview have chosen for that i guess,
since
it is installed by default.
I still think you should add Requires: htmlview, sox. If the application
uses it, it should be in the Requires: list. Even though htmlview is
installed by default, it's best to make sure that the package has it
available. Fortunately, amsn won't crash if it's not there, it will just
print out a warning that the user needs to modify their configuration.
I don't think the additional Requires: will hurt anything.
Ok, in the past I have been pissed off when i wanted to remove something, and it
pulled in lots of other stuff which I didn't see the point in. I added the
requires for sox, htmlview and tkdnd (since that seems to fall in the same
category, without it drag and drop doesn't work)
Are there plans to make the RC1 release public? It'd be really nice to have a
working Source0: link in the spec file that points to SF. Right now I can't
get
to it using curl, wget, or a browser.
Yes there are plans, but we want all packages created first, and synced to
mirrors. In the meanwhile go to:
http://prdownloads.sourceforge.net/amsn/amsn-0.96rc1.tar.bz2?download since what
is in Source0 should work, but doesn't because of sf slowness I think.
* Is there a special reason why the amsn commands (amsn, amsn-remote,
amsn-remote-CLI) are located in %{_datadir}/amsn and only linked to
%{_bindir}? Why can't they just be installed directly into %{_bindir}?
Yes, the file perform some magic to see where they are located, and set some
variables accordingly to be able to find plugins etc.
Ok. That makes sense. You might suggest to upstream :) that they validate
$program_dir before trying to resolve symlinks. This would allow you to use
sed
in the spec file to set program_dir to %{_datadir}/%{name} and bypass the
symlink dereferencing in the program. As a result, the program should still
work as it does now, but it would also work if amsn weren't installed in the
data directory.
No changes were needed, after some looking at the code I could do it with one
sed line in the spec
A few other items:
MUSTFIX
===
* Remove the extra from the comment in the .desktop file
ok, did it in the spec and upstream as well
* It turns out that /usr/share/amsn/README is needed at runtime for the
About box. You can go ahead and remove it from the list of doc files
that are deleted during %install. Do you know of any other doc files
that are used at runtime?
Only HELP, which you mention below and CREDITS, which I now don't delete as well
SHOULD
==
* The Help - Contents menu item doesn't seem very useful, since it
describes how to install and start amsn, which the user must have
already done if they can activate the menu. I'd suggest to upstream that
they either remove this menu item, or replace the Help -Contents text with
something more useful.
Ok, I told upstream :) and they told me it will be fixed before next release.
Good catch, I guess we never read the help documents ourselves..
http://amsn.hoentjen.eu/download/amsn.spec
http://amsn.hoentjen.eu/download/amsn-0.96-0.11.rc1.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-20 13:53 EST --- (In reply to comment #32) Yes there are plans, but we want all packages created first, and synced to mirrors. In the meanwhile go to: http://prdownloads.sourceforge.net/amsn/amsn-0.96rc1.tar.bz2?download since what is in Source0 should work, but doesn't because of sf slowness I think. This now works. Maybe it took longer than expected to propogate to the mirrors? Source matches upstream: 1b90fdbb0a51c7646f4d2e6b22f18711 amsn-0.96rc1.tar.bz2 All MUSTFIX items fixed. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-06-21 01:28 EST --- built for FC5 and devel -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: amsn : msn messenger clone
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951
--- Additional Comments From [EMAIL PROTECTED] 2006-06-19 06:10 EST ---
Thank you very much for your comments Paul and Wart.
Paul:
(In reply to comment #23)
I fixed the $RPM_BUILD_ROOT inconsistency. The rest of your comments are already
answered by Wart.
Wart:
(In reply to comment #25)
* Missing Requires: mozilla. I would recommend, however, changing the
default browser command from 'mozilla $url' to 'htmlview $url' and
adding Requires: htmlview. This will launch the url in the
user's preferred web browser.
I changed mozilla to htmlview but I am not sure about requiring it. aMSN runs
fine without it, only when you try to open an url it tells you you should check
your preferences. People not having htmlview have chosen for that i guess, since
it is installed by default.
* Missing Requires: sox for /usr/bin/play for playing sounds.
Same as htmlview, aMSN runs fine without sound.
QUESTIONS
=
* Official upstream sources come from sourceforge.net, but this rc release
comes from elsewhere. Since I know you're one of the upstream developers,
I'm not too concerned about this, but it would be better if Source0:
pointed to upstream's official download page.
Sorry, I meant to write the reason in my previous comment but forgot. At the
time I had trouble uploading the file to sf, but in the meantime i have done so.
I changed Source0 accordingly. Just be aware that the release is still hidden so
you won't find the file on the project website yet.
* You might consider submitting cximage as a separate package instead of
including it in amsn. Since Fedora doesn't include cximage already,
this won't block the review.
The CxImage supplied with amsn is much different from upstream, and i think not
all patches were accepted so it will stay that way but i am not sure. (I will
check if this is really true)
* Is there a special reason why the amsn commands (amsn, amsn-remote,
amsn-remote-CLI) are located in %{_datadir}/amsn and only linked to
%{_bindir}? Why can't they just be installed directly into %{_bindir}?
Yes, the file perform some magic to see where they are located, and set some
variables accordingly to be able to find plugins etc.
* Is it necessary to include the %{_datadir}/amsn/lang/missing.py,
convert.tcl,
and sortlang utilities in the package?
No, language maintainers should use the svn version anyway, so i removed all
tools.
http://amsn.hoentjen.eu/download/amsn.spec
http://amsn.hoentjen.eu/download/amsn-0.96-0.9.rc1.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-06-19 06:54 EST --- Oh I almost forgot, I think I should require tk = 8.4.13 since you can get a bug with older versions. Do I put that in for FC5 only or also for devel? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-06-19 14:55 EST --- (In reply to comment #29) That would be fair. Definitely put it in for FC5, as the tk 8.4.13 package will almost certainly get pushed to FC5 (if it's not there already). It should be in devel as well since releases 8.4.13 have been published for devel. ok, I added it http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.10.rc1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: amsn : msn messenger clone
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951
--- Additional Comments From [EMAIL PROTECTED] 2006-06-19 17:08 EST ---
(In reply to comment #27)
(In reply to comment #25)
* Missing Requires: mozilla. I would recommend, however, changing the
default browser command from 'mozilla $url' to 'htmlview $url' and
adding Requires: htmlview. This will launch the url in the
user's preferred web browser.
I changed mozilla to htmlview but I am not sure about requiring it. aMSN runs
fine without it, only when you try to open an url it tells you you should
check
your preferences. People not having htmlview have chosen for that i guess,
since
it is installed by default.
I still think you should add Requires: htmlview, sox. If the application
uses it, it should be in the Requires: list. Even though htmlview is
installed by default, it's best to make sure that the package has it
available. Fortunately, amsn won't crash if it's not there, it will just
print out a warning that the user needs to modify their configuration.
I don't think the additional Requires: will hurt anything.
* Missing Requires: sox for /usr/bin/play for playing sounds.
Same as htmlview, aMSN runs fine without sound.
See above.
QUESTIONS
=
* Official upstream sources come from sourceforge.net, but this rc release
comes from elsewhere. Since I know you're one of the upstream developers,
I'm not too concerned about this, but it would be better if Source0:
pointed to upstream's official download page.
Sorry, I meant to write the reason in my previous comment but forgot. At the
time I had trouble uploading the file to sf, but in the meantime i have done
so.
I changed Source0 accordingly. Just be aware that the release is still hidden
so
you won't find the file on the project website yet.
Are there plans to make the RC1 release public? It'd be really nice to have a
working Source0: link in the spec file that points to SF. Right now I can't get
to it using curl, wget, or a browser.
* You might consider submitting cximage as a separate package instead of
including it in amsn. Since Fedora doesn't include cximage already,
this won't block the review.
The CxImage supplied with amsn is much different from upstream, and i think
not
all patches were accepted so it will stay that way but i am not sure. (I will
check if this is really true)
Ok.
* Is there a special reason why the amsn commands (amsn, amsn-remote,
amsn-remote-CLI) are located in %{_datadir}/amsn and only linked to
%{_bindir}? Why can't they just be installed directly into %{_bindir}?
Yes, the file perform some magic to see where they are located, and set some
variables accordingly to be able to find plugins etc.
Ok. That makes sense. You might suggest to upstream :) that they validate
$program_dir before trying to resolve symlinks. This would allow you to use sed
in the spec file to set program_dir to %{_datadir}/%{name} and bypass the
symlink dereferencing in the program. As a result, the program should still
work as it does now, but it would also work if amsn weren't installed in the
data directory.
A few other items:
MUSTFIX
===
* Remove the extra from the comment in the .desktop file
* It turns out that /usr/share/amsn/README is needed at runtime for the
About box. You can go ahead and remove it from the list of doc files
that are deleted during %install. Do you know of any other doc files
that are used at runtime?
SHOULD
==
* The Help - Contents menu item doesn't seem very useful, since it
describes how to install and start amsn, which the user must have
already done if they can activate the menu. I'd suggest to upstream that
they either remove this menu item, or replace the Help -Contents text with
something more useful.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 08:35 EST --- updated to 0.96 rc1 http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.8.rc1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: amsn : msn messenger clone
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-06-18 18:21 EST ---
The $RPM_BUILD_ROOTs need to be consistent
either ${RPM_BUILD_ROOT} or easier, %{buildroot}, but don't mix them.
You're also taking ownership of directories (by the looks of it)
Instead of
%{_datadir}/amsn/foo/
use
%{_datadir}/amsn/foo/*.zip (for example)
You cannot guarantee that later on someone won't create a plugin which needs to
be added to the directory owned by the package
Is there not other languages for this package?
If there is - under the %install
%find_lang {name}
Then on the files line
%files -f %{name}.lang
However, some apps install the language files as part of the make install, so
you may find this step fails.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: amsn : msn messenger clone
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951
--- Additional Comments From [EMAIL PROTECTED] 2006-06-18 18:27 EST ---
Is there not other languages for this package?
If there is - under the %install
%find_lang {name}
Then on the files line
%files -f %{name}.lang
However, some apps install the language files as part of the make install, so
you may find this step fails.
There are other language files, but they're stored in %{_datadir}/%{name}/lang,
not %{_datadir}/locale. I understood that %find_lang was only needed for apps
that use %{_datadir}/locale.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-16 13:55 EST --- Sorry for the delay in the review. I'll do a full review this weekend. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-06-08 21:42 EST --- (In reply to comment #20) http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.7.20060608svn.src.rpm I get a 404 on that src.rpm url. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-06-09 00:13 EST --- (In reply to comment #21) (In reply to comment #20) http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.7.20060608svn.src.rpm I get a 404 on that src.rpm url. sorry, fixed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 Bug 185951 depends on bug 186327, which changed state. Bug 186327 Summary: Review Request: tcltls https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186327 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-05-25 13:40 EST --- I took a look at Amsn_BWidget to see what the changes are, and they don't seem very major to me. Hopefully upstream will agree and accept the changes. * Some documentation and image updates * improvements to the font selector to allow disabling the font color, size, and style * Some minor widget layout changes (reordering buttons, changing borderwidths) * New methods in the scrolledwidget for resizing * A handful of modified RCS strings on otherwise-unmodified files But I don't understand the reasoning behind a couple of the changes: * Removal of -background setting in scrolledwindow * The extra rename of ::$path:cmd in widget.tcl A possible alternative is to include only the modified files in Amsn_BWidget, and rely on the FE bwidget package for all of the rest: # Pull the base BWidget from FE package require BWidget # Pull in only the modified files from Amsn package require Amsn_BWidget This might take some work to do right (hacking the pkgIndex.tcl file, probably), but should allow you to use modified BWidget files without including the entire BWidget library in amsn. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-05-20 07:02 EST --- (In reply to comment #14) It also includes a copy of the BWidget tcl package, which I've already packaged for FE. Just add Requires: bwidget and don't include the local copy. The one that is used by amsn is modified, amsn won't work with the original one. (In reply to comment #15) (In reply to comment #13) amsn builds against local copies of libpng, libjpeg, and zlib, which is a no-no for Fedora Extras. This must be changed to build against the system copies. You don't have to remove them from the sources, just make sure it links against the existing libpng/libjpeg/zlib, and add BuildRequires: libpng-devel libjpeg-devel zlib-devel I had a similar issue to this with gtkwave, which bundles zlib and bzip2. I made absolutely sure that the system libraries were used by not only patching the Makefiles but deleting the bundled libraries from the unpacked sources in %prep so that there was no possibility of building and linking against them. Done, see: http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.6.20060517svn.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-05-18 04:31 EST --- I updated the spec and srpm to a new upstream version. I also removed some tcl packages that were shipped with amsn that i now Require: amsn 0.96 is going to be released soon so I hope someone will sponsor me so I can release the rpm at the same time. http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.5.20060517svn.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-05-18 04:56 EST --- BTW, I don't think soon is enough. You should provide a package to the current version too, getting into Extras first, then updating it as the next release comes. I say this because leaving the release for later isn't good. I think the most important thing is to bring this good app to Extras right now, with the current stable version, and then updating it when a new version is release (we all don't know when this will occur, and looking at amsn's history, I think we got to wait ;-) So the summary is: please make a package for version 0.95 :) I would be glad to follow your steps and help on what I can. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-05-18 15:09 EST --- It also includes a copy of the BWidget tcl package, which I've already packaged for FE. Just add Requires: bwidget and don't include the local copy. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 185951] Review Request: amsn : msn messenger clone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 --- Additional Comments From [EMAIL PROTECTED] 2006-05-18 15:30 EST --- (In reply to comment #13) amsn builds against local copies of libpng, libjpeg, and zlib, which is a no-no for Fedora Extras. This must be changed to build against the system copies. You don't have to remove them from the sources, just make sure it links against the existing libpng/libjpeg/zlib, and add BuildRequires: libpng-devel libjpeg-devel zlib-devel I had a similar issue to this with gtkwave, which bundles zlib and bzip2. I made absolutely sure that the system libraries were used by not only patching the Makefiles but deleting the bundled libraries from the unpacked sources in %prep so that there was no possibility of building and linking against them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
