[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-11-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-11-11 23:48 EST ---
To add my 2 cents, I also like to have .spec files linked to reviews. 
It does make it easier to see whats going on with a package without 
having to pull down and unpack the src.rpm. 

That said, here's a review of this package: 


OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
74780f7f296f1feac13f4358b97bd2f3  vdr-subtitles-0.4.0.tgz
74780f7f296f1feac13f4358b97bd2f3  vdr-subtitles-0.4.0.tgz.1

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
x86_64/i386 - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. The debian patch at:

http://zap.tartarus.org/~ds/debian/dists/unstable/main/source/vdr-plugin-subtitles_0.3.11-1.ds.diff.gz

is old. Looks like there is a 0.4.0 version there now.
Perhaps updating to that will let you remove a sed in there for the version?

I don't see any blockers however, so this package is APPROVED.
Don't forget to close this NEXTRELEASE once it's been imported and built.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-10-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346


Bug 190346 depends on bug 190343, which changed state.

Bug 190343 Summary: Review Request: VDR - Video Disk Recorder
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190343

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 16:59 EST ---
The URL to the spec file is missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 17:56 EST ---
See bug 190344 comment 2.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 190346] Review Request: vdr-subtitles - DVB subtitles plugin for VDR

2006-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-subtitles - DVB subtitles plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190346





--- Additional Comments From [EMAIL PROTECTED]  2006-05-06 14:43 EST ---
http://cachalot.mine.nu/5/SRPMS/vdr-subtitles-0.4.0-1.src.rpm

* Sat May  6 2006 Ville Skyttä ville.skytta at iki.fi - 0.4.0-1
- 0.4.0.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review