[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-09 10:11 EST --- * rpmlint is silent * package name ipe is good * license is gpl and included with the main package * spec file is readable and clear * builds in mock/i386 and installs flawlessly * contains shared libraries and invokes ldconfig in %post and %postun * owns all directories it creates * large documentation in -doc subpackage * desktop file installed SHOULD: * there is no icon for the .desktop file, add one later, if available * the documentation is in /usr/share/ipe/6.0/doc; if it is not too much work, move it to /usr/share/doc/ipe-doc-6.0 * if the doc package is not installed, the web browser will report an error, if help is invoked in ipe; I don't consider this a blocker, but should probably dealt with somehow MUST: * ipe-doc must depend on ipe please deal with MUST, then import the package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: The Ipe extensible drawing editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208
--- Additional Comments From [EMAIL PROTECTED] 2006-07-09 18:19 EST ---
(In reply to comment #6)
MUST:
* ipe-doc must depend on ipe
please deal with MUST, then import the package
APPROVED
Thank you for your review! I have commited release 6.0-0.7.pre26:
* Tue Jul 4 2006 Laurent Rineau
[EMAIL PROTECTED] - 6.0-0.7.pre26
- In %%files, use libipe.so.1*, instead of libipe.so.*
- Make sub-package %%{name}-doc depend on %%{name}
* Wed Jun 28 2006 Laurent Rineau
[EMAIL PROTECTED] - 6.0-0.6.pre26
- Added a patch, ipe_6.0pre26-initui.cpp.patch, to fix temporarely an upstream
bug: QMenu aboutToshow() signal has a lowercase a.
SHOULD:
* there is no icon for the .desktop file, add one later, if available
The upstream tarball has no icon. Who should create one. Me?!
* the documentation is in /usr/share/ipe/6.0/doc; if it is not
too much work, move it to /usr/share/doc/ipe-doc-6.0
Well, I do not know how to install things into /usr/share/doc/ipe-doc-6.0,
because the %doc macro of the -doc subpackage begins with:
rm -rf %{_buildroot}/usr/share/doc/ipe-doc-6.0
which remove all files installed here during %install
* if the doc package is not installed, the web browser will report an error,
if help is invoked in ipe; I don't consider this a blocker, but should
probably dealt with somehow
Maybe I should merge the doc package with the main package. Or trick a
IPEBROWSER script that checks the presence of the documentation.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-07-09 18:42 EST --- ipe build in devel: http://buildsys.fedoraproject.org/build-status/job.psp?uid=12338 Branches requested for FC-4 and FC-5. I close this ticket, but I still expect suggestions, for my questions of comment #7. You can continue to write in this ticket, Gérard. -- Laurent, sad because of France has not won the world cup, today. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 --- Additional Comments From [EMAIL PROTECTED] 2006-06-20 03:05 EST --- Update: Spec URL: http://www.di.ens.fr/~rineau/Fedora/ipe.spec SRPM URL: http://www.di.ens.fr/~rineau/Fedora/ipe-6.0-0.5.pre26.src.rpm %changelog * Tue Jun 20 2006 Laurent Rineau [EMAIL PROTECTED] - 6.0-0.5.pre26 - New patch ipe-6.0pre26-ipelet-pro_files.patch: fix the pro files of ipelets: the configshould be plugin instead of dll. - Cleanup of the %%files directives: do not own directories which are created by the main package in subpackages. Thank you for your help, Gérard. The upstream ipelets pro files where incorrect, actually. I am in touch with the upstream author. The patch will be in next public prerelease, I think. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 --- Additional Comments From [EMAIL PROTECTED] 2006-06-19 17:00 EST --- rpmlint ipe-devel-6.0-0.4.pre26.i386.rpm E: ipe-devel only-non-binary-in-usr-lib W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libalign.so libalign.so.1.0.0 W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libtemplates.so libtemplates.so.1.0.0 W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libimage.so libimage.so.1.0.0 W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libvisibility-polygon.so libvisibility-polygon.so.1.0.0 W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libgoodies.so libgoodies.so.1.0.0 W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libkgon.so libkgon.so.1.0.0 W: ipe-devel dangling-relative-symlink /usr/lib/ipe/6.0/ipelets/libsmallest-circle.so libsmallest-circle.so.1.0.0 Are these .so files really necessary? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 --- Additional Comments From [EMAIL PROTECTED] 2006-05-28 12:41 EST --- Update: Spec URL: http://www.di.ens.fr/~rineau/Fedora/ipe.spec SRPM URL: http://www.di.ens.fr/~rineau/Fedora/ipe-6.0-0.4.pre26.src.rpm * Sun May 28 2006 Laurent Rineau [EMAIL PROTECTED] - 6.0-0.4.pre26 - No longer hardcode qt4 prefix. Use pkg-config instead. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 --- Additional Comments From [EMAIL PROTECTED] 2006-05-21 14:13 EST --- Update: Spec URL: http://www.di.ens.fr/~rineau/Fedora/ipe.spec SRPM URL: http://www.di.ens.fr/~rineau/Fedora/ipe-6.0-0.3.pre26.src.rpm * Sun May 21 2006 Laurent Rineau [EMAIL PROTECTED] - 6.0-0.3.pre26 - Added a desktop file for Ipe. * Sun May 21 2006 Laurent Rineau [EMAIL PROTECTED] - 6.0-0.2.pre26 - Fix directories ownership. - ipelets/*.so are now in -devel. - Creation of -doc subpackage. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191208] Review Request: The Ipe extensible drawing editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: The Ipe extensible drawing editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191208 --- Additional Comments From [EMAIL PROTECTED] 2006-05-11 03:07 EST --- Update, fix the Release tag: Spec URL: http://www.di.ens.fr/~rineau/Fedora/ipe.spec SRPM URL: http://www.di.ens.fr/~rineau/Fedora/ipe-6.0-0.1.pre26.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
