[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 --- Additional Comments From [EMAIL PROTECTED] 2006-09-16 16:41 EST --- (In reply to comment #4) The .desktop file should be in a separate file and not inside the spec. I decided to delete the .desktop file, as well as the fluidsynth-dssi binary, since it is redundant. FE already has many other ways to run fluidsynth (qsynth, etC). make install DESTDIR=$RPM_BUILD_ROOT instead of %makeinstall should work, so you must not use %makeinstall Fixed. You do not package COPYING with contains the license. Fixed. The license seems to be GPL but you wrote LGPL in the spec. Fixed. Updated bits here: Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi.spec SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi-0.9.1-4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|189886, 189891 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-16 18:49 EST --- BuildRequires: alsa-lib-devel liblo-devel ladspa-devel is not needed since dssi-devel already depends on them and is in BuildRequires rpmlint: ok naming: ok packaging guidelines: ok license: ok sources: ok 06bce40ec6c86545d0587e9364bba116 fluidsynth-dssi-0.9.1.tar.gz 06bce40ec6c86545d0587e9364bba116 fluidsynth-dssi-0.9.1.tar.gz.1 files and directories: ok mock build: ok Change the buildrequires and the package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-09-16 19:25 EST --- (In reply to comment #6) Change the buildrequires and the package is APPROVED Done, thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 --- Additional Comments From [EMAIL PROTECTED] 2006-09-15 14:44 EST --- The .desktop file should be in a separate file and not inside the spec. You do not need: Requires(post): desktop-file-utils Requires(postun): desktop-file-utils make install DESTDIR=$RPM_BUILD_ROOT instead of %makeinstall should work, so you must not use %makeinstall see: http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 You do not package COPYING with contains the license. The license seems to be GPL but you wrote LGPL in the spec. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 --- Additional Comments From [EMAIL PROTECTED] 2006-09-04 16:52 EST --- Thanks - I've updated the SRPM here: Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi.spec SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-dssi-0.9.1-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590
--- Additional Comments From [EMAIL PROTECTED] 2006-08-24 16:00 EST ---
The specfile uses make instead of make %{?_smp_mflags}
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-08-24 15:56 EST ---
I guess to avoid rpmlint symlink errors/warnings you can change
ln -s %{_bindir}/jack-dssi-host $RPM_BUILD_ROOT%{_bindir}/fluidsynth-dssi
to
cd %{_bindir}
ln -s jack-dssi-host fluidsynth-dssi
cd -
because there is no need to make the symlinks across the filesystem if source
and target are in the same directory. This concerns also your other dssi
plugin(s).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|189892 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191590] Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluidsynth-dssi - a FluidSynth DSSI plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
