[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 09:44 EST --- With the patch, the rpm flags are not acknowledged and the include and libdir are hardcoded, so I propose the attaced patch instead. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 09:48 EST --- Created an attachment (id=129318) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=129318action=view) use variables on make command line to change compilation defaults -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 11:04 EST --- Hi Patrice, that certainly is an improvement -- thank you! And here are the updated files: http://mitgcm.org/eh3/fedora_misc/scrip-1.4-4.src.rpm http://mitgcm.org/eh3/fedora_misc/scrip.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 12:39 EST --- * rpmlint is silent * naming is good * follow packaging guidelines * licence acceptable and included * spec legible * source match upstream * everything else is fine * builds in mock APPROVED comments: * the timestamp of the sources is wrong, I find it better to have the right timestamp. In general I use spectool to achive that (or maybe wget -N). * the executables in grids/ may be compiled and distributed maybe with scrip_ prefixed, and in that case the README file may also be added, renamed for example README.utils. * the bugs file could be in %docs -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 13:08 EST --- Did anyone notice that the license is not BSD as indicated in the spec? I believe it is free according to the Open Source Definition, but the text certainly does not resemble the BSD license text and the derivative works clause: If SOFTWARE is modified to produce derivative works, such modified SOFTWARE should be clearly marked, so as not to confuse it with the version available from Los Alamos National Laboratory. is not present in the BSD license. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 13:26 EST --- Hi Jason, you're right that its not exactly BSD. It does appear to be sufficiently open in that it allows modification, redistribution, sale, etc. So I think the licesnse terms are perfectly acceptable for inclusion in FE. The only question that remains is what should we call the license? I'll be happy to change the license name in the spec before it gets built and pushed (it was just imported). What would you folks like to call it? Woiuld the SCRIP License be OK? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 15:00 EST --- I don't think it corresponds to any existing license, but I agree that it's certainly free enough. (Item 4 of the Open Source Definition allows requiring the marking or renaming of derivative works.) Are there other packages which use the same license? If not, SCRIP License is probably fine but you'll have to endure the rpmlint warning. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191998] Review Request: scrip -- spherical coordinate interpolation and remapping package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scrip -- spherical coordinate interpolation and remapping package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191998 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 15:42 EST --- Hi Patrice and Jason, thank you for the patch and speedy reviews! I've incorporated almost all of your changes and will, as soon as I get some more free time, add the SCRIP/grids and namelist files. The package built successfully on devel and FC-4/5 branches have been requested. Thanks again! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
