[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/show_bug.cgi?id=192119 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-06-07 04:52 EST --- Imported Build, closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 --- Additional Comments From [EMAIL PROTECTED] 2006-06-06 07:35 EST --- I just got permission to use the planetpenguin racer logo. I've added this to images-legal.txt . So AFAIK that fixes the last blocker. Wart can you check this and approve please? : Spec URL: http://people.atrpms.net/~hdegoede/tuxkart.spec SRPM URL: http://people.atrpms.net/~hdegoede/tuxkart-0.4.0-4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 --- Additional Comments From [EMAIL PROTECTED] 2006-06-05 04:34 EST --- libGL-devel should be required by plib-devel as the plib includes #include GL/gl.h . I've committed a new plib version with the correct Requires to CVS and requested a build. About the other 3, the configure script in gnukart unnecesarry adds these 3 to the linking cmdline, they aren't used. It also unnecesarry adds -lICE and -lSM . Here is a new version with a small patch which stops configure from doing this, this takes 4 libs out of the ldd output for the tuxkart binary, reducing deps and startup time. Spec URL: http://people.atrpms.net/~hdegoede/tuxkart.spec SRPM URL: http://people.atrpms.net/~hdegoede/tuxkart-0.4.0-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 --- Additional Comments From [EMAIL PROTECTED] 2006-06-04 16:25 EST --- Now that I've tried building on devel with the new plib, I found a few missing BuildRequires: libGL-devel libXi-devel libXext-devel libXmu-devel -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 Bug 192119 depends on bug 192086, which changed state. Bug 192086 Summary: PATCH: (proper) fullscreen support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192086 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 13:01 EST --- Ignore my previous build failure on devel. I had mangled my plib package. Here's a formal review: MUST * rpmlint output clean * Package named appropriately * Spec file legible and in Am. English * Builds and packages on FC-4 x86_64 * Source matches upstream: e84ab2748ff1ce5ef11d1d7da5188f8f tuxkart-0.4.0.tar.gz * $RPM_BUILD_ROOT cleaned appropriately * Owns all files that it creates * GPL license ok, license file included * No -devel package needed * No need for -docs subpackage * No shared libaries * Not relocatable * No locale files * .desktop file installed correctly * No duplicate %files MUSTFIX === * BR: ImageMagick doesn't seem to be necessary. * Replace the offending images per comment #3. In reply to comment #4, I think these need to be in a new source tarball so that they aren't in the SRPM either. The SRPMS get distributed just like the binary RPMs, so the same rules should apply to make sure they don't contain questionable material. SHOULD == * aclocal, automake, and autoconf all get run due to inter-build file dependencies. This happens because subdir/Makefile.in all depend on configure.in, which gets patched during %prep. I suggest adding the following at the end of %prep to shave a few seconds off of the build time: touch aclocal.m4 touch */Makefile.in -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 16:44 EST --- Thanks, I'll get back with a new version when I've managed to replace those images. If anyone feels like helping me with that let me know, I'm looking into this but for a pure coder like me this aint easy. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 --- Additional Comments From [EMAIL PROTECTED] 2006-05-19 01:58 EST --- (In reply to comment #4) (In reply to comment #3) images/adverts.rgb: SuSE, Slashdot, Philips, TuxRacer, SourceForge, VA Linux logos, I guess plib could be considered safe ;-) Yes you're correct, good catch. That one needs replacing I'll whip up something new using ok to use logo's like tux and erm tux? Sure ;-). Perhaps just some stylised generic pictures like e.g. a shampoo bottle, a house, ... could be used. images/egypt.rgb: looks like scanned Egyptian drawings Dunno whats the source, but I dare sayt hat the copyright on these has expired, even with the disney copyright extension in place. Well if they're originally Egyptian from ancient times, then yes. If they're something that someone just styled that way, probably not... Point is we can't know it so I'd better play safe. images/geeko_icon.rgb, images/players.rgb: resembles SUSE's geeko mascot, don't know whether this is trademarked Erm, it resembles a lizzard yes, afaik having images that resemble an animal isn't illegal. Calling them Geeko maybe is (I don't know whether SUSE trademarked it and how their trademark rules are). images/lunchbox.rgb: something that looks like a Barbie doll; Yes it looks like a dress up doll, there are many dress up dolls both with a thin and a thick figure as long as it doesn't say Barbie on it or really is a clear picture of one I think this is ok. I thiught copyright as well, it looks like a scan of such a doll's box and usualy that stuff is plastered with copyright notices (although I don't see any copyrightable value in them others might differ). I dunno if upstream is alive, but I will replace them, should I make a new source tarball or is it enough to just not put them in the RPM's (leaving them in the SRPM) ? I don't know, perhaps someone else has an idea. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-05-18 11:00 EST --- Unfortunately tuxkart includes images that (in some cases might, in others clearly) violate trademarks and/or copyright: images/adverts.rgb: SuSE, Slashdot, Philips, TuxRacer, SourceForge, VA Linux logos, I guess plib could be considered safe ;-) images/egypt.rgb: looks like scanned Egyptian drawings images/geeko_icon.rgb, images/players.rgb: resembles SUSE's geeko mascot, don't know whether this is trademarked images/lunchbox.rgb: something that looks like a Barbie doll; images/lunchbox2.rgb: a Pokemon screenshot(?!) images/mnm.rgb: a scanned MM wrap this issue should be resolved IMO for instance by replacing the images (preferrably upstream). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||192086 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-17 17:21 EST --- So far I've had no problems building this with the plib patch. I don't feel like mucking around with my mock build configurations to add a patched plib package, so I'll do a review of this without running mock builds. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192119] Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tuxkart - Kids 3D go-kart racing game featuring Tux
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192119
--- Additional Comments From [EMAIL PROTECTED] 2006-05-18 01:18 EST ---
One last important note which I forgot: you need to add -DXF86VIDMODE to the
CXXFLAGS when compiling plib with this patch, so the new configure line should
become:
%configure CXXFLAGS=%{optflags} -fPIC -DXF86VIDMODE
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
