[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/show_bug.cgi?id=194305 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 11:42 EST --- build success, setting NEXTRELEASE. (thx for reposting lost comments) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-15 20:22 EST --- The only rpmlint warning left is: W: emacs-gtypist no-documentation which can be ignored. Review: * package meets naming and packaging guidelines. emacs-gtypist contains lisp files for emacs only. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 200d42de9a0070866d88116112370f0a gtypist-2.7.tar.bz2 * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint has only ignorable complaints. * final provides and requires are sane: emacs-gtypist-2.7-3.fc6.x86_64.rpm emacs-gtypist = 2.7-3.fc6 = emacs gtypist-2.7-3.fc6.x86_64.rpm gtypist = 2.7-3.fc6 = /bin/sh /sbin/install-info /usr/bin/perl fortune-mod libncurses.so.5()(64bit) perl(Carp) perl(File::Temp) perl(Getopt::Std) perl(strict) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * scriptlets (install-info) are OK. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 10:35 EST --- Adding back in comments lost in the crash: --- Additional Comments From [EMAIL PROTECTED] 2006-06-11 02:51 EST --- Builds fine in mock (x86_64, development). rpmlint complains: W: emacs-gtypist no-documentation Can be ignored. E: gtypist info-dir-file /usr/share/info/dir You must not package this file; it will conflict with what's already on the system. The call to install-info in %post will update the system info directory. You should not use %makeinstall; see http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 10:35 EST --- --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 00:58 EST --- Spec URL: http://gtypist.zing.fastmail.fm/gtypist.spec SRPM URL: http://gtypist.zing.fastmail.fm/gtypist-2.7-3.src.rpm * Mon Jun 12 2006 Zing [EMAIL PROTECTED] - 2.7-3 - do not use makeinstall macro - rm info dir file from buildroot? Could you explain the /usr/share/info/dir error? I don't see that in my i386 builds; Is it a x86-64 build error? Is the above the correct fix? Thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 09:44 EST --- (In reply to comment #3) * Mon Jun 12 2006 Zing [EMAIL PROTECTED] - 2.7-3 - do not use makeinstall macro - rm info dir file from buildroot? Could you explain the /usr/share/info/dir error? I don't see that in my i386 builds; Is it a x86-64 build error? Is the above the correct fix? Whether it gets created or not depends on what's already installed on the build machine. Since the file is not actually wanted in the package, the correct thing to do is indeed to rm -f it at the end of %install. That way it gets deleted if it's made, and there's no error if the file wasn't created in the first place. Many other packages in Extras use the same approach. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 00:58 EST --- Spec URL: http://gtypist.zing.fastmail.fm/gtypist.spec SRPM URL: http://gtypist.zing.fastmail.fm/gtypist-2.7-3.src.rpm * Mon Jun 12 2006 Zing [EMAIL PROTECTED] - 2.7-3 - do not use makeinstall macro - rm info dir file from buildroot? Could you explain the /usr/share/info/dir error? I don't see that in my i386 builds; Is it a x86-64 build error? Is the above the correct fix? Thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194305] Review Request: gtypist - GNU typing tutor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtypist - GNU typing tutor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194305 --- Additional Comments From [EMAIL PROTECTED] 2006-06-07 18:48 EST --- Spec URL: http://gtypist.zing.fastmail.fm/gtypist.spec SRPM URL: http://gtypist.zing.fastmail.fm/gtypist-2.7-2.src.rpm * Wed Jun 7 2006 Zing [EMAIL PROTECTED] - 2.7-2 - add preun pkg check before running install-info -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
