[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gfs2-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO_REPORTER |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2006-06-13 12:16 EST --- Ok, fixed that changelog entry. I'm not sure what needs to go into anaconda or comps. This package should be installed when GFS was installed in fc5. The GFS kernel module is included in the fc6 kernel, and to use GFS you'll need this packages, so I'm not sure where it should be installed by default. New SRPM: http://people.redhat.com/cfeist/gfs2-utils-0.1.0-1.fc6.3.src.rpm New SpecFile: http://people.redhat.com/cfeist/gfs2-utils.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gfs2-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |NEEDINFO_REPORTER
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|188265 |188267
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-06-12 12:48 EST ---
NEEDSWORK:
- Buildroot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Please use lowercase for 'fc6' as that will match what is done in Extras (and
soon Core) with the %{?dist} tag.
- No URL tag
- ./configure --kernel_src=/home/msp/cfeist/gfs2/gfs2-2.6 Likely to fail in
buildsystems.
Indeed, fails to build:
make[1]: Entering directory `/builddir/build/BUILD/gfs2-utils-0.1.0/gfs2/edit'
gcc -Wall -I../include -I../config -I../libgfs2 -I//usr/include -ggdb
-DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64 -DGFS2_RELEASE_NAME=\0.1.0\
-I../include -I../config -I../libgfs2 -I//usr/include -L../libgfs2/ gfs2hex.c
hexedit.c -lncurses -o gfs2_edit -lgfs2
gfs2hex.c:24:20: error: curses.h: No such file or directory
Also, rpmlint didn't like the srpm:
E: gfs2-utils configure-without-libdir-spec
E: gfs2-utils configure-without-libdir-spec
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gfs2-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEEDINFO_REPORTER |ASSIGNED
--- Additional Comments From [EMAIL PROTECTED] 2006-06-12 14:59 EST ---
- Fixed the buildroot
- Added changed FC6 to fc6.
- Added the URL tag
- That kernel src line was required because we didn't have the necessary headers
in fc6 kern headers package.
- Added ncurses as a requirement ncurses-devel as a build requirement
I've also added --libdir=%{_libdir} to both configure lines so the libs will go
in the correct place on 64 bit archs.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gfs2-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888 --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 15:01 EST --- Also, new location of the srpm is: http://people.redhat.com/cfeist/gfs2-utils-0.1.0-1.fc6.1.src.rpm Spec file is at the same location: http://people.redhat.com/cfeist/gfs2-utils.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gfs2-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO_REPORTER --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 16:29 EST --- Ok, rpmlint output: W: gfs2-utils incoherent-version-in-changelog 0.1.0-0.FC6.1 0.1.0-1.fc6.1 - Should fix. W: gfs2-utils service-default-enabled /etc/rc.d/init.d/gfs2 - We really don't want this on by default do we? W: gfs2-utils incoherent-init-script-name gfs2 - Can ignore. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gfs2-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO_REPORTER |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 17:13 EST --- - Fixed changelog - Fixed gfs2 service is not enabled by default. New SRPM http://people.redhat.com/cfeist/gfs2-utils-0.1.0-1.fc6.2.src.rpm New Spec file http://people.redhat.com/cfeist/gfs2-utils.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194888] Review Request: gfs2-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gfs2-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194888 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO_REPORTER OtherBugsDependingO|188267 |188268 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-12 22:27 EST --- Ok, fix the changelog entry to match the release and we're good. APPROVED. Just need Bill's go ahead to add to the collection, and then let us know whatever needs to happen for Anaconda and/or comps. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
