[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/show_bug.cgi?id=195585 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 [EMAIL PROTECTED] changed: What|Removed |Added Component|tetex-fontools |Package Review --- Additional Comments From [EMAIL PROTECTED] 2007-01-03 07:33 EST --- The component field for package reviews must stay to Package Review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 --- Additional Comments From [EMAIL PROTECTED] 2006-06-21 02:52 EST --- Thanks for your comments. They are applied into http://ivrix.org.il/redhat/tetex-fonts-hebrew-0.1-5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-21 11:05 EST --- OK, everything looks good now. The summary is more descriptive and there are no longer any unowned directories. As those were the only outstanding issues, this package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 [EMAIL PROTECTED] changed: What|Removed |Added Component|Package Review |tetex-fontools --- Additional Comments From [EMAIL PROTECTED] 2006-06-20 08:21 EST --- I answered my own scriptlet question by stealing the skiptlets of tetex-font-kerkis rpm. Please review http://ivrix.org.il/redhat/tetex-fonts-hebrew-0.1-4.src.rpm istead. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163778 |163776 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-19 06:59 EST --- Above is Not an official review as I'm not yet sponsored -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 --- Additional Comments From [EMAIL PROTECTED] 2006-06-19 15:24 EST --- Package failes to build in mock on x86_64, both FC5 and development. The build fails at: cp: cannot stat `*.tfm': No such file or directory Indeed, there are no .tfm files in the current directory when that is run. This is due to failures in %build: + make ./mkCLMtfm.sh rm: cannot remove `culmus.map': No such file or directory afm2tfm: fatal: afm file `/usr/share/fonts/hebrew/AharoniCLM-Bold.afm' not found. afm2tfm: fatal: afm file `/usr/share/fonts/hebrew/AharoniCLM-Bold.afm' not found. ./mkCLMtfm.sh: line 47: vptovf: command not found ./mkCLMtfm.sh: line 48: vptovf: command not found (repeated for each font). I think you're missing a BuildRequires: tetex. tetex-afm does not pull it in. Adding it lets things build, although I then see a bunch of errors from mkCLMtfm.sh: ./mkCLMtfm.sh rm: cannot remove `culmus.map': No such file or directory afm2tfm: fatal: afm file `/usr/share/fonts/hebrew/AharoniCLM-Bold.afm' not found. afm2tfm: fatal: afm file `/usr/share/fonts/hebrew/AharoniCLM-Bold.afm' not found. afm2tfm: fatal: afm file `/usr/share/fonts/hebrew/AharoniCLM-BoldOblique.afm' not found. afm2tfm: fatal: afm file `/usr/share/fonts/hebrew/AharoniCLM-BoldOblique.afm' not found. (and so on for many files) I think this points to a missing BuildRequires: fonts-hebrew. I still get: ./mkCLMtfm.sh rm: cannot remove `culmus.map': No such file or directory and a bunch of I had to round some hights by X units but it looks like the package builds OK now. (It actually built OK but didn't contain any tfm files without the BR: fonts-hebrew; you might want to add some error-checking somewhere.) I am at a loss to see how this would build at all in mock as stated in a previous comment. Can you verify that you are the upstream for the source tarball? Generally your Source: tag includes a URL to the upstream source, but it's possible that for a package like this the package is the upstream source. I'm going to assume that there is no upstream source here. Once built, rpmlint has this to say: W: tetex-fonts-hebrew incoherent-version-in-changelog 0.1-1 0.1-2.fc6 You don't seem to have added a changelog entry for what went into release 2. W: tetex-fonts-hebrew dangling-symlink /usr/share/texmf/fonts/type1/public/culmus /usr/share/fonts/hebrew W: tetex-fonts-hebrew dangling-symlink /usr/share/texmf/fonts/afm/public/culmus /usr/share/fonts/hebrew Symlinks into packages which are dependencies are OK. W: tetex-fonts-hebrew symlink-should-be-relative /usr/share/texmf/fonts/type1/public/culmus /usr/share/fonts/hebrew W: tetex-fonts-hebrew symlink-should-be-relative /usr/share/texmf/fonts/afm/public/culmus /usr/share/fonts/hebrew Absolute symlinks aren't OK; these should be relative (a blocker). You have various scriptlets which call texhash and updmap-sys but you don't specify appropriate requirements for them: Requires(post): tetex (or /usr/bin/texhash) (updmap-sys comes from tetex-fonts which is a dependency of tetex; it should be OK to leave it out but you're free to be more explicit if you like) Requires(preun): tetex-fonts (or /usr/bin/updmap-sys) (the postun requirement on /usr/bin/texhash is picked up by rpm automatically) This package doesn't seem to own /usr/share/texmf/fonts/tfm/public/culmus and /usr/share/texmf/fonts/vf/public/culmus/, and nothing else in the repository seems to either. (/usr/share/texmf/fonts/tfm/public and /usr/share/texmf/fonts/vf/public are owned by tetex-fonts which is in the dependency tree). Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. O can't compare source against upstream as there is none. O can't compare version agains upstream. O BuildRequires are proper (one amended as above) * package builds in mock (development, x86_64). X rpmlint has valid complaints (see above). * final provides and requires are sane: tetex-fonts-hebrew = 0.1-2.fc6 = /bin/sh /usr/bin/texhash fonts-hebrew tetex * no shared libraries are present. * package is not relocatable. X owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite. X scriptlets present; dependencies are not correct. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files.
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 --- Additional Comments From [EMAIL PROTECTED] 2006-06-19 16:50 EST --- Thanks for the detailed and helpful review. I think you're missing a BuildRequires: tetex. tetex-afm does not pull it in. I think this points to a missing BuildRequires: fonts-hebrew. I still get: Indeed, I implicitly expected that both tetex and fonts-hebrew are there on build time. ./mkCLMtfm.sh rm: cannot remove `culmus.map': No such file or directory I eliminated this error by replacing the rm with a cp of /dev/null and a bunch of I had to round some hights by X units but it looks like the package builds OK now. I don't know what is this LaTeX problem. I hope to have some Hebrew support, it does not have to be flawless. without the BR: fonts-hebrew; you might want to add some error-checking somewhere.) Maybe I should, but I don't know what and how. Checking whether the number of generated files is nonzero sounds very silly... Can you verify that you are the upstream for the source tarball? Generally your Source: tag includes a URL to the upstream source, but it's possible that for a package like this the package is the upstream source. I'm going to assume that there is no upstream source here. Indeed, I am the one packing the tarball. Note however, that this package is a (simple) repackaging of the Culmus fonts for the use of tetex. Once built, rpmlint has this to say: W: tetex-fonts-hebrew incoherent-version-in-changelog 0.1-1 0.1-2.fc6 You don't seem to have added a changelog entry for what went into release 2. You got me. Absolute symlinks aren't OK; these should be relative (a blocker). Should I use ../../share/fonts/hebrew instead? You have various scriptlets which call texhash and updmap-sys but you don't specify appropriate requirements for them: Requires(post): tetex (or /usr/bin/texhash) (updmap-sys comes from tetex-fonts which is a dependency of tetex; it should be OK to leave it out but you're free to be more explicit if you like) Requires(preun): tetex-fonts (or /usr/bin/updmap-sys) (the postun requirement on /usr/bin/texhash is picked up by rpm automatically) I should be RTFMing about it, but are my scriptlets sane? I would like to run texhash after any change to the TeX tree, and updmap-sys if culmus.map is added (or going to be removed). Would you take a look? This package doesn't seem to own /usr/share/texmf/fonts/tfm/public/culmus and /usr/share/texmf/fonts/vf/public/culmus/, and nothing else in the repository seems to either. (/usr/share/texmf/fonts/tfm/public and /usr/share/texmf/fonts/vf/public are owned by tetex-fonts which is in the dependency tree). I hope this is solved by adding the directories explicitly to the file list. Please see the update SRPM at http://ivrix.org.il/redhat/tetex-fonts-hebrew-0.1-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tetex-fonts-hebrew
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||[EMAIL PROTECTED]
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-06-18 07:26 EST ---
Review for this package:-
Mock build for i386 gives no error
MUST Items:
- MUST: rpmlint shows no error
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package tetex-fonts-hebrew, in
the format tetex-fonts-hebrew.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
GPL.
- MUST: The License field GPL, in the package tetex-fonts-hebrew.spec file
is NOT included under %doc section as well NOT in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains %{__rm} -rf
%{buildroot}.
- MUST: This package used macros.
- MUST: Document files are NOT included like README.
SHOULD Items:
- SHOULD: Package should include License file in upstream package.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 10:46 EST --- Parag, if you'reviewing this package, you should assign it to yourself. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 195585] Review Request: tetex-fonts-hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
