[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 --- Additional Comments From [EMAIL PROTECTED] 2006-08-09 02:31 EST --- SPEC: http://www.ece.ucdavis.edu/~ewwork/repo/development/SPECS/gtkdatabox.spec SRPM: http://www.ece.ucdavis.edu/~ewwork/repo/development/SRPMS/gtkdatabox-0.6.0.0-1.fc5.src.rpm Sorry for the delay but here is the updated .spec file and .srpm. I made the requested changes: * add %post/%postun for -devel * added examples/*.c to -devel Also updated to the latest version. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-09 23:22 EST --- Spec file reflects requested changes. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO_REPORTER |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 18:55 EST --- Sorry I don't have FC5 on my machine right now. When I get the time later this week I'll get a build system up and running in VMWare. I will then add the ldconfig lines to my devel package as requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO_REPORTER -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gtkdatabox
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529
--- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:37 EST ---
Not an official review as I'm not yet sponsored
Mock build for development i386 is sucessfull
MUST Items:
- MUST: rpmlint shows no error
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package gtkdatabox, in the
format gtkdatabox.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license
LGPL.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like INSTALL README.
- MUST: Package did NOT contained any .la libtool archives.
- MUST: Header files are going in a -devel package.
- MUST: Files used by pkgconfig (.pc files) are in a -devel package.
- MUST: Library files that end in .so (without suffix) are in a -devel
package.
- MUST: This package contains shared library files located in the dynamic
linker's default paths, and therefore this package is calling ldconfig in %post
and %postun. But Devel package is NOT calling a %post/%postun section that calls
/sbin/ldconfig.
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
* devel package contains the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
What you Need to do:-
* add %post %postun for devel package also to call ldconfig
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 196529] Review Request: gtkdatabox
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkdatabox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196529 --- Additional Comments From [EMAIL PROTECTED] 2006-06-25 23:48 EST --- I guess it sort of makes sense to add the %pre/%post to the devel packages but the guidelines you pasted in say: MUST: This package contains shared library files located in the dynamic linker's default paths, and therefore this package is calling ldconfig in %post and %postun. But Devel package is NOT calling a %post/%postun section that calls /sbin/ldconfig. The last two packages that were approved did not have these, but maybe I should have added them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
