[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981





--- Additional Comments From [EMAIL PROTECTED]  2006-08-09 15:18 EST ---
For the record here is the reply I got from upstream about the 2 different 
versions:
---

Hi,

On Mon, Jul 17, 2006 at 02:07:09PM +0200, Hans de Goede wrote:
> > The one in the core package seems to be newer. I've attached a patch
> > which upgrades the version on your website to this newer version, and
> > thus shows the differences.
> > 
> > Do you know how this is possible?

That's very odd indeed - I have no idea how it happened. However, I
don't use Linux nor GKrellM anymore since I've switched to FreeBSD, so
I wont be making any updates to the sources. You're free to take over
maintaining the plug-in if you'd like.

Regards,
Brix
-- Henrik Brix Andersen <[EMAIL PROTECTED]> 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

Bug 197981 depends on bug 197967, which changed state.

Bug 197967 Summary: Review Request: gkrellm - Multiple stacked system monitors 
in one process
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197967

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



--- Additional Comments From [EMAIL PROTECTED]  2006-07-19 17:56 EST ---
Thanks!

Imported and build, closing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-07-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-17 15:24 EST ---
0.9.12-2 approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-07-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981





--- Additional Comments From [EMAIL PROTECTED]  2006-07-17 07:58 EST ---
(In reply to comment #2)
> Blockers:
> - Tarball is not upstream one, sha1sums:
>   package:  52d13482f7ea71ca0f5613ac5209cbe7d8385f42
>   upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507
>   There are also substantial differences in their contents.

Your right, strange, I took the tarbal straight from the core SRPM, it seems the
 one in core is newer / completer then the upstream one. I've gone back to a
pristine upstream tarbal, with the changes found in the core package in a patch.
I've also mailed upstream for an explanation on the 2 different 0.9.12 versions.

> - Missing dependency on gkrellm.
> - Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package
>   for benefit of folks who rebuild FE packages for example for RHEL.
Both fixed

> - A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS
>   could be easier to maintain than copy-pasting all flags between Makefile
>   and the specfile.

I'm used to doing things like this for non autotooled packages, so I'm keeping
it this way.

New version here:
Spec URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi.spec
SRPM URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi-0.9.12-2.src.rpm

Changes:
* Mon Jul 17 2006 Hans de Goede <[EMAIL PROTECTED]> 0.9.12-2
- Use pristine upstream source and put changes found in the Core package
  tarbal in a patch
- Require gkrellm >= 2.2, gkrellm < 3
- Add ExcludeArch: s390 s390x



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-07-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-16 16:24 EST ---
Blockers:
- Tarball is not upstream one, sha1sums:
  package:  52d13482f7ea71ca0f5613ac5209cbe7d8385f42
  upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507
  There are also substantial differences in their contents.
- Missing dependency on gkrellm.

Other notes/suggestions:

- Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package
  for benefit of folks who rebuild FE packages for example for RHEL.
- A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS
  could be easier to maintain than copy-pasting all flags between Makefile
  and the specfile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||197967




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 197981] Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors

2006-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU 
Krell Monitors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981





--- Additional Comments From [EMAIL PROTECTED]  2006-07-07 16:19 EST ---
Note 2: I'm going on a short vacation from monday 10 juli till friday 14 juli,
so if I'm quiet thats why.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review