[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

2008-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON 
encoder/decoder for Python


https://bugzilla.redhat.com/show_bug.cgi?id=198285


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

2006-08-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON 
encoder/decoder for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198285


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-14 14:00 EST ---
rpmlint still says

E: python-simplejson zero-length
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe

I agree it can be ignored.

Good:
+ sitelib macro
+ source matches
+ license (MIT)
+ mock builds on devel x86_64
+ proper %clean section
+ macro usage throughout
+ noarch

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

2006-08-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON 
encoder/decoder for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198285


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-14 16:06 EST ---
Imported to CVS, added to owners.list, FC-5 branch requested, tagged and built
for devel.  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

2006-07-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON 
encoder/decoder for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198285


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-07-11 18:51 EST ---
I'm not terribly well-versed in Python, but this looks to violate the 
guidelines:

Python packages that use setuptools need to add python-setuptools as a
BuildRequires and must either add --single-version-externally-managed to the
line invoking setup.py in %install, or must add a .pth file containing the path
to the egg or egg directory to %{python_sitelib}.

I don't believe either of those are being done.  In addition:

E: python-simplejson zero-length
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info/zip-safe

In general the packaging here looks odd.  Why is the test suite included in the
installed module, but not called at all by a %check section in the spec?  What
about the contents of
/usr/lib/python2.4/site-packages/simplejson-1.3-py2.4.egg-info?  Shouldn't this
all be %doc, if it must be installed at all?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

2006-07-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON 
encoder/decoder for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198285


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||189338
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198285] Review Request: python-simplejson - Simple, fast, extensible JSON encoder/decoder for Python

2006-07-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simplejson - Simple, fast, extensible JSON 
encoder/decoder for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198285


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|189338  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review