[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835





--- Additional Comments From [EMAIL PROTECTED]  2006-07-15 02:22 EST ---
Ok, I'll concede to use atlascpp for the package name.  Here's an updated
package that I believe fixes all of the MUSTFIX issues:

http://www.kobold.org/~wart/fedora/atlascpp-0.6.0-2.src.rpm
http://www.kobold.org/~wart/fedora/atlascpp.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 12:46 EST ---
I'm concerned about the potential for conflict with the existing atlas package
in Extras:

The ATLAS (Automatically Tuned Linear Algebra Software) project is an
ongoing research effort focusing on applying empirical techniques in
order to provide portable performance. At present, it provides C and
Fortran77 interfaces to a portably efficient BLAS implementation, as
well as a few routines from LAPACK.

The current naming makes this package look like it supplies C++ bindings for 
atlas.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 13:51 EST ---
(In reply to comment #1)
 -rpmlint output:
 W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
 _ZNK5Atlas9Exception4whatEv
...

rpmlint on FC4 x86_64 and FC5 i386 both missed this one.


 === MUST ===
 - Add Requires: pkgconfig to devel package

Done.

 - Comments say test fails on FC6, but infact it is failing on all x86_64 
 arches
 because of an x86_64 warning.  Patch the code to not use -Werror so that 
 checks
 can be run

I think it would be better just to fix the test code and keep the -Werror.  This
might get sent upstream.

 - Fix linking of all the .so files, they should be linked with -lAtlas and
 libAtlas needs to be built first.

I wonder if this is a smp_mflags build 
 - Explain why you do not build with optional zlib or libbz2

Because I didn't notice the configure output?  :)

 - README indicates that this package requires socket streams such as skstream,
 explain why this is not in the Requires

It probably should be.  But since the package that Requires: this one also
Requires: skstream directly, I didn't catch this.

 - Why are man pages in doc/man not installed?

Oversight.  I've added most of them.  Others are not included as they contain
the build root path in the man page name (probably some doxygen artifact)

 - Should tutoral/ be installed?

No.  These are doxygen sources.  The tutorial is included in %doc doc/html

 - Fix license to match actual license

Fixed.

 - Fix Source0 URL so that I can actually verify the upstream source is 0.6.0
 actually out yet?

Works for me?

 - Why name Atlas-C++ instead of atlascpp?

Because even though upstream uses both Atlas-C++ and atlas-cpp, the former best
matches the actual tarball name.

I'll post a new srpm once the tests have been fixed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 14:26 EST ---
(In reply to comment #1)
 -rpmlint output:
 W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0

Which dist and version of rpmlint (rpm -q rpmlint) are you running that produced
this warning?  I can't reproduce it on FC4-x86_64 or FC5-i386.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 14:30 EST ---
(In reply to comment #2)
 I'm concerned about the potential for conflict with the existing atlas package
 in Extras:
...
 
 The current naming makes this package look like it supplies C++ bindings for
atlas.

Upstream's name is unfortunate in this sense, but I think it's better to
preserve upstream's naming than to change it to something different.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||198837
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
  Alias||Atlas-C++




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835





--- Additional Comments From [EMAIL PROTECTED]  2006-07-13 22:19 EST ---
-rpmlint output:
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZNK5Atlas9Exception4whatEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZTIN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZTVN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11streamBeginEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase13streamMessageEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase9streamEndEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase10mapMapItemERKSs
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11mapListItemERKSs
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase10mapIntItemERKSsl
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase12mapFloatItemERKSsd
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase13mapStringItemERKSsS3_
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase6mapEndEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11listMapItemEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase12listListItemEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase11listIntItemEl
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase13listFloatItemEd
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase14listStringItemERKSs
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBase7listEndEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZTIN5Atlas7Message11DecoderBaseE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBaseC2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7ElementC1ERKS1_
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message11DecoderBaseD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7Element5clearENS1_4TypeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7Encoder14mapElementItemERKSsRKNS0_7ElementE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7EncoderD1Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7ElementaSERKS1_
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas6Codecs3XMLC1ERSdRNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas7Message7EncoderC1ERNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0
_ZN5Atlas9ExceptionD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZTIN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZNK5Atlas9Exception4whatEv
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZTIN5Atlas6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZTVN5Atlas9ExceptionE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZN5Atlas6BridgeD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasMessage-0.6.so.1.0.0
_ZN5Atlas9ExceptionD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZTIN5Atlas9NegotiateE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZTIN5Atlas6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas9NegotiateD2Ev
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas6Codecs6PackedC1ERSdRNS_6BridgeE
W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasNet-0.6.so.1.0.0
_ZN5Atlas6Codecs4BachC1ERSdRNS_6BridgeE

[Bug 198835] Review Request: Atlas-C++ - WorldForge message protocol library

2006-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Atlas-C++ - WorldForge message protocol library
Alias: Atlas-C++

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review