[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-09-04 13:30 EST --- Closing it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-08-22 08:45 EST --- Don't forget to close this bug once you've imported and submitted a build. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 15:28 EST --- Fair enough, game on. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 16:04 EST --- Michal, the package looks in pretty good shape, now for some testing... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 16:08 EST --- Why have you added FE-NEEDSPONSOR block? I'm already sponsored and I'm owner of kadu and python-mutagen packages. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 16:32 EST --- Because I'm lame and read comment #1 that said you were looking for a sponsor, and *assumed*... (: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 16:39 EST --- (In reply to comment #23) Because I'm lame and read comment #1 that said you were looking for a sponsor, and *assumed*... (: Never mind ;) So, what with approvement this package to extras? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 16:54 EST --- looks good, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 05:57 EST --- New URLs: Spec URL: http://ecik.zspswidwin.pl/kooldock/kooldock.spec SRPM URL: http://ecik.zspswidwin.pl/kooldock/kooldock-0.3-2.20060720cvs.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:03 EST --- I can review this... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:06 EST --- Grr. http://ktown.kde.cl/kooldock/ seems unreachable atm, I'll try again later. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kooldock - dock for KDE with great visual effects and
enhancements
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627
--- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:19 EST ---
1. %prep: the rm should come *after* the %setup, else, there's nothing
there/unpackage yet to delete.
2. drop hard-coded
Requires: kdelibs
3. If this is a cvs snapshot prerelease, Release tag should be prefixed with
0. so use something like this instead:
Release: 0.2.%{cvs_date}cvs%{?dist}
4. The bit in %build
export QTLIB...
isn't needed anymore to workaround qt bug(s). The bugs have been fixed.
5. Drop
%doc INSTALL
no need for INSTALL instructions here. (:
6. Since you're installing icons, you should include scriptlets:
%post
touch --no-create %{_datadir}/icons/crystalsvg || :
%postun
touch --no-create %{_datadir}/icons/crystalsvg || :
7. You probably ought to change
%defattr(0644,root,root,0755)
to
%defattr(-,root,root,-)
then you won't need the %attr bits for:
%attr(0755,root,root)%{_bindir}/*
8. Upstream source. If you're going to be using a cvs checkout, please provide
a script to (re)generate said source tarball.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:20 EST --- Well, I don't think this site will be available at any time. It looks dead for a long time. Then I suggest you find a better/working site use for URL: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kooldock - dock for KDE with great visual effects and
enhancements
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627
--- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:33 EST ---
(In reply to comment #11)
3. If this is a cvs snapshot prerelease, Release tag should be prefixed with
0. so use something like this instead:
Release: 0.2.%{cvs_date}cvs%{?dist}
This is POSTrelease.
8. Upstream source. If you're going to be using a cvs checkout, please
provide
a script to (re)generate said source tarball.
Could you explain me what do you exactly mean?
URLs:
SPEC URL: http://ecik.zspswidwin.pl/kooldock/kooldock.spec
SRPM URL: http://ecik.zspswidwin.pl/kooldock/kooldock-0.3-3.20060720cvs.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kooldock - dock for KDE with great visual effects and
enhancements
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627
--- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:37 EST ---
This is POSTrelease.
Then never mind, no need to use a 0. prefex.
a script to (re)generate said source tarball.
Could you explain me what do you exactly mean?
Include
Source1: kooldock-cvs_checkout.sh
that contains (something like):
--
#!/bin/bash
MODULE=$(basename $0 -cvs_checkout.sh)
DATE=$(date +%Y%m%d)
set -x
rm -rf $MODULE
cvs -z3 -d:pserver:[EMAIL PROTECTED]:/cvsroot/$MODULE co
-P $MODULE
tar cjf $MODULE-${DATE}cvs.tar.bz2 $MODULE
rm -rf $MODULE
--
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:41 EST --- There is no need to it. As I wrote in my first comment, project is dead and will never be continued. The last change in CVS is two years old. I have done one cvs snapshot on my server and this is enough. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163778 |163776 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 08:48 EST --- As I wrote in my first comment, project is dead and will never be continued. My bad for missing that, sorry. With upstream project being dead, it's ill-advised to bring this into Extras. I'm not willing to approve this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-07-26 09:40 EST --- (In reply to comment #18) Then the solution is obvious, you should become the upstream source maintainer for this package. I am. I've done my own cvs snapshot and this package uses it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 --- Additional Comments From [EMAIL PROTECTED] 2006-07-21 16:57 EST --- BTW, the package builds cleanly on FC5 and rpmlint gives no errors for the rpm. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199627] Review Request: kooldock - dock for KDE with great visual effects and enhancements
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kooldock - dock for KDE with great visual effects and enhancements https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199627 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
