[Bug 200665] Review Request: ltris

2006-09-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||201449
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG




--- Additional Comments From [EMAIL PROTECTED]  2006-09-16 16:32 EST ---
Sorry. Due to my stepping out for a while, I am unable to complete this 
submission.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163776  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665





--- Additional Comments From [EMAIL PROTECTED]  2006-07-31 02:01 EST ---
(In reply to comment #7)
 _localstatedir defines where the scoreboard gets put.

I see.  Instead of redefining _localstatedir, it would be better just to add
--localstatedir /var/games/%{name} at the end of %configure, instead of
redefining a standard rpm variable which might have unforseen side effects
(though it doesn't seem to in this case).



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-07-30 11:51 EST ---
Hi Michael,

I haven't tried your package, but are you sure you need to run the
'gtk-update-icon-cache' scriptlet? LTris doesn't install icons into
%{_datadir}/icons/hicolor.

Please correct me if I'm mistaken ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665





--- Additional Comments From [EMAIL PROTECTED]  2006-07-30 15:34 EST ---
no, you are quiet right. 

fixed

Spec URL: http://www.knox.net.nz/~michael/ltris.spec
SRPM URL: http://www.knox.net.nz/~michael/ltris-1.0.11-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665





--- Additional Comments From [EMAIL PROTECTED]  2006-07-30 15:46 EST ---
According to http://fedoraproject.org/wiki/Extras/SIGs/Games you should
package data files and game files separately. Please read whole site and
make necessary changes required by Games Packaging Guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665





--- Additional Comments From [EMAIL PROTECTED]  2006-07-30 16:06 EST ---
The SIG guide states if possible not must. ltris is less than half a meg in
total size. The idea behind splitting the packages, to reduce size, is not
really a concern here IMHO. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665





--- Additional Comments From [EMAIL PROTECTED]  2006-07-30 16:51 EST ---
SIG guide also states that this should be done even if upstream uses one
tarball for game source and data. But for ltris you're probably right.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 200665] Review Request: ltris

2006-07-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665





--- Additional Comments From [EMAIL PROTECTED]  2006-07-31 01:38 EST ---
_localstatedir defines where the scoreboard gets put. I will see how much work
is need to make the scoreboard private to each user. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review