[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 [EMAIL PROTECTED] changed: What|Removed |Added Version|fc5 |devel --- Additional Comments From [EMAIL PROTECTED] 2006-08-18 02:43 EST --- Add COPYING Changelog to %doc Use Dist Tag The New files: Spec URL: http://cle.linux.org.tw/candyz/gcin.spec SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-3.src.rpm The mock build cleanly on my machine. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 03:31 EST --- (In reply to comment #14) Spec URL: http://cle.linux.org.tw/candyz/gcin.spec SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.1-7.src.rpm These seem OK for i386. Build is fine, rpmlint is clean, debuginfo is correct (this time it is really okay) and these seems to work well on i386. However, I only have i386 machine so I cannot check this on x86_64. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 12:35 EST --- The -7 package still fails for me on x86_64: RPM build errors: File not found by glob: /var/tmp/gcin-1.2.1-7-root-mockbuild/usr/lib64/menu/gcin* File not found: /var/tmp/gcin-1.2.1-7-root-mockbuild/usr/lib64/gtk-2.0/immodules/im-gcin.so File not found: /var/tmp/gcin-1.2.1-7-root-mockbuild/usr/lib64/qt-3.3/plugins/inputmethods/libqgcin.so File not found: /var/tmp/gcin-1.2.1-7-root-mockbuild/usr/lib64/gcin/libgcin-im-client.so Error building package from gcin-1.2.1-7.src.rpm, See build log -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 12:52 EST --- (In reply to comment #16) The -7 package still fails for me on x86_64: Dear Jason; What does your full build log on x86_64 say? Perhaps a full build log will be useful. I cannot very this package other than on i386. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 13:31 EST --- Created an attachment (id=134397) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134397action=view) Log from failing x86_64 build of gcin-1.2.1-7 in mock -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 21:12 EST --- Again, the new file: Spec URL: http://cle.linux.org.tw/candyz/gcin.spec SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-2.src.rpm i386 mock builds cleanly Hope the x86_64 problems will be fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-17 21:55 EST --- I use mock to build i386 and x86_64 and ppc version for FC5, and all those builds are cleanly. Also, I use mock to build it for FC4, and the builds are cleanly, too. But I use my i386 machine to build all those, so I don't know will it builds cleanly on x86_64 machines. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional
Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-08-18 00:22 EST ---
1.2.2-2 does indeed build on x86_64 and rpmlint is quiet to boot.
Note that I haven't signed on to review this package, but since I have the build
logs in front of me I'll check a few things.
You don't use the %{?dist} tag. It's not required but it does make maintenance
across multiple releases much easier and you should probably use it unless you
know that you don't want to. See
http://fedoraproject.org/wiki/Packaging/DistTag for more information.
You must include the COPYING file in %doc. You should also consider including
ChangeLog, and putting README in the main package instead of the -devel
subpackage if it includes any end-user documentation. (I am not capable of
reading it so I can't tell.
The configure script isn't a regular configure script, so I'm not sure it's
productive to call it with the %configure macro, which will call configure with
many flags that it doesn't seem to understand.
It looks like the Makefile ignores CFLAGS, so the compiler is not called with
the proper set of flags. I think you will need to patch the makefile, or
perhaps the generated config.mak. I added the following hack to the end of
%prep:
perl -pi -e s/^(OPTFLAGS.*=)/\1 %{optflags} / config.mak
and it does get the right flags passed to the compiler, but it also causes the
build to fail on my 8CPU machine unless I disable parallel make. I have no idea
why. I have a suspicion it has something to do with the -pipe option.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional
Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
--- Additional Comments From [EMAIL PROTECTED] 2006-08-18 01:14 EST ---
I add the COPYING and Changlog to %dco and remove README from -devel subpackage.
I also remove the configure script. (It is no use)
I add perl -pi -e s/^(OPTFLAGS.*=)/\1 %{optflags} / config.mak after
%configure, then I build fail on my
SMP machine, too.
I disable parallel make then it build success.
Now, I am reading the DistTag Document, and I will try to use the %{?dist} tag.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional
Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-08-16 04:17 EST ---
Hello.
Again I have to mention that I cannot sponsor you formally
because I am not a member of sponsors.
You may ask on fedora-extras mailing lists for someone to
sponsor you.
I see lots of rpmlint complaints were removed.
mock builds cleanly.
Then:
* rpmlint:
gcin-1.2.1-3.i386.rpm:
E: gcin script-without-shellbang /etc/X11/xinit/xinput.d/gcin
--- I suspect the permission of /etc/X11/xinit/xinput.d/gcin
can be 0644 (see /etc/X11/xinit/xinput.d/scim.conf in scim).
gcin-1.2.1-3.src.rpm:
W: gcin strange-permission gcin 0755
--- change the permission of gcin (source 1) to 0644
gcin-debuginfo-1.2.1-3.i386.rpm:
gcin-devel-1.2.1-3.i386.rpm:
W: gcin-devel no-soname /usr/lib/libgcin-im-client.so
--- This is unwilling, however, this is a problem of this
package, not your packaging. You may tell upstream that
a proper soname should be added or you can add a soname
by yourself for a moment.
By the way, can this file be in devel package, not in
main package? (I don't know well about gcin..)
* debuginfo rpm is of no use.
This is because this package
A. does not accept CFLAGS. i.e. This package is not built with
debug option -g. Overwrite OPTFLAGS like
-
in %build stage:
make OPTFLAGS=${RPM_OPT_FLAGS} %{?_smp_mflags}
-
B. This package strips binaries, which is not accepted for fedora
packages. Fix makefile not to strip binaries, like
-
in %prep stage:
sed -i.strip -e 's|install[ \t][ \t]*-s|install|' Makefile
-
With fix by A and B: rpmlint complains:
W: gcin non-conffile-in-etc /etc/X11/xinit/xinput.d/gcin
-- can be ignored, I think
W: gcin-devel no-soname /usr/lib/libgcin-im-client.so
-- you may ask upstream to fix this.
E: gcin-devel shlib-with-non-pic-code /usr/lib/libgcin-im-client.so
-- I don't know well about shared libraries, however, this
error means:
The listed shared libraries contain object code that was compiled
without -fPIC. All object code in shared libraries should be
recompiled separately from the static libraries with the -fPIC option.
Another common mistake that causes this problem is linking with
``gcc -Wl,-shared'' instead of ``gcc -shared''.
--- libgcin-im-client.so is made by gcin-im-client.o im-addr.o gcin-conf.o
util.o gcin-crypt.o and actually gcin-crypt.o is not compiled with
-fpic. gcin-crypt.o is used to make another binary and in this case,
gcin-crypt.o should be compiled without -fpic. So I think gcin-crypt.c
must be compiled twice with different ways. Fix this.
For example:
-
--- gcin-1.2.1/im-client/Makefile.orig 2006-05-01 18:57:43.0 +0900
+++ gcin-1.2.1/im-client/Makefile 2006-08-16 16:55:01.0 +0900
@@ -6,7 +6,7 @@
-DCLIENT_LIB=1 -DGCIN_BIN_DIR=\$(GCIN_BIN_DIR)\ \
-DDEBUG=0$(GCIN_DEBUG) -DGCIN_TABLE_DIR=\$(GCIN_TABLE_DIR)\ \
-DFREEBSD=$(FREEBSD)
-OBJS = gcin-im-client.o im-addr.o gcin-conf.o util.o gcin-crypt.o
+OBJS = gcin-im-client.o im-addr.o gcin-conf.o util.o gcin-crypt-fpic.o
.c.E:
$(CC) $(CFLAGS) -E -o $@ $
@@ -43,6 +43,9 @@
im-addr.o: ../im-srv/im-addr.c
$(CC) -c -fpic $(CFLAGS) -o $@ $
+gcin-crypt-fpic.o: gcin-crypt.c
+ $(CC) -c -fpic $(CFLAGS) -o $@ $
+
clean:
rm -f *.o *.so *~ *.E *.db config.mak tags core.* .depend
---
E: gcin-debuginfo script-without-shellbang
/usr/src/debug/gcin-1.2.1/IMdkit/include/IMdkit.h
E: gcin-debuginfo script-without-shellbang
/usr/src/debug/gcin-1.2.1/IMdkit/include/Xi18n.h
E: gcin-debuginfo script-without-shellbang
/usr/src/debug/gcin-1.2.1/IMdkit/include/XimProto.h
--- fix this with:
---
in %prep stage:
find . -name \*.h -o -name \*.c | xargs chmod ugo-x
---
* %post and %postun
Require something to execute %post (and %postun) properly.
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 04:34 EST --- Other issues I noticed now: * /usr/lib/menu/ : this directory is not owned by other packages. So this package should own this directory. * gcin (main) package requires libgcin-im-client.so, so this library should be in main package, not in devel. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional
Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
--- Additional Comments From [EMAIL PROTECTED] 2006-08-16 13:01 EST ---
Created an attachment (id=134326)
-- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134326action=view)
build log of gcin-1.2.1-4 in mock
Again I have to mention that I cannot sponsor you formally
because I am not a member of sponsors.
You may ask on fedora-extras mailing lists for someone to
sponsor you.
Well,
* rpmlint is clean.
* debuginfo rpm is created correctly.
I think now you may well ask for someone
to sponsor you because I cannot sponsor you and I cannot approve
your package.
2 points:
* I cannot check this other than on i386 machine (because
I only have i386 machine), however,
on x86_64, libraries may be installed on /usr/lib64. You may
have to configure gcin-i386.conf and also change its name
according to architecture (for example, by using %{_arch} ).
For example, qt-3.3.6-12.x86_64 has qt-x86_64.conf with entry
/usr/lib64/qt-3.3/lib.
* I cannot build this in mock (local build okay).
Perhaps qt-devel or so is missing for BR? Please check my build log
attached.
Again, I only tested packaging issues.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 13:30 EST --- Well, qt-devel seems sufficient for missing buildrequires. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 13:40 EST --- Oops!! * debuginfo rpm is created correctly. Well, no. It is not. debuginfo contains no debug information. Build log shows: gcc -Wall -O -I/usr/include/gtk-2.0 .. This means that codes are compiled with no debug option (-g). You must change the optional flag of compilation so that gcc is called with $RPM_OPT_FLAGS . You can see from my build log that $RPM_OPT_FLAGS are not used in compilation. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 19:20 EST --- I fixed all above problems. New files: Spec URL: http://cle.linux.org.tw/candyz/gcin.spec SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.1-5.src.rpm I only have i386 machine (no x86_64 machine), Tasaka can you help me to test it? If all is right, then I may start to ask for someone to sponsor me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional
Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
--- Additional Comments From [EMAIL PROTECTED] 2006-08-16 22:43 EST ---
Build failed on devel x86_64.
RPM build errors:
File not found by glob:
/var/tmp/gcin-1.2.1-5-root-mockbuild/usr/lib64/menu/gcin*
File not found:
/var/tmp/gcin-1.2.1-5-root-mockbuild/usr/lib64/gtk-2.0/immodules/im-gcin.so
File not found:
/var/tmp/gcin-1.2.1-5-root-mockbuild/usr/lib64/qt-3.3/plugins/inputmethods/libqgcin.so
File not found:
/var/tmp/gcin-1.2.1-5-root-mockbuild/usr/lib64/gcin/libgcin-im-client.so
As you might guess this is not getting libdir set correctly. From looking at the
custom configure script I believe you can just do %configure libdir=%{_libdir}
in your spec.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 23:30 EST --- I update it for lib64 problems. New files: Spec URL: http://cle.linux.org.tw/candyz/gcin.spec SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.1-6.src.rpm John Mahowald can you help me to build it on x86_64 again and see if it still failure? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 23:41 EST --- %configure should set libdir automatically (in this case, the macro includes --libdir=/usr/lib64), but some things still ignore it. In any case, I grabbed and build -6 and now the build doesn't complete. It gets down to the qt bit and fails: gmake[3]: Entering directory `/builddir/build/BUILD/gcin-1.2.1/qt-im' /usr/lib/qt-3.3/bin/moc qgcininputcontextplugin.h -o qgcininputcontextplugin.h_moc.cpp gmake[3]: /usr/lib/qt-3.3/bin/moc: Command not found gmake[3]: *** [qgcininputcontextplugin.o] Error 127 I've no idea what's happening. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||163776 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 --- Additional Comments From [EMAIL PROTECTED] 2006-08-16 00:26 EST --- I have fixed some rpmlint problems. The new Spec URL: http://cle.linux.org.tw/candyz/gcin.spec SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.1-3.src.rpm I still have problems, but I don't know how to solve it. E: gcin script-without-shellbang /etc/X11/xinit/xinput.d/gcin This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. W: gcin-devel no-soname /usr/lib/libgcin-im-client.so -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gcin - Chinese input method server for Traditional
Chinese
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337
--- Additional Comments From [EMAIL PROTECTED] 2006-08-14 04:11 EST ---
Hello.
===
I cannot sponsor you formally because I do not have a member
of sponsors. You may ask someone to review you on fedora-extras
mailing list, for example.
===
However, I do a kind of pre-review of your package.
Note: my review cannot be a formal review.
First, please read http://fedoraproject.org/wiki/Packaging/Guidelines .
Then:
* rpmlint is not silent. Fix below unless you have a opinion not
to do so.
gcin-1.2.1-2.i386.rpm:
W: gcin summary-not-capitalized gcin - Chinese input method server
W: gcin no-version-in-last-changelog
W: gcin no-soname /usr/lib/libgcin-im-client.so
E: gcin script-without-shellbang /etc/X11/xinit/xinput.d/gcin
W: gcin devel-file-in-non-devel-package /usr/include/gcin-im-client.h
gcin-1.2.1-2.src.rpm:
W: gcin summary-not-capitalized gcin - Chinese input method server
E: gcin unknown-key GPG#476a8659
W: gcin hardcoded-packager-tag Chung-Yen
W: gcin setup-not-quiet
E: gcin use-of-RPM_SOURCE_DIR
W: gcin mixed-use-of-spaces-and-tabs
gcin-debuginfo-1.2.1-2.i386.rpm:
W: gcin-debuginfo no-version-in-last-changelog
* This package doesn't be rebuilt in mock. Check the missing BuildRequires.
In mock, this build of this package shows:
gmake[2]: Entering directory `/builddir/build/BUILD/gcin-1.2.1'
gcc -o gcin gcin.o eve.o win0.o pho.o tsin.o win1.o util.o pho-util.o
gcin-conf.o tsin-util.o win-sym.o intcode.o pho-sy
m.o win-int.o win-pho.o gcin-settings.o table-update.o win-gtab.o gtab.o
gtab-util.o phrase.o win-inmd-switch.o pho-dbg.o
locale.o win-pho-near.o gcin-switch.o win-status.o IC.o IMdkit/lib/libXimd.a
im-srv/im-srv.a -lXtst -L/lib -lgtk-x11-2.0
-lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0
-lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lgli
b-2.0 -L/usr/X11R6/lib
/usr/bin/ld: cannot find -lXtst
collect2: ld returned 1 exit status
gmake[2]: *** [gcin] Error 1
* Commands needed for %post and so on which are in the paths normal
users don't use (such as /usr/sbin) must be used with full path.
* Why does this package have the definition of %prefix or %Docdir ?
I strongly suspect this is not necessary. Especially, unless you have a
reason that this package can be relocatable, removing %prefix is
necessary.
* Check files which this package should have. I suspect that this
package should own %{_datadir}/gcin/ .
* Check %Require. Is a explicit requirement of gtk2 is necessary?
* Don't use Packager. Fedora buildsys overrides it.
* The format of BuildRoot is not preferred. Especially, why use
%{_builddir}, not %{_tmppath}?
* Perhaps the description of Group is not proper.
* Using of %makeinstall is now discouraged.
* debuginfo rpm includes no files. Perhaps binaries in this package
is stripped in build or install stages, which is incorrect and needs
fixing.
* Use macro, instead of using /etc and so on.
* Don't use $RPM_SOURCE_DIR, use %SOURCE?? so that we can check where
the sources is used easier.
* Specify the location of %Source0 by URL, not by only the filename.
Note: I didn't check this package by using this. I only checked
packaging issue.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |fc5 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201337] Review Request: gcin - Chinese input method server for Traditional Chinese
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
