[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/show_bug.cgi?id=201417 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 --- Additional Comments From [EMAIL PROTECTED] 2006-10-07 07:08 EST --- W: alleyoop conffile-without-noreplace-flag /etc/gconf/schemas/alleyoop.schemas Should this be marked (noreplace)? It's not a config file and hence shouldn't be marked as %config. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 --- Additional Comments From [EMAIL PROTECTED] 2006-10-07 12:00 EST --- (In reply to comment #9) W: alleyoop conffile-without-noreplace-flag /etc/gconf/schemas/alleyoop.schemas Should this be marked (noreplace)? It's not a config file and hence shouldn't be marked as %config. It makes sense. I am not sure why I assumed _everything_ under /etc had to be marked %config... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 10:48 EST --- (In reply to comment #5) 1. The desktop file has Version=0.9.0. Should that be Version=0.9.3 ? Done. I'm not sure about the purpose of this field, though... 2. You are using %makeinstall. Can you switch to 'make DESTDIR=... ? Done. 3. Why %defattr(-,root,root,0755) instead of just %defattr(-,root,root,-). Do some of the installed dirs get the wrong permissions? This and the previous point was inherited from the original spec, so I'm not sure why it was that way. Changed 4. Your desktop install should add: --add-category X-Fedora Done 5. Doesn't build in mock. I get this at the end of build.log: configure: error: *** libiberty required to build Alleyoop. error: Bad exit status from /var/tmp/rpm-tmp.34937 (%build) Missing BuildRequires: binutils-devel? Done 6. Adding the BuildRequires from point 5, the package builds and rpmlint says: W: alleyoop conffile-without-noreplace-flag /etc/gconf/schemas/alleyoop.schemas Should this be marked (noreplace)? I asked for this info in #fedora-extras before, and I was told to leave it this way: e.g an update should also overwrite the schema. However, the full rationale for this is not clear to me W: alleyoop macro-in-%changelog description W: alleyoop macro-in-%changelog postun In changelog's you need to use %% to refer to a macro, or rpm will expand them. Done New spec and srpms at: http://giallu.interfree.it/fedora/alleyoop.spec http://giallu.interfree.it/fedora/alleyoop-0.9.3-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 13:13 EST --- 1. Ah, thats the version of the desktop file spec that the spec obeys: Version of the Desktop Entry Specification that the desktop entry conforms with. I guess change that back to 0.9.0 since that was likely the version it was written against. 2-5. All ok. 6. Yeah, makes sense to just leave it. Users are unlikely to change schema files, and you want new schema files to be there on upgrades. If you could change the desktop Version= back before you import it, that would be great. This package is APPROVED. Don't forget to close this bug NEXTRELEASE once it's been imported and built. Also, consider doing a review of another package awaiting review to help out. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 18:36 EST --- Imported and built from -devel. FC5 branch will follow. Thanks a lot for the review (I will try to do some myself, though time is my biggest enemy...) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-10-01 19:15 EST --- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License(GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b3a4703f60448c30122ca55fd00d1c0f alleyoop-0.9.3.tar.gz b3a4703f60448c30122ca55fd00d1c0f alleyoop-0.9.3.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - Package needs ExcludeArch See below - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. see below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. See below - Should build in mock. Issues: 1. The desktop file has Version=0.9.0. Should that be Version=0.9.3 ? 2. You are using %makeinstall. Can you switch to 'make DESTDIR=... ? See: http://fedoraproject.org/wiki/Packaging/Guidelines#head- fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 3. Why %defattr(-,root,root,0755) instead of just %defattr(-,root,root,-). Do some of the installed dirs get the wrong permissions? 4. Your desktop install should add: --add-category X-Fedora 5. Doesn't build in mock. I get this at the end of build.log: configure: error: *** libiberty required to build Alleyoop. error: Bad exit status from /var/tmp/rpm-tmp.34937 (%build) Missing BuildRequires: binutils-devel? 6. Adding the BuildRequires from point 5, the package builds and rpmlint says: W: alleyoop conffile-without-noreplace-flag /etc/gconf/schemas/alleyoop.schemas Should this be marked (noreplace)? W: alleyoop macro-in-%changelog description W: alleyoop macro-in-%changelog postun In changelog's you need to use %% to refer to a macro, or rpm will expand them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 --- Additional Comments From [EMAIL PROTECTED] 2006-08-15 03:12 EST --- New spec and srpms at: http://giallu.interfree.it/fedora/alleyoop.spec http://giallu.interfree.it/fedora/alleyoop-0.9.3-1.src.rpm fixes the problem at program exit and mock (FC5) build -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-08-14 10:40 EST --- *** Bug 166205 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 --- Additional Comments From [EMAIL PROTECTED] 2006-08-12 21:09 EST --- Starting alleyop and exiting via menu File Quit gives a backtrace and a hanging main window: $ alleyoop *** glibc detected *** alleyoop: double free or corruption (!prev): 0x08106000 * ** === Backtrace: = /lib/libc.so.6[0x6472b7] /lib/libc.so.6(cfree+0x78)[0x64a7ac] /usr/lib/libpopt.so.0(poptFreeContext+0x266)[0xdf07d6] /usr/lib/libgnome-2.so.0[0x247f8c9] /lib/libgobject-2.0.so.0(g_object_unref+0x16c)[0x95d24c] /usr/lib/libgnome-2.so.0[0x247d5e4] /lib/libc.so.6(exit+0xe6)[0x60e65e] /lib/libc.so.6(__libc_start_main+0xe4)[0x5f921c] alleyoop[0x804d231] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 201417] Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417 --- Additional Comments From [EMAIL PROTECTED] 2006-08-04 19:13 EST --- This was already submitted in bug 166205 (which should be marked as duplicate of the new request). I have still to address the remarks made by Michael Schwendt in the original bug. Any suggestion about how to proceed is welcome. Please note I will be out of town for a few days, so do not expect prompt replies until next week-end -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
