[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2008-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/show_bug.cgi?id=201842


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-18 07:40 EST ---
Paul, thanks for your review!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842





--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 07:21 EST ---
Ping :-) (we're so close!)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842





--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 18:23 EST ---
Sorry - not been that well recently, I'm usually out of it by about 9.30pm
(British Summer Time). It's 2nd on my list for tomorrow's reviews. Who knows, it
may even be good to go (TM) by this time tomorrow!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842





--- Additional Comments From [EMAIL PROTECTED]  2006-08-10 06:41 EST ---
rpmlint on the src package is giving the warning that you've mixed spaces with 
tabs

builds cleaning in mock
installs cleanly using yun localinstall
rpm -qa --requires is not showing anything untoward

I'll need to do the full review when I'm sitting infront of the machine.

Can you address the mixed spaces and tabs and just upload a new spec file?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842





--- Additional Comments From [EMAIL PROTECTED]  2006-08-10 09:30 EST ---
SPEC: http://www.poolshark.org/src/plotutils.spec
SRPM: http://www.poolshark.org/src/plotutils-2.5-2.src.rpm

 warning that you've mixed spaces with tabs

Somehow I always get that even when I use tabs everywhere! :-) Fixed.

 You need Requires (post) : ldconfig

Fixed.

 mkdir docs-to-include

I think it's a pretty harmless trick to add directories straight into
/usr/share/doc/%{name}. I use that already in the gtkmm packages. Now I'm not
sure it would work the same way if you created it under BUILDROOT, because %doc
works differently if you give it a relative or absolute path, and the relative
path is always from the source dir... I think you'd have to explicitely move
things from %{_datadir} into %{_docdir}/%{name}/ after installation.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201842] Review Request: plotutils - GNU plotutils graphics libs and utils

2006-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plotutils - GNU plotutils graphics libs and utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201842





--- Additional Comments From [EMAIL PROTECTED]  2006-08-09 18:28 EST ---
Looking at the spec file

You need Requires (post) : ldconfig unless you change post to be -p 
/sbin/ldconfig

mkdir docs-to-include

Where exactly does that get made? Why not just create a directory in the
buildroot and shift from there rather than interfere with the dearchived source?
This is not a complaint, just a suggestion. Other than patches, doing things in
the BUILD I've always considered a bad idea (TM)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review