[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=202356 Hans Ulrich Niedermann rhb...@n-dimensional.de changed: What|Removed |Added Blocks||486248 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added Resolution|NEXTRELEASE |CURRENTRELEASE Fixed In Version||4.20-5.fc5 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-31 22:17 EST --- 2. Ah, I missed that that was the console fonts package in that group. Looking around I can't seem to find any other packages that provide console fonts, so it's hard to say what group it should be in. :( I guess your Application/Text might be better than User Interface/X if you want to change it back. All the rest look fixed up... This package looks like it's good to be APPROVED. I would be happy to sponsor you... You should be able to continue the process from the Get a Fedora Account step on: http://www.fedoraproject.org/wiki/Extras/Contributors -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-27 12:43 EST --- Hey Hans. I will take a crack at reviewing this package and possibly sponsoring you. I should get a full review out on it hopefully later today. In the mean time, you may want to take a look at: http://fedoraproject.org/wiki/Extras/HowToGetSponsored and perhaps add some comments to other pending reviews. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: terminus-font - Clean fixed width font
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356
--- Additional Comments From [EMAIL PROTECTED] 2006-08-27 14:37 EST ---
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
fe9d8e25b9537f6b3154d07d3da50375 terminus-font-4.20.tar.gz
fe9d8e25b9537f6b3154d07d3da50375 terminus-font-4.20.tar.gz.1
OK - Package compiles and builds on at least one arch.
n/a - Package needs ExcludeArch
OK - BuildRequires correct
n/a - Spec handles locales/find_lang
n/a - Spec has needed ldconfig in post and postun
n/a - Package is relocatable and has a reason to be.
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
n/a - -doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
n/a - Headers/static libs in -devel subpackage.
n/a - .pc files in -devel subpackage.
n/a - .so files in -devel subpackage.
n/a - -devel package Requires: %{name} = %{version}-%{release}
n/a - .la files are removed.
n/a - Package is a GUI app and has a .desktop file
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
SHOULD Items:
See below - Should include License or ask upstream to include it.
OK - Should build in mock.
See below - Should have sane scriptlets.
Issues:
1. Should ping upstream to include a copy of the GPL COPYING file.
2. The Group doesn't seem right here. Other font packages use:
User Interface/X
(Granted that rpm groups aren't very usefull, but we should try and
be consistant at least).
3. perl and gawk are in the default BuildRequires, no need to list them.
4. rpmlint says:
W: terminus-font-x11 dangerous-command-in-%preun rm
Why remove those files?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: terminus-font - Clean fixed width font
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-08-27 20:02 EST ---
(In reply to comment #3)
W: terminus-font-x11 dangerous-command-in-%preun rm
Why remove those files?
Hello, Hans:
You have to take a %ghost file method.
i.e.
In install stage:
touch $RPM_BUILD_ROOT%{local_x11_font_dir}/fonts.dir etc
In file entry:
%ghost %verify(not md5 size mtime) %{local_x11_font_dir}/fonts.dir etc
... and get rid of rm command from %preun entry (I think that the
whole %preun stage is unnecessary).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 202356] Review Request: terminus-font - Clean fixed width font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: terminus-font - Clean fixed width font https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202356 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: terminus- |Review Request: terminus- |font|font - Clean fixed width ||font -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
