[Bug 205884] Review Request: perl-Email-Valid - Check validity of internet email address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Valid - Check validity of internet email address https://bugzilla.redhat.com/show_bug.cgi?id=205884 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205884] Review Request: perl-Email-Valid - Check validity of internet email address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Valid - Check validity of internet email address https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205884 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-15 14:03 EST --- I grabbed a copy of the SRPM from: http://distro.ibiblio.org/pub/linux/distributions/aurora/scratch/spot-review/perl-Email-Valid-0.176-1.src.rpm and updated it with the above attached specfile. The result looks better. rpmlint says: W: perl-Email-Valid mixed-use-of-spaces-and-tabs (no big deal; the errant tab is on the BuildRequireas: bind-utils line if you want to remove it). The only real issue I see is that you manually specify Requires: perl(Mail::Address) which is duplicated by RPM's automatic dependency generation and thus should be removed. Some tests are skipped; running with TEST_VERBOSE=1 shows this: ok 12 # skip your dns appears missing or failing to resolve ok 13 # skip your dns appears missing or failing to resolve This is due to building in mock with no DNS config. ok 14 # skip tests require Net::Domain::TLD 1.65 ok 15 # skip tests require Net::Domain::TLD 1.65 ok 16 # skip tests require Net::Domain::TLD 1.65 Net::Domain::TLD is not in the repo so this is unavoidable at this time. Review: * source files match upstream: c71a350965c97473af80edfa1bff0b63 Email-Valid-0.176.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. X final provides and requires are sane: perl(Email::Valid) = 0.176 perl-Email-Valid = 0.176-2.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(File::Spec) perl(IO::File) perl(Mail::Address) X perl(Mail::Address) perl(strict) perl(vars) * %check is present and all tests pass: 5/16 skipped: various reasons All tests successful, 5 subtests skipped. Files=3, Tests=18, 36 wallclock secs ( 0.18 cusr + 0.04 csys = 0.22 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205884] Review Request: perl-Email-Valid - Check validity of internet email address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Valid - Check validity of internet email address https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205884 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2006-09-15 15:16 EST --- Built. Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205884] Review Request: perl-Email-Valid - Check validity of internet email address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Valid - Check validity of internet email address https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205884 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-09-09 11:47 EST --- *** Bug 189184 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205884] Review Request: perl-Email-Valid - Check validity of internet email address
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Valid - Check validity of internet email address https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205884 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-09 12:19 EST --- This fails to build in the same way that bug 189184 fails; missing build requirements kill the test suite. I suggest adding BR: perl(Test::Pod) and perl(Test::Pod::Coverage) to get some additional test suite coverage, and bind-utils so that the test suite doesn't die due to lack of nslookup. This stikk skips a bunch of tests for some reason, but it allows the package to build. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
