[Bug 205886] Review Request: perl-File-MMagic-XS - Guess file type with XS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-MMagic-XS - Guess file type with XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205886 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2006-09-21 13:40 EST --- Built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205886] Review Request: perl-File-MMagic-XS - Guess file type with XS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-MMagic-XS - Guess file type with XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205886 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-15 14:39 EST --- You're the license czar so if you feel comfortable importing this then I have no objections. * source files match upstream: b8ce9617527a999c85d54fc8a4e88ebc File-MMagic-XS-0.08.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. ? license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: XS.so()(64bit) perl(File::MMagic::XS) = 0.08 perl-File-MMagic-XS = 0.08-2.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(File::MMagic) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=2, Tests=11, 0 wallclock secs ( 0.06 cusr + 0.01 csys = 0.07 CPU) * no shared libraries are added to the regular linker search paths. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205886] Review Request: perl-File-MMagic-XS - Guess file type with XS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-MMagic-XS - Guess file type with XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205886 --- Additional Comments From [EMAIL PROTECTED] 2006-09-11 11:09 EST --- Created an attachment (id=136002) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=136002action=view) Fixed spec file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205886] Review Request: perl-File-MMagic-XS - Guess file type with XS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-MMagic-XS - Guess file type with XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205886 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205886] Review Request: perl-File-MMagic-XS - Guess file type with XS
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-MMagic-XS - Guess file type with XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205886 --- Additional Comments From [EMAIL PROTECTED] 2006-09-09 13:36 EST --- rpmlint says: W: perl-File-MMagic-XS invalid-license Apache rpmlint would prefer Apache Software License. E: perl-File-MMagic-XS useless-explicit-provides perl(File::MMagic::XS) Another rpm screwup; somehow it adds the module twice to the provides list, both with and without a version. In the past this has always required a filter. Returning to the subject of the license, I'm not sure that it's clear that the entire package is under the Apache license. The parts that came from Apache are clear, the public domain parts are indicated as such, but some of it is just All rights reserved (see lib/File/MMagic/XS.pm) which seems problematic. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review