[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Body - HTTP Body Parser https://bugzilla.redhat.com/show_bug.cgi?id=205887 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Body - HTTP Body Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205887 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2006-09-14 20:53 EST --- Built, thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Body - HTTP Body Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205887 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-12 11:13 EST --- I had to change the %check section to: make test TEST_POD=1 to actually test everything; with that, I get: All tests successful. Files=6, Tests=77, 0 wallclock secs ( 0.59 cusr + 0.12 csys = 0.71 CPU) The provides/requires list is now: perl(HTTP::Body) = 0.6 perl(HTTP::Body::MultiPart) perl(HTTP::Body::OctetStream) perl(HTTP::Body::UrlEncoded) perl-HTTP-Body = 0.6-2.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(File::Temp) = 0.14 perl(HTTP::Body::MultiPart) perl(HTTP::Body::OctetStream) perl(HTTP::Body::UrlEncoded) perl(IO::File) perl(YAML) = 0.39 perl(base) perl(bytes) perl(strict) which is fine. So: APPROVED just tack on TEST_POD=1 when you check in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Body - HTTP Body Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205887 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Body - HTTP Body Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205887 --- Additional Comments From [EMAIL PROTECTED] 2006-09-09 15:18 EST --- The %description is a bit lacking, but the package doesn't Some checks are skipped due to missingg BuildRequires; suggest adding perl(Test::Pod) and perl(Test::Pod::Coverage). Some of your explicit Requires: duplicate the ones that rpm finds: perl(Carp), perl(File::Temp) = 0.14, perl(IO::File). * source files match upstream: e7f5963abece523dd9be27db3d37aaea HTTP-Body-0.6.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. X BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. X final provides and requires are sane: perl(HTTP::Body) = 0.6 perl(HTTP::Body::MultiPart) perl(HTTP::Body::OctetStream) perl(HTTP::Body::UrlEncoded) perl-HTTP-Body = 0.6-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) X perl(Carp) perl(File::Temp) = 0.14 X perl(File::Temp) = 0.14 perl(HTTP::Body::MultiPart) perl(HTTP::Body::OctetStream) perl(HTTP::Body::UrlEncoded) perl(IO::File) X perl(IO::File) perl(YAML) = 0.39 perl(base) perl(bytes) perl(strict) X %check is present but some tests are skipped due to missing BuildRequires: All tests successful, 2 tests skipped. Files=6, Tests=69, 1 wallclock secs ( 0.47 cusr + 0.12 csys = 0.59 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTTP-Body - HTTP Body Parser https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205887 --- Additional Comments From [EMAIL PROTECTED] 2006-09-09 15:32 EST --- Ummm... The %description is a bit lacking, but the package doesn't include any additional descriptive text that you could use. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
