[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/show_bug.cgi?id=206761 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-09-17 08:33 EST --- Branch has been created and package built succesfully. Closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-09-16 14:28 EST --- I'll take this review. Where does the version number come from? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kadu-theme - themes for Kadu
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761
--- Additional Comments From [EMAIL PROTECTED] 2006-09-16 15:05 EST ---
1. package meets naming and packaging guidelines, but the origin of the
version number isn't clear, please explain.
2. specfile is properly named, is cleanly written but doesn't use macros
consistently:
%define _themesdir /usr/share/kadu/themes
You should use %{_datadir} here. And since you never seem to use %{_themesdir}
without /icons, why not
%define _kaduiconsdir %{_datadir}/kadu/themes/icons ?
3. dist tag is present.
4. build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
5. can't verify if license field matches the actual license.
* Crystal theme is - according to README - based on Crystal SVG icons from
everaldo.com, but I can't find any license info there except:
http://www.everaldo.com/legal.html , which is definitely NOT open-source
compatible. It's used in KDE though, so I imagine this is open-source licensed,
but still requires an explanation (maybe README.Fedora?)
* Glass theme has NO license information inside the tarballs
* Nuvola theme is LGPL according to Copyright, but full license text is NOT
included (and at least that Copyright file should be in %files)
6. source files match upstream:
023085edabaf6a1b844fe6b5fc9315f9 kadu-theme-crystal-16.tar.bz2
57852ff3d3fd0063a642fcc173f7fa29 kadu-theme-crystal-22.tar.bz2
c3beb753222b96dad46f3adf230eb3e1 kadu-theme-glass_16.tar.gz
9ee70ca873fd0f22b2b83be133964d89 kadu-theme-glass_22.tar.gz
586cc6ff9ba62f0fdd7c7c1adf229efb kadu-theme-nuvola-16.tar.gz
7a17b4881141b346c6268ef25c284613 kadu-theme-nuvola-22.tar.gz
7. latest version is being packaged.
8. BuildRequires are proper.
9. didn't check if package builds in mock.
10. rpmlint is more or less silent:
W: kadu-theme-crystal16 no-documentation
W: kadu-theme-crystal22 no-documentation
W: kadu-theme-glass16 no-documentation
W: kadu-theme-glass22 no-documentation
W: kadu-theme-nuvola16 no-documentation
W: kadu-theme-nuvola22 no-documentation
11. final provides and requires are sane:
kadu-theme-crystal16 = 0.5.0-1
=
kadu
kadu-theme-crystal22 = 0.5.0-1
=
kadu
kadu-theme-glass16 = 0.5.0-1
=
kadu
kadu-theme-glass22 = 0.5.0-1
=
kadu
kadu-theme-nuvola16 = 0.5.0-1
=
kadu
kadu-theme-nuvola22 = 0.5.0-1
=
kadu
12. no shared libraries are present.
13. package is not relocatable.
14. owns the directories it creates.
15. doesn't own any directories it shouldn't.
16. no duplicates in %files.
17. file permissions are appropriate.
18. %clean is present.
19. %check is absent and no test suite.
20. no scriptlets present.
21. permitted content.
22. documentation is small, so no -docs subpackage is necessary.
23. %docs are not necessary for the proper functioning of the package.
24. no headers.
25. no pkgconfig files.
26. no libtool .la droppings.
27. not a GUI app in itself, so doesn't require a .desktop entry
28. not a web app.
1. and 2. are easily fixable, so I'm mostly concerned with 5. Please contact
upstream about this. If this is split from an already accepted package, I wonder
why this wasn't caught before...
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kadu-theme - themes for Kadu
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761
--- Additional Comments From [EMAIL PROTECTED] 2006-09-16 16:48 EST ---
(In reply to comment #2)
1. package meets naming and packaging guidelines, but the origin of the
version number isn't clear, please explain.
Previously, themes was included into main package and they have to get bigger
version release (for example, in repo is available
kadu-theme-crystal22-0.5.0-20060808svn)
2. specfile is properly named, is cleanly written but doesn't use macros
consistently:
%define _themesdir /usr/share/kadu/themes
You should use %{_datadir} here. And since you never seem to use %{_themesdir}
without /icons, why not
%define _kaduiconsdir %{_datadir}/kadu/themes/icons ?
%{_datadir} issue is fixed. I don't use kaduiconsdir macro, because I assume
that there will be another themes than only icons, in future.
5. can't verify if license field matches the actual license.
* Crystal theme is - according to README - based on Crystal SVG icons from
everaldo.com, but I can't find any license info there except:
http://www.everaldo.com/legal.html , which is definitely NOT open-source
compatible. It's used in KDE though, so I imagine this is open-source
licensed,
I have noticed legal section on www.evaraldo.com is not open-source compatible,
but the actual icons license I found here:
http://commons.wikimedia.org/wiki/Image:Crystal_Clear_action_1downarrow.png
* Glass theme has NO license information inside the tarballs
Glass license is written down here:
http://www.kadu.net/forum/viewtopic.php?t=6815highlight=glass
* Nuvola theme is LGPL according to Copyright, but full license text is NOT
included (and at least that Copyright file should be in %files)
I have included all licenses in %doc.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761 --- Additional Comments From [EMAIL PROTECTED] 2006-09-16 16:49 EST --- SPEC file: http://ecik.zspswidwin.pl/kadu/kadu-theme.spec SRPM file: http://ecik.zspswidwin.pl/kadu/kadu-theme-0.5.0-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761 --- Additional Comments From [EMAIL PROTECTED] 2006-09-16 17:59 EST --- This is a more authoritative information source for Crystal's LGPL-ness, I'd say: http://www.kde-look.org/content/show.php?content=8341 Please contact upstream about missing license files! APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 206761] Review Request: kadu-theme - themes for Kadu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
