[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2008-02-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-20 06:45 EST ---
This is a blocker for my package and the Fedora maintainer seems not to be
interested. cvsextras commits will be open and I'm willing aprove the Fedora
maintainer once he applies for ACLs.

Package Change Request
==
Package Name: python-twisted-web
New Branches: EL-5
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2008-02-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-20 15:14 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2008-02-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-17 11:15 EST ---
Thomas: I'm interested in EL-5 branch. Would you maintain it yourself or you
won't mind if I maintained it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2007-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||221310
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-12-28 18:27 EST ---
built, closing

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-12-27 07:45 EST ---
OK, Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-27 08:58 EST ---
imported, waiting for fc-6 branch

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 07:40 EST ---
Paul, Kevin,

pulled in Jef's updated spec as is.

Any further comments, or can this be APPROVEd ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 08:26 EST ---
Has anybody else seen the problem with the dropin cache at package removal time
that I mentioned in Comment #1?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 10:12 EST ---
I removed all my packages (including the divmod ones) and now I am able to
reproduce it.  Before I had it spuriously and couldn't figure out a way to 
debug it.

I dug a little deeper now and it seems that the Twisted code logs an exception
using its own log handler when it finds a plugin in the cache that is no longer
on disk.

Since this is the point of updating the cache - removing plugins that no longer
exist - I changed twisted-dropin-cache to not log on that particular error.

I pushed a new python-twisted-core package to extras that should fix this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-26 15:28 EST ---
I don't see any more blockers here... using the new python-twisted-core from the
buildsys (it's not been pushed yet) I don't see any dropin cache issues.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105





--- Additional Comments From [EMAIL PROTECTED]  2006-12-22 22:41 EST ---
thanks to python 2.5 now in the development tree you'll need a new 
Buildrequires: python-devel

You'll find the updated srpm and spec  which builds against current
fedora-development here:

http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-twisted-web/python-twisted-web-0.6.0-4.src.rpm
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-twisted-web/python-twisted-web.spec

I've also included the LICENSE and NEWS fileas as %doc and updated the URL tag
as suggested in the review comment



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||219972
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||171543
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-12-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-12-16 14:46 EST ---
Hey Thomas. 

Any news on the mustfix/suggestion items from this review?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 216105] Review Request: python-twisted-web - Twisted web server, programmable in Python

2006-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-web - Twisted web server, programmable 
in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216105


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-11-22 11:44 EST ---
Review
==

- package and spec file naming OK
- package meets guidelines
- license is MIT, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for FC4-Rawhide, i386 and x86_64
- BR's OK
- no locale issues
- no shared libraries
- not relocatable
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage consistent enough
- code, not content
- docs aren't excessively large
- docs don't affect runtime
- no subpackages
- no devel files present
- not a GUI app, no desktop file needed
- package seems to work OK (tested with bittorrent 5.0.1)

MUSTFIX:

* Include LICENSE as %doc

PROBLEM:

# rpm -qa python-twisted\*
python-twisted-web-0.6.0-4.fc6
python-twisted-core-2.4.0-4.fc6
# rpm -e python-twisted-web
Traceback (most recent call last):
  File /usr/libexec/twisted-dropin-cache, line 16, in ?
list(getPlugins(IPlugin))
--- exception caught here ---
  File /usr/lib64/python2.4/site-packages/twisted/plugin.py, line 214, in
getPlugins
adapted = interface(plugin, None)
  File /usr/lib64/python2.4/site-packages/zope/interface/interface.py, line
658, in __call__
adapter = conform(self)
  File /usr/lib64/python2.4/site-packages/twisted/plugin.py, line 77, in
__conform__
return self.load()
  File /usr/lib64/python2.4/site-packages/twisted/plugin.py, line 72, in load
return namedAny(self.dropin.moduleName + '.' + self.name)
  File /usr/lib64/python2.4/site-packages/twisted/python/reflect.py, line 370,
in namedAny
obj = getattr(obj, n)
exceptions.AttributeError: 'module' object has no attribute 'twisted_web'

I think that needs fixing.

NOTES:

* rpmlint output:
E: python-twisted-web no-binary
  This is to be expected for what is essentially a noarch package that has to
  live in an arch-specific place due to the way python works, i.e. not an issue

SUGGESTIONS:

* URL should be: http://twistedmatrix.com/trac/wiki/TwistedWeb
* Include NEWS as %doc



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review