[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-14 22:38 EST ---
New Package CVS Request
===
Package Name: mybashburn
Short Description: MyBashBurn - burn data and songs.
Owners: wilmer
Branches: F-8
InitialCC: wilmer
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||
   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-13 13:33 EST ---
Cool, this looks good.  I believe all of the issues I had are now fixed.

APPROVED

I have already set you up in the account system, so you should be ready to make
your CVS request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-02-13 16:39 EST ---
Jason, I received a email confirmation of you sponsorship.  I'm to get this
message when try to change fedora-cvs flag to '?' for the CVS admin attention:
Flag Modification Denied
You tried to request fedora-cvs. Only an authorized user can make this change.

I have the existing memberships:
Group Name  UsernameR.Domain R.Type  R Status Sponsor
cvsextras   wilmer  userapprovedtibbs
fedorabugs  wilmer  userapprovedUnneeded

Any comment?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-02-13 21:41 EST ---
Well, you do have to give it time to propagate to all of the various systems and
databases.  I think this happens at least once an hour, so it should almost
certainly be working now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 18:00 EST ---
Already, please review
SPEC: http://wilmer.fedorapeople.org/files/review/mybashburn/mybashburn.spec
SRPMS:
http://wilmer.fedorapeople.org/files/review/mybashburn/SRPMS/mybashburn-1.0.2-3.fc8.src.rpm
RPMS:
http://wilmer.fedorapeople.org/files/review/mybashburn/RPMS/mybashburn-1.0.2-3.fc8.noarch.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-02-11 21:27 EST ---
No, you should run iconv in the %prep section of the specfile to convert the
file at build time.  You don't make the changes in the tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-02-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-02-11 20:56 EST ---
Hi Jason, sorry for out long time, of course that there is a reason, I have a
problem with 'rpmlint' command, I get an encoding error about the file 'FILES'
of mybasburn upstream, they was writing in ISO-8859-1 and the CLI rpmlint
recommend using UTF-8, the output of rpmlint:
mybashburn.noarch: W: file-not-utf8 /usr/share/doc/mybashburn-1.0.2/FILES

So, I have to run this command for the conversion:
$ iconv -f ISO-8859-1 -t UTF8 FILES  FILES.tmp
$ mv FILES.tmp FILES

You recommend writing that in the SPEC file?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-01-31 15:00 EST ---
OK, the license is fixed, but the tarball still does not match the upstream 
tarball.

If you have a Source0: url of 
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
then I simply must be able to download that tarball and get exactly, byte for
byte, what you are including in the srpm.  It is not acceptable for you to
modify that tarball in any way unless it contains content which we cannot
legally distribute.

If you are packaging something out of upstream SVN, we have rules about how you
document that.  You certainly cannot use the same version name because what you
want to distribute is not the same as what upstream ships with that version.  So
please see http://fedoraproject.org/wiki/Packaging/NamingGuidelines.  And if you
are going to package an SVN checkout then we also have rules about how you
document that so that I can make the same SVN checkout as you made:
http://fedoraproject.org/wiki/Packaging/SourceURL.

But honestly, do you have some compelling reason not to just ship what upstream
ships?  Just use their tarball in place of whatever you are trying to package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-01-27 22:32 EST ---
Hi Jason, I uploaded new files and some brief comments.
source files do not match upstream., yeah, I was possibly packaging SVN 
source 
files.
license field matches the actual license (should be GPLv2+) Changed to GPLv2+
according.

SPEC: http://wilmer.fedorapeople.org/files/review/mybashburn/mybashburn.spec
SRPMS:
http://wilmer.fedorapeople.org/files/review/mybashburn/SRPMS/mybashburn-1.0.2-3.fc8.src.rpm
RPMS:
http://wilmer.fedorapeople.org/files/review/mybashburn/RPMS/mybashburn-1.0.2-3.fc8.noarch.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-01-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-01-15 17:20 EST ---
It seems to me that the tarball in the srpm is not the same as the upstream 
tarball.

Looking at the MyBashBurn.sh file, it's clear that the license should be GPLv2+ 
as they allow any later version.

I believe those are the only issues remaining.

To refresh my memory, let me run through my checklist again:
X source files do not match upstream.
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
 description is OK.
 dist tag is present.
 build root is OK.
X license field matches the actual license (should be GPLv2+)
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   mybashburn = 1.0.2-3.fc9
  =
   /bin/sh
   /usr/bin/env
   cdda2wav
   cdrdao
   cdrecord
   coreutils
   dialog = 1.0
   dvd+rw-tools
   eject
   flac
   mkisofs
   vorbis-tools

* %check is not present; no test suite upstream.  I did some light testing
   (over the network so I didn't actually try to burn anything) and it seems
   to work OK.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|devel   |rawhide




--- Additional Comments From [EMAIL PROTECTED]  2008-01-02 12:23 EST ---
(In reply to comment #43)
 You should use this URL in the Source-Tag:
 http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2

Fixed, updates both RPMS files: (release 3)

SPEC: http://mybashburn.sourceforge.net/mybashburn.spec
RPMS: http://mybashburn.sourceforge.net/mybashburn-1.0.2-3.src.rpm

* package builds in mock.
* package installs properly.
* rpmlint has valid complaints.

;)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2008-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2008-01-02 12:26 EST ---
[ERRATA] Sorry, the correct links of SRPM file is:
RPMS: http://mybashburn.sourceforge.net/mybashburn-1.0.2-3.fc8.src.rpm

Thanks for the review.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-08-28 15:45 EST ---
You should use this URL in the Source-Tag:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2

See:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-08-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-08-26 17:42 EST ---
I'm sorry, I was confused too, it's just fixed, i can looking some changes in
rpmlint tool and was changed license name of GPL to GPLv2.

Update files:

SPEC: http://mybashburn.sourceforge.net/mybashburn.spec
RPMS: http://mybashburn.sourceforge.net/mybashburn-1.0.2-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-08-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-08-15 12:49 EST ---
I'm confused; this package is older (release 1) than the package linked in
comment 38 (release 2).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-08-08 20:04 EST ---
Updated with you suggestions:

Spec: http://mybashburn.sourceforge.net/mybashburn.spec
SRPM: http://mybashburn.sourceforge.net/mybashburn-1.0.2-1.src.rpm

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|ORBit   |Package Review




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-07-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Package Review  |ORBit




--- Additional Comments From [EMAIL PROTECTED]  2007-07-27 00:19 EST ---
I'm just now finding some time to get back to these reviews.

This builds fine and rpmlint now finds nothing to complain about.

I'm afraid I don't understand your comments about the necessary size of the
window.  Perhaps what you're not understanding is that it fails to run
regardless of the size of the window; even on a full screen shell window with an
8pt font on a 24 monitor.  It flashes an almost unreadable message which I
thihnk tells me that the window size is 80x24 (which is most certainly isn't)
and then exits.

A minor nit: I think a summary of Burn data and create songs with interactive
dialogs is slightly more correct English.

Otherwise, though, the package is looking good and I'd approve it if I could 
run it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-07-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-07-10 20:30 EST ---
OK, this builds and installs fine in mock on x86_64 running rawhide.  rpmlint 
says:
  W: mybashburn spurious-executable-perm /usr/share/man/man1/mybashburn.1.gz
which is easily fixed by setting the permissions to 644 when you install it.

Unfortunately when I attempted to test this, all I get is a message flashingg by
telling me Terminal size must be fix, the size now is 80x24 Fai MyBashBurn
1.0.2 and then the program exits.  This is on an i386 machine running rawhide.

You need to be consistent about your macro usage.  If you want to use the
macroized forms like %{__sed} then you need to use %{__rm}, %{__install},
%{__cp} and %{__ln}.

Don't start the summary with the name of the package.

You install CREDITS and HOWTO twice.  If they're required as internal help
files, they shouldn't also be installed as %doc.

Review:
* source files match upstream:
   058395728c295988c3d633f5a2a25224f25babea6117d4b35c26c7b7b93e0d6a  
   mybashburn-1.0.2.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named
X specfile does not use macros consistently.
X summary should not start with the name of the package.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   mybashburn = 1.0.2-1.fc8
  =
   /bin/sh
   /usr/bin/env
   cdda2wav
   cdrdao
   cdrecord
   coreutils
   dialog = 1.0
   dvd+rw-tools
   eject
   flac
   mkisofs
   vorbis-tools
* %check is not present; no test suite upstream.
X Manual testing was not at all successful.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
X CREDITS and and HOWTO are duplicated.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-07-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-07-11 01:10 EST ---
Hi Jason, Thanks for testing it.

(In reply to comment #37)
 OK, this builds and installs fine in mock on x86_64 running rawhide.  rpmlint
says:
   W: mybashburn spurious-executable-perm /usr/share/man/man1/mybashburn.1.gz
 which is easily fixed by setting the permissions to 644 when you install it.

Permissions now are correct, Fixed with: install -p m644 mybashburn.1.gz
 
 Unfortunately when I attempted to test this, all I get is a message flashingg 
 by
 telling me Terminal size must be fix, the size now is 80x24 Fai MyBashBurn
 1.0.2 and then the program exits.  This is on an i386 machine running 
 rawhide.

This is oks, for that MyBashBurn working correctly when is running in any X term
is necessary change the window default size manually, it not is a bug, does it
draw the windows based on internal dialog program, also attempt that the user
obtains best experience using the program, tries yourself for example to execute
the program in a size of terminal major to 80x20, later resize terminal minor to
80x20 and you know of that I speak to you, whatever with or without resize it
simply function right although it is not seen well. :D
Finnally the user only must resize/extend a little the terminal and execute
mybashburn, made simply, nevertheless when MyBashBurn is running in any not X
terminal it working good.

 You need to be consistent about your macro usage.  If you want to use the
 macroized forms like %{__sed} then you need to use %{__rm}, %{__install},
 %{__cp} and %{__ln}.

I do not want to use that command macroized forms, s/%{_sed}/sed/
Fixed.

 Don't start the summary with the name of the package.

Fixed. 

 You install CREDITS and HOWTO twice.  If they're required as internal help
 files, they shouldn't also be installed as %doc.

oks, you are right, removed CREDITS and HOWTO of %doc.

Finnally thanks for your help on getting this worked out Jason. I've posted an
updated mybashburn spec/SRPM on its review request, update files are on
web project, please refresh:

Spec: http://mybashburn.sourceforge.net/mybashburn.spec
SRPM: http://mybashburn.sourceforge.net/mybashburn-1.0.2-2.src.rpm

(In reply to comment #36)
 I'll review this and emesene together
 and, if those reviews go well, I'll sponsor you.  A warning, though, emesene
 might need some work.

I'll working on a new emesene based on stable SVN version.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-07-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

Product|Fedora Extras   |Fedora

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |
  nThis||
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2007-07-09 13:19 EST ---
This has been sitting around for far too long, and it looks as if the major
issues detailed above have been fixed.  I'll review this and emesene together
and, if those reviews go well, I'll sponsor you.  A warning, though, emesene
might need some work.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-06-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 22:09 EST ---
New Release of MyBashBurn for more review:

SPEC: http://mybashburn.sourceforge.net/mybashburn.spec
SRPM: http://mybashburn.sourceforge.net/mybashburn-1.0.2-1.src.rpm

- More Clean up code.
- Fixed bug of compatibility for RHEL and CentOS Enterprise Linux.
- Fixed bug on define burn data menu when navigate names with blank spaces.
- Updated Makefile.
- Updated man and INSTALL files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-04-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-11 20:58 EST ---
^sponser^sponsor :D

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-01-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-01-29 18:48 EST ---
After of a short vacations here are some corrections:

SPEC: http://mybashburn.sourceforge.net/mybashburn.spec
SRPMS: http://mybashburn.sourceforge.net/mybashburn-1.0.1-2.src.rpm

Everybody remember, i need a sponsor, Thanks.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-01-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-01-16 23:17 EST ---
What's the status on this review?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-01-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-01-16 23:59 EST ---
Looks like you need to correct Changelog entry
rpmlint on rpm gave me
W: mybashburn incoherent-version-in-changelog 1.0.1 1.0.1-0
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2007-01-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





--- Additional Comments From [EMAIL PROTECTED]  2007-01-07 18:17 EST ---
greetings and happy new year,

I want announce a new release of MyBashBurn 1.0.1 with major feature and
enhancements, with some security bugfix important for this review, as a function
against race conditions on temp files, now MyBashBurn look for root/user config
in /etc/mybashburnrc, ~/.mybashburnrc in that order, fix permissions, updated
man file and the option of change the 'root directory' (/usr/share/mybashburn/)
have been deprecated for some time and will be removed.

New files location:

SPEC: http://mybashburn.sourceforge.net/mybashburn.spec
SRPMS: http://mybashburn.sourceforge.net/mybashburn-1.0.1-0.src.rpm
HOMEPAGE: http://mybashburn.sourceforge.net/


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 217197] Review Request: MyBashBurn - burn data and songs.

2006-12-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: MyBashBurn  |Review Request: MyBashBurn -
   |1.0-1 - burn data and songs.|burn data and songs.




--- Additional Comments From [EMAIL PROTECTED]  2006-12-13 04:10 EST ---
Ready, removed /etc/mybashburnrc, now it's configure in run time to
~/.mybashburnrc, Builds OK, rpmlint is silent, permissions fine.

New files updated:
http://www.fedora-ve.org/mybashburn/downloads/mybashburn.spec
SRPM URL:
http://www.fedora-ve.org/mybashburn/downloads/mybashburn-1.0-3.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review