[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/show_bug.cgi?id=218217 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-04-23 11:45 EST --- Package Change Request == Package Name: telepathy-stream-engine New Branches: OLPC2 Updated Fedora Owners: gdesmott,bpepple -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/show_bug.cgi?id=218217 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-04-23 12:21 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-12-27 19:31 EST --- Jef, thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-12-25 04:46 EST --- Approved, just add --enable-sequencec-diagrams=no to the %configure before you build. -jef -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-23 21:56 EST --- (In reply to comment #8) Yes, this was on purpose since the sequence diagrams generation support isn't complete yet. Does the configure script let you explicitly disable imagemagik,gs, and plotutils support? It would be best if these features were explicitly disabled so we can get consistent rebuilds of the srpm even in build environments where these exist. I'm not sure this should count as a blocker or not, but I think Mamoru has a point concerning binary reproducibility. -jef -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-23 22:36 EST --- (In reply to comment #10) Does the configure script let you explicitly disable imagemagik,gs, and plotutils support? It would be best if these features were explicitly disabled so we can get consistent rebuilds of the srpm even in build environments where these exist. I believe there is a '--enable-sequence-diagrams=no' option we can add to disable the building of this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 19:45 EST --- yes it looks like the piedmont.homelinux.org server is down again. Brian email me the spec and src.rpm and I can host them for you. -jef -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 20:28 EST --- Here you go, these urls are live. http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine-0.3.16-1.src.rpm http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 21:27 EST --- Uhm looks like they bumped up to 0.3.18 in the meantime. Would you like me to spin up an updated srpm and spec for 0.3.18 and place them on the website for you? -jef -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 22:50 EST --- URL updated http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine-0.3.18-1.src.rpm I will be starting the formal review of 0.3.18 srpm tonite as time allows. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: telepathy-stream-engine - Telepathy client to handle
media streaming
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217
--- Additional Comments From [EMAIL PROTECTED] 2006-12-22 23:32 EST ---
It looks good. Here is the formal review.
I'm going to start a clock on this, and if noone brings up any blockers I'll
approve tomorrow evening.
-jef
GOOD:
*Built in mock on i386 against fedora-development
*rpmlint runs cleanly against it
*follows naming guidelines
*licnese is LGPL and spec tag matches
*COPYING file in %doc
*spec in US/english and legible
*Include source matches upstream md5sum
52c0b48905f11cac71df1f8560c8f4d7 telepathy-stream-engine-0.3.18.tar.gz
*buildrequires look good
*no locales to worry about
*no shared libraries
*not relocatable
*does not create any unowned directories. Package requires
libdbus-1.so.3 which is provided by dbus which owns
%{_datadir}/dbus-1/services/
*no duplicates in %files
*file permissions seem fine
*install and clean sections look good
*macro use is consistent
*docs is good
*no -devel subpackage
*no la files
*not a gui, no desktop file needed
*appears to meet all packaging guidelines
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-23 00:27 EST --- Well, * please check if the following is what you expect. --- checking for pic2plot... no checking for gs... no checking for convert... no configure: WARNING: Imagemagick not found, drawing sequence diagrams will be disabled. configure: WARNING: Ghostscript not found, drawing sequence diagrams will be disabled. configure: WARNING: GNU plotutils not found, drawing sequence diagrams will be disabled. Note: all of them are available in Fedora Core/Extras and a people who has already installed them beforehand may create different binary rpm of telepathy-stream-engine. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-23 01:16 EST --- Yes, this was on purpose since the sequence diagrams generation support isn't complete yet. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 --- Additional Comments From [EMAIL PROTECTED] 2006-12-23 02:29 EST --- Okay, then this package can be approved IMO. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218217] Review Request: telepathy-stream-engine - Telepathy client to handle media streaming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: telepathy-stream-engine - Telepathy client to handle media streaming https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218217 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-12-09 03:35 EST --- I cannot read your spec/srpm. Is piedmont.homelinux.org alive? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
