[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-06-21 12:35 EST --- Anything happening here? It's been well over a month since the last comment without any response. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for
the Audacious media player
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |medium
Priority|normal |medium
--- Additional Comments From [EMAIL PROTECTED] 2007-05-09 17:20 EST ---
I agree the plugin should be named audacious-plugin-itouch.
But to do this, I must modify the source tarbal, and repackage
it. Do I have the right to do that?
Nah, you don't have to. %setup accepts a switch, -n, which allows for
changing the exact name of the folder in the source tarball. In this case,
simply change to this:
%setup -q -n audacious-itouch-%{version}
Quick Review (not official):
Since I can't download the source, this is just going to be a quick
runthrough.
MUST Items:
- rpmlint gives no errors.
- The package is named according to the Package Naming Guidelines.
- The package is licenced under an open-source licence (GPL).
- Licence info included in %doc.
- Spec file named %{name}.spec.
- Spec file written in en-US and is legible.
- The package compiles on i386.
- Build dependencies are listed in BuildRequires properly.
- No locales in the package.
- ldconfig isn't called, but the library is not located in the standard linker
path.
- Package is not relocatable.
- Package owns all directories it creates.
- Permissions on files are set properly.
- Package has a proper %clean section.
- Spec file uses consistent macros.
- Package contains permissible content.
- All files in %doc are not necessary for program application.
- .la files are properly removed.
- Package does not create it's own directories.
- Package runs %{__rm} -rf %{buildroot} at the beginning of install.
- All filenames are valid UTF-8.
Possible problems:
- As mentioned before, the package should probably be called
audacious-plugins-itouch.
- The Source entry is actually a 404 now.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 --- Additional Comments From [EMAIL PROTECTED] 2007-01-29 05:28 EST --- I agree the plugin should be named audacious-plugin-itouch. But to do this, I must modify the source tarbal, and repackage it. Do I have the right to do that? Besides of that, I have made the package available for a while. When will it get pass the review process? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 --- Additional Comments From [EMAIL PROTECTED] 2007-01-20 12:58 EST --- I still think that audacious-itouch is a valid name for this package, since this is the upstream name. Nevertheless - after reading the review request for audacious-plugin-fc (bug #222648) and thinking about this more deeply, I like the idea of getting this straight. This would also include renaming audacious-docklet. Yu, what you think? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 --- Additional Comments From [EMAIL PROTECTED] 2007-01-20 16:33 EST --- To me it seems best to ask the packaging committee for a recomandation. Right now it seems that package-pluginname, package-plugin-pluginname, package-plugins-pluginname and package-pluginname-plugin for different packages. I would prefer package-plugins-pluginname or package-plugin-pluginname, this would make it easier to install all plugins, e.g. with yum install audacious-plugins-\* while audacious-\* also matches the devel package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-17 18:08 EST --- Consider renaming it to audacious-plugins-itouch because this fits to the naming scheme of the other audacious plugins in extras. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for
the Audacious media player
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256
--- Additional Comments From [EMAIL PROTECTED] 2007-01-17 18:40 EST ---
If this package should be renamed, then audacious-docklet also needs to be
renamed.
If this package is going to be renamed, we still should add Provides: and
Obsoletes: for audacious-itouch to allow easy upgrading of 3rd party packages.
I don't think renaming this package is really necessary. According to the naming
guidlines an addon package should prepend the parent package in its name, in
the format: %{parent}-%{child}. IMHO Using audaciuos as parent is perfectly ok.
Using audaciuos-plugins would indicate that this package stricktly depends on
audacious-plugins instead of audacious itself.
The only reason for this package to depend on audacious-plugins is that the
plugins package owns the dir this plugin is installed to.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: audacious- |Review Request: audacious- |itouch - iTouch keyboard |itouch - iTouch keyboard |control plugin for the |control plugin for the |Audacious media player |Audacious media player BugsThisDependsOn||163776 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn|163776 | OtherBugsDependingO||163776 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 218256] Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: audacious- |Review Request: audacious- |itouch - iTouch keyboard |itouch - iTouch keyboard |control plugin for the |control plugin for the |Audacious media player |Audacious media player --- Additional Comments From [EMAIL PROTECTED] 2006-12-21 05:24 EST --- Updated SPEC and SRPM Spec URL: http://yufanyufan.googlepages.com/audacious-itouch.spec SRPM URL: http://yufanyufan.googlepages.com/audacious-itouch-0.1-6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
