[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/show_bug.cgi?id=219981 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 18:09 EST --- (In reply to comment #4) > Oddly, that sentence is ok. English is a weird language. ;) No, it's not _that_ weird, German is even worse for non native speakers I think. :) Glad to have English spell-checking in Firefox 2.0 now. > You can fix the summary on import. Done. > Don't forget to close this NEXTRELEASE once it's been imported and built. Done. Closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 11:54 EST --- Yeah, desktop-file-install isn't needed here. Sorry about that. Oddly, that sentence is ok. English is a weird language. ;) I don't see any further blockers here, so this package is APPPROVED. You can fix the summary on import. Don't forget to close this NEXTRELEASE once it's been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981 --- Additional Comments From [EMAIL PROTECTED] 2006-12-22 08:24 EST --- (In reply to comment #2) > Issues: > > 1. The summary seems a bit odd to me: > "A plugin to use gnome-panel based applets inside the Xfce4 one" > How about: > "A plugin to use gnome-panel based applets inside the Xfce4 panel" Thanks, will change that. As I'm not a native english speaker, I wouldn't have recognized this. > 2. Your desktop file needs desktop-file-install: As I said in Bug #219986 Comment #3 I don't think so. Quoting from the guidelines: "This is mostly for the sake of menu-editing (which bases off of .desktop file/path names)." ... but nothing in the "Add Items to the Panel" dialog can be edited. BTW: Is the above sentence from the guidelines correct? "bases OFF OF .desktop file" sounds strange to me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981 --- Additional Comments From [EMAIL PROTECTED] 2006-12-21 23:57 EST --- OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 6a06c44b18a97626f44a240ad3bc3244 xfce4-xfapplet-plugin-0.1.0.tar.bz2 6a06c44b18a97626f44a240ad3bc3244 xfce4-xfapplet-plugin-0.1.0.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. i386/x86_64 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The summary seems a bit odd to me: "A plugin to use gnome-panel based applets inside the Xfce4 one" How about: "A plugin to use gnome-panel based applets inside the Xfce4 panel" 2. Your desktop file needs desktop-file-install: http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-12-21 23:29 EST --- I'd be happy to review this package. Expect a full review in a bit. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 219981] Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-xfapplet-plugin - A plugin to use gnome-panel based applets inside the Xfce4 one https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219981 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request:xfce4- |Review Request: xfce4- |xfapplet-plugin - A plugin |xfapplet-plugin - A plugin |to use gnome-panel based|to use gnome-panel based |applets inside the Xfce4 one|applets inside the Xfce4 one -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
