[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/show_bug.cgi?id=220922 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-01-17 19:07 EST --- Commited to CVS and built properly, closing with NEXTRELEASE. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:53 EST --- reviewed two review requests with errors bz20 bz222326 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: geany - a lightweight gtk2 based IDE
Alias: geany
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922
--- Additional Comments From [EMAIL PROTECTED] 2007-01-08 13:38 EST ---
REVIEW CHECKLIST
- rpmlint output
W: geany devel-file-in-non-devel-package /usr/share/geany/filetypes.c
Okay, see comment #7
- package meets package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec file is legible
- sources match upstream
2ffaae9b0fa807bdd4be0e6ec0f4a2e5 geany-0.10.tar.bz2
- package successfully compiles and builds on x86_64 FC6
- all build dependencies listed in BR
- locales handled properly
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by default packages
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- package contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
- no .la files
- contains proper .desktop file
- package does not own files or directories owned by other packages
*** APPROVED ***
Since you are not yet sponsered, I want to see a couple package reviews from you
before blocking FE-ACCEPT.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2007-01-04 17:58 EST --- Ok i uploaded a new -2 package with the changelog updated and such. SPEC: http://www.toxicpanda.com/geany.spec SRPM: http://www.toxicpanda.com/geany-0.10-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: geany - a lightweight gtk2 based IDE
Alias: geany
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922
--- Additional Comments From [EMAIL PROTECTED] 2007-01-02 15:34 EST ---
Ok new SPEC file and SRPM uploaded to the same place its always been.
-fixed the mixed spaces/tabs problem
-added sed command to %install to fix the ScintillaLicense.txt eol encoding
-fixed the docs so they are installed into doc/%{name}-%{version}
-added an rm pixmaps/geany.ico, its only for windows installations
the only rpmlint error thats left is a bogus one about filetypes.c not being
in a devel package, and that doesn't apply as its just the syntax
specifications for C for geany.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: geany - a lightweight gtk2 based IDE
Alias: geany
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922
--- Additional Comments From [EMAIL PROTECTED] 2006-12-30 18:14 EST ---
Josef: Looked a little deeper into this package and it is installing
documentation files in /usr/share/doc/%{name} _and_
/usr/share/doc/%{name}-%{version}. I attempted to add
--docdir=%{_docdir}/%{name}-%{version} but this did not work either. All the
documentation should go in the same directory and be set as %doc files. For
now, I would suggest moving the files out of %{_docdir}/%{name} in the %install
section after they have been installed. Just move the files to . and then
include them in %doc. Be sure to add a comment above the mv command indicating
that --docdir is not working in %configure.
Please also fix these rpmlint warnings:
W: geany mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 39)
W: geany wrong-file-end-of-line-encoding
/usr/share/doc/geany/ScintillaLicense.txt
Fixing end of line encodings is typically done with sed.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2006-12-29 17:05 EST --- hmm, for some reason I nuked all of the other BR's that are supposed to be there. Fixed that and added vte-devel for the virtual-terminal stuff that comes with geany. Same url as above for updated src.rpm and spec file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2006-12-28 18:11 EST --- Created an attachment (id=144508) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=144508action=view) patch to spec file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2006-12-28 18:17 EST --- Seems you're a new contributor, so you'll need a sponsor. In the meantime, here are a couple of things (not exhaustive) that needs to be fixed with the spec file; 1. Your package includes a .desktop file, and that needs to be properly install with desktop-file-install, and include a Buildrequire on desktop-file-utils. 2. Locales needs to be installed using the %find_lang macro. 3. You also likely need another BR on gettext (because of the locales). Also the Requires on glib, gtk, and pango are not necessary, they are automatically pulled in by rpm. I've attached a patch to your spec file that fix these issues. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| Alias||geany --- Additional Comments From [EMAIL PROTECTED] 2006-12-28 18:21 EST --- Deji: Thanks for the patch and comments. I've already mentioned these problems to Josef, as I'm in the process of sponsering him. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geany - a lightweight gtk2 based IDE Alias: geany https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922 --- Additional Comments From [EMAIL PROTECTED] 2006-12-28 18:23 EST --- ahh ok thanks much, I was kind of confused how to handle the desktop file. I have updated the src.rpm and the spec file, its at the same location Spec URL: http://www.toxicpanda.com/geany.spec SRPM URL: http://www.toxicpanda.com/geany-0.10-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
