[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-06-17 13:13 EST --- Thanks, everyone! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 --- Additional Comments From [EMAIL PROTECTED] 2007-06-16 11:23 EST --- From cvs commit log: Requires(post): desktop-file-utils Requires(postun): desktop-file-utils However, there is no %post or %postun. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-06-15 10:32 EST --- New Package CVS Request === Package Name: kodos Short Description: Visual regular expression editor Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-06-15 23:41 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
[EMAIL PROTECTED] changed:
What|Removed |Added
OtherBugsDependingO|163778 |
nThis||
Flag|fedora-review- |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2007-06-12 16:41 EST ---
Looks good to me. I would change:
%{_bindir}/*
%{python_sitelib}/*
%{_datadir}/applications/*
to:
%{_bindir}/kodos
%{_python_sitelib}/kodos/
%{_datadir}/applications/fedora-kodos.desktop
because personally I like to list things out. Helps detect when things change.
But I'll leave that up to your preference.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |.org) | --- Additional Comments From [EMAIL PROTECTED] 2007-06-10 17:34 EST --- Sorry for the delay, again. I swear it will be speedy from now on. :) http://blues.mcgill.ca/~icon/fe/kodos.spec http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-3.el5.wsg.src.rpm Cheers! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||fedora-review-, ||needinfo?([EMAIL PROTECTED] ||.org) --- Additional Comments From [EMAIL PROTECTED] 2007-03-12 12:49 EST --- Good: - rpmlint checks return: * - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime Worrisome: - There is no license/copyright/author information in the source files themselves. Please ping upstream about getting this added. Not a blocker per se, since the project clearly inteads to be GPLv2. Fix: - No need for X-Fedora in desktop-file-install - No need for update-desktop-database - no MimeType key in .desktop file (http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]| |.org) | --- Additional Comments From [EMAIL PROTECTED] 2007-03-11 11:39 EST --- I apologize for the delay. This is tested to build in mock, pass all rpmlint checks, and known to work. :) http://blues.mcgill.ca/~icon/fe/kodos.spec http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-2.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED] ||.org) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-30 13:45 EST --- Mostly looks good, full review to follow but thought I'd note this first: # rpmlint -i kodos E: kodos non-executable-script /usr/lib/python2.4/site-packages/kodos/kodos.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. I think you want to pull the shebang. Or, perhaps not even package it as it is basically the same as /usr/bin/kodos? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225345] Review Request: kodos - Visual regular expression editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kodos - Visual regular expression editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345 --- Additional Comments From [EMAIL PROTECTED] 2007-01-30 14:01 EST --- mock build fails: + desktop-file-install --vendor fedora --dir /var/tmp/kodos-2.4.9-1.fc6-root-mockbuild/usr/share/applications --add-category X-Fedora /builddir/build/SOURCES/kodos.desktop /var/tmp/rpm-tmp.24776: line 36: desktop-file-install: command not found Looks like you need: BuildRequires: desktop-file-utils -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
