[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-08-29 14:53 EST --- Package Change Request == Package Name: ack New Branches: EL-4 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 Bug 225368 depends on bug 225365, which changed state. Bug 225365 Summary: Review Request: perl-File-Next - File-finding iterator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225365 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ack - Grep-like text finder
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368
--- Additional Comments From [EMAIL PROTECTED] 2007-02-12 09:46 EST ---
Requires: perl(File::Next) = 0.38
That one is automatically set by rpmbuild already, isn't it?
%setup -q -n ack-%{version}
-n %{name}-%{version} is automatic already
make %{?_smp_mflags}
SMP make flags in a noarch build are superfluous.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-12 09:54 EST --- How about getting %check make test included in the package? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-12 11:41 EST --- (In reply to comment #5) SMP make flags in a noarch build are superfluous. Not necessarily, they don't have anything to do with archs per se. Granted, noarch packages benefit from parallel builds much less often than eg. ones that invoke a C compiler. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-12 12:53 EST --- Right, but with a 34 KB noarch package and no costly computations during %build, there is no gain to expect on a MP system. The risk is greater than the potential benefit. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-12 14:12 EST --- I left out the %check block because the tests fail when run without a terminal. This is a bug in the tests in that they assume that they are run from a terminal. The tests pass when run normaly. I entered a bug upstream to fix the problem. http://rt.cpan.org/Public/Bug/Display.html?id=24670 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ack - Grep-like text finder
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368
--- Additional Comments From [EMAIL PROTECTED] 2007-02-12 14:19 EST ---
Requires: perl(File::Next) = 0.38
That one is automatically set by rpmbuild already, isn't it?
I removed the manual one.
%setup -q -n ack-%{version}
-n %{name}-%{version} is automatic already
That was an artifact of renaming the package.
Spec URL: http://znark.com/fedora/ack.spec
SRPM URL: http://znark.com/fedora/ack-1.56-4.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-12 23:32 EST --- I rechecked the new release in mock. It built fine. rpmlint is silent. So new package is ok. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-12 23:37 EST --- Thanks Michael for your comments. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-02-11 23:30 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url d2c8750f35ae8be79956958e2b653e32 ack-1.56.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: perl(App::Ack) = 1.56 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-10 23:01 EST --- I chose to use ack as the package name because it is primarily an application. Also, the other choices were perl-ack looks like a pragma, or perl-App-Ack which is non-standard and hard to find. Fixed Source URL. Spec URL: http://znark.com/fedora/ack.spec SRPM URL: http://znark.com/fedora/ack-1.56-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-09 01:08 EST --- any reason for not naming this package's name starting with perl- ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 --- Additional Comments From [EMAIL PROTECTED] 2007-02-09 01:09 EST --- Source URL not working. check that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225368] Review Request: ack - Grep-like text finder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ack - Grep-like text finder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225368 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||225365 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
