[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag||fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-08-01 15:25 EST --- One of the pictures did have a PreviewImage on it, but it was easy enough to remove. Did my own CVS for this package: Package Name: gnome-screensaver-frogs Short Description: GNOME Screensaver Slideshow of Frogs Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 EL-4 EL-5 InitialCC: Built too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 --- Additional Comments From [EMAIL PROTECTED] 2007-07-30 05:40 EST --- I apologize for not reviewing the package for such long time. This is a really big and complex package that's why it took so long for me. What was not clear to me was the copyright/license for each of the the photos. It is not clear who authored which picture, and what is the copying policy for it. Second one was kind of a pseudo-security issue -- I haven't look at it yet, but are you sure none of the pictures contain EXIF thumbnail of an uncropped or unprocessed photo? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 --- Additional Comments From [EMAIL PROTECTED] 2007-07-30 08:01 EST --- There's a README file, which lists the copyright/license for each of the photos, and the author. As to the EXIF thumbnail, I didn't even think to check. I'll do that before committing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-29 16:40 EST --- - rpmlint checks return: # rpmlint ~/gnome-screensaver-frogs-0.2-2.src.rpm W: gnome-screensaver-frogs invalid-license CC Attribution 2.0/CC Attribution-ShareAlike 2.0/Public Domain # rpmlint /home/wolfy/reports/gnome-screensaver-frogs/gnome-screensaver-frogs-0.2-2.noarch.rpm W: gnome-screensaver-frogs invalid-license CC Attribution 2.0/CC Attribution-ShareAlike 2.0/Public Domain It's the first time I see several licenses listed in the License tag, but since all of them are GPL compatible and you are the expert in this area, I'll trust you. - package meets naming guidelines - package meets packaging guidelines - license (CC Attribution 2.0/CC Attribution-ShareAlike 2.0/Public Domain ) OK, text in %doc, matches source, full list of files + corresponding licenses included - spec file legible, in am. english - source matches upstream - nothing to compile, the package is just a collection of pictures - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok [*] - %clean ok - macro use consistent - only content (pictures) - no need for -docs - nothing in %doc affects runtime - the included .desktop file is installed under the gnome screenserver hierarchy Note: [*] I would have preferred %defaultattr(-,root,root,-) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-07-28 11:27 EST --- Is this one really being reviewed? I see no comments from the person it's assigned to. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 --- Additional Comments From [EMAIL PROTECTED] 2007-07-28 12:23 EST --- I'd really like a review on this. Should take about 12 seconds. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium --- Additional Comments From [EMAIL PROTECTED] 2007-05-24 13:59 EST --- So, yes, I'm for real. I'm aware of the Pictures folder, but I wanted to make something so other people could get a set of Frog pictures as a screensaver. This is freely redistributable content which enhances the Fedora user experience. New SRPM: http://people.redhat.com/tcallawa/gnome-screensaver-frogs/gnome-screensaver-frogs-0.2-1.fc7.src.rpm New SPEC: http://people.redhat.com/tcallawa/gnome-screensaver-frogs/gnome-screensaver-frogs.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 --- Additional Comments From [EMAIL PROTECTED] 2007-05-24 14:08 EST --- I totally forgot to make the fixes you pointed out. New SRPM: http://people.redhat.com/tcallawa/gnome-screensaver-frogs/gnome-screensaver-frogs-0.2-2.src.rpm New SPEC: http://people.redhat.com/tcallawa/gnome-screensaver-frogs/gnome-screensaver-frogs.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716 --- Additional Comments From [EMAIL PROTECTED] 2007-02-25 16:53 EST --- Hint 1 : In GNOME screensaver, you can select the Pictures folder screensaver, which should allow you to trivially have a slideshow of all pictures in a given directory, which should pretty much do what you want, without requiring an entire package. Hint 2 : The Pictures folder screensaver seems pretty broken and/or limited since it doesn't seem to be configurable from the GUI, nor can one figure out where the pictures should go in by default. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225716] Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow of Frogs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-screensaver-frogs - GNOME Screensaver Slideshow
of Frogs
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225716
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-02-13 13:36 EST ---
You might want to add -p to the install lines, in order to preserve the original
file timestamps between rebuilds.
Also, I see no point in having the %{?dist} tag for this 6MB noarch package, as
it would be better to hardlink it across Fedora releases.
Oh, and... is this package for real? :-)
If it is, I'll take the time to look at it closer and do a proper review ;-)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
