[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-06 06:09:12 EDT --- Nothing further, let's close it. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 Vitezslav Crhonek vcrho...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 --- Comment #5 from Vitezslav Crhonek vcrho...@redhat.com 2009-02-06 05:42:34 EDT --- (In reply to comment #4) (In reply to comment #3) kbd.src:20: W: unversioned-explicit-obsoletes console-tools kbd.src:20: W: unversioned-explicit-obsoletes open kbd.src:21: W: unversioned-explicit-provides console-tools kbd.src:21: W: unversioned-explicit-provides open OK, Obsoletes is very historical here and it's probably safe to remove it, I'm just not sure about Provides... I'm not able to find good information on Provides/Obsoletes (if console-tools and open Provides are needed by other some package), what do you think? According to: [wo...@wolfy tmp]$ repoquery --whatrequires open --repoid=development [wo...@wolfy tmp]$ repoquery --whatrequires console-tools --repoid=development you can drop the Provides, too. No one seems to require them. Fixed. kbd.src:73: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz kbd.src:76: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz kbd.src:80: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz kbd.src:109: E: hardcoded-library-path in /lib/kbd We want /lib/kbd for every architecture, so I'll not change this. OK. kbd.src: W: no-url-tag There's no kbd homepage. How about http://ftp.altlinux.org/pub/people/legion/kbd ? Well, same URL is in source... But you're probably right, it's better for users than nothing. Fixed. At least the COPYING file from the root dir should be included as %doc. I suggest to also add doc/dvorak I agree with COPYING, but disagree with doc/dvorak. I think people that already are using dvorak don't need this kind of info and others much less:) Well, say I'd like to give Dvorak a spin and I'll use it side by side with the normal QWERTY layout for a while. Wouldn't I need the docs? Having them on my system might be more convenient than browsing the net for them. Fine, I see it might be useful, so it's added. All changes are written to the CVS, let me know if you have anything else. Thanks for review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 --- Comment #3 from Vitezslav Crhonek vcrho...@redhat.com 2009-02-05 10:17:41 EDT --- (In reply to comment #1) Hi, you are right, I'm maintaining kbd currently. rpmlint is not really happy at all: rpmlint of source RPM: kbd.src:20: W: unversioned-explicit-obsoletes console-tools kbd.src:20: W: unversioned-explicit-obsoletes open kbd.src:21: W: unversioned-explicit-provides console-tools kbd.src:21: W: unversioned-explicit-provides open OK, Obsoletes is very historical here and it's probably safe to remove it, I'm just not sure about Provides... I'm not able to find good information on Provides/Obsoletes (if console-tools and open Provides are needed by other some package), what do you think? kbd.src:23: E: prereq-use initscripts = 5.86-1 Fixed (changed to plain Requires). kbd.src:73: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz kbd.src:76: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz kbd.src:80: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz kbd.src:109: E: hardcoded-library-path in /lib/kbd We want /lib/kbd for every architecture, so I'll not change this. kbd.src: W: no-url-tag There's no kbd homepage. rpmlint of kbd: kbd.x86_64: W: file-not-utf8 /usr/share/doc/kbd-1.15/ChangeLog Fixed. kbd.x86_64: W: no-url-tag See above. I think that --localedir=/usr/share/locale should be replaced with --localedir=%_datadir/locale Fixed. At least the COPYING file from the root dir should be included as %doc. I suggest to also add doc/dvorak I agree with COPYING, but disagree with doc/dvorak. I think people that already are using dvorak don't need this kind of info and others much less:) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 --- Comment #4 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-05 14:28:40 EDT --- (In reply to comment #3) kbd.src:20: W: unversioned-explicit-obsoletes console-tools kbd.src:20: W: unversioned-explicit-obsoletes open kbd.src:21: W: unversioned-explicit-provides console-tools kbd.src:21: W: unversioned-explicit-provides open OK, Obsoletes is very historical here and it's probably safe to remove it, I'm just not sure about Provides... I'm not able to find good information on Provides/Obsoletes (if console-tools and open Provides are needed by other some package), what do you think? According to: [wo...@wolfy tmp]$ repoquery --whatrequires open --repoid=development [wo...@wolfy tmp]$ repoquery --whatrequires console-tools --repoid=development you can drop the Provides, too. No one seems to require them. kbd.src:73: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz kbd.src:76: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz kbd.src:80: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz kbd.src:109: E: hardcoded-library-path in /lib/kbd We want /lib/kbd for every architecture, so I'll not change this. OK. kbd.src: W: no-url-tag There's no kbd homepage. How about http://ftp.altlinux.org/pub/people/legion/kbd ? At least the COPYING file from the root dir should be included as %doc. I suggest to also add doc/dvorak I agree with COPYING, but disagree with doc/dvorak. I think people that already are using dvorak don't need this kind of info and others much less:) Well, say I'd like to give Dvorak a spin and I'll use it side by side with the normal QWERTY layout for a while. Wouldn't I need the docs? Having them on my system might be more convenient than browsing the net for them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro Flag||fedora-review? --- Comment #1 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-03 19:13:13 EDT --- rpmlint is not really happy at all: rpmlint of source RPM: kbd.src:20: W: unversioned-explicit-obsoletes console-tools kbd.src:20: W: unversioned-explicit-obsoletes open kbd.src:21: W: unversioned-explicit-provides console-tools kbd.src:21: W: unversioned-explicit-provides open kbd.src:23: E: prereq-use initscripts = 5.86-1 kbd.src:73: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz kbd.src:76: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz kbd.src:80: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz kbd.src:109: E: hardcoded-library-path in /lib/kbd kbd.src: W: no-url-tag rpmlint of kbd: kbd.x86_64: W: file-not-utf8 /usr/share/doc/kbd-1.15/ChangeLog kbd.x86_64: W: no-url-tag I think that --localedir=/usr/share/locale should be replaced with --localedir=%_datadir/locale At least the COPYING file from the root dir should be included as %doc. I suggest to also add doc/dvorak -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225958] Merge Review: kbd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225958 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added CC||vcrho...@redhat.com --- Comment #2 from manuel wolfshant wo...@nobugconsulting.ro 2009-02-03 19:14:27 EDT --- Seems like the real maintainer is not mitr any more... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
