[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226034
--- Comment #24 from Bastien Nocera bnoc...@redhat.com 2009-06-10 10:54:46
EDT ---
(In reply to comment #22)
I also noticed that there is one occurrence of rm that should be converted to
%{__rm} for macro consistency.
Done
(In reply to comment #7)
I did a full review on this package. Everything seems fine except
* docs/mb_howto.txt should be included among %doc, or maybe in devel's %doc
Done
* the examples directory should be included in devel's %doc
Done
Other than these two things the package yields Fedora Guidelines.
A question: Isn't it time to rename this package as libmusicbrainz2 and call
libmusicbrainz3 as libmusicbrainz? Is there a particular reason why this is
not
done yet?
This would be a pretty pointless shuffling of package names.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #25 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-06-10 13:16:39 EDT --- Thanks! The %doc docs/mb_howto.txt examples/README.examples examples/*.c examples/*.cpp line must come after %defattr(-,root,root,-) Afaict this is the only outstanding issue left. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #26 from Bastien Nocera bnoc...@redhat.com 2009-06-10 13:21:56 EDT --- Done in -10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #27 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-06-10 13:34:00 EDT --- Yay! All good. -- This merge review (libmusicbrainz) is APPROVED by oget -- Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #23 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-06-09 15:06:21 EDT --- ping? no one wants to fix the trivial things I pointed in comments #7 and #22 ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226034
--- Comment #22 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04
01:47:48 EDT ---
Could you folks update the package according to comment #7 so we can close the
merge review?
I also noticed that there is one occurrence of rm that should be converted to
%{__rm} for macro consistency.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added CC||al...@users.sourceforge.net --- Comment #17 from Alex Lancaster al...@users.sourceforge.net 2009-02-20 00:34:19 EDT --- listen also still requires the old libmusicbrainz: bug #486523 please restore. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added Blocks||486523 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #18 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-02-20 00:46:42 EDT --- I don't think it is removed. Please see: https://www.redhat.com/archives/fedora-devel-list/2009-February/msg01486.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #19 from Alex Lancaster al...@users.sourceforge.net 2009-02-20 01:08:14 EDT --- It was removed from last night's rawhide, at least temporarily: http://koji.fedoraproject.org/mash/rawhide-20090219/logs/repodiff Removed package libmusicbrainz Removed package libtunepimp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #20 from Alex Lancaster al...@users.sourceforge.net 2009-02-20 01:18:29 EDT --- OK, looks like they were restored in CVS. I'm going to rebuild them for rawhide now, since it seems that Jesse unblocked them from rawhide. Hopefully they'll make it into tomorrow's rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #21 from Alex Lancaster al...@users.sourceforge.net 2009-02-20 01:21:52 EDT --- I guess if they are unblocked, it'll revert to the F-10 version of libmusicbrainz and libtunepimp, so it should at least fix the broken deps. Look like libtunepimp doesn't rebuild from source in any case: http://koji.fedoraproject.org/koji/taskinfo?taskID=1141627 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX --- Comment #15 from Rex Dieter rdie...@math.unl.edu 2009-01-23 08:32:02 EDT --- I see no objections, I'll move forward on EOL'ing these asap. A libmusicbrainz3 pkg rename can be reconsidered at a later date. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|WONTFIX | --- Comment #16 from Rex Dieter rdie...@math.unl.edu 2009-01-23 08:52:21 EDT --- Damn, looks like the new kscd in kdemultimedia-4.2.x has a hard-dep on libmusicbrainz... the best laid plans go awry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #14 from Rex Dieter rdie...@math.unl.edu 2008-12-12 12:27:19 EDT --- OK, new proposal: EOL libmusicbrainz (libtunepimp) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #8 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-12-10 14:05:03 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #9 from Rex Dieter [EMAIL PROTECTED] 2008-12-10 14:18:55 EDT --- wrt renaming? I guess it could be considered (for F-11), Bastien what do you think? (I'll take care of the other items from comment #7) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #10 from Rex Dieter [EMAIL PROTECTED] 2008-12-10 14:25:14 EDT --- Or maybe we can just libmusicbrainz3 - libmusicbrainz (and EOL existing libmusicbrainz/libtunepimp). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #11 from Rex Dieter [EMAIL PROTECTED] 2008-12-10 14:28:22 EDT --- Spoke too soon perhaps, seems there's quite a bit of stuff still depending on libmusicbrainz(2): libtunepimp(1) sound-juicer k3b(1) gstreamer-plugins-bad kdemultimedia(1) rhythmbox(2) (1) I do these, and it wouldn't break my heart if libmusicbrainz support went away. (2) Wierd, rhythmbox seems to link to *both* libmusicbrainz/libmusicbrainz3. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #12 from Bastien Nocera [EMAIL PROTECTED] 2008-12-10 17:24:13 EDT --- I don't see the point of renaming the library: - it's not user-facing - libmusicbrainz (2.x) will soon be useless when MB turn off their old servers - libmusicbrainz3 is what it's called upstream Sound-juicer and rhythmbox are already ported to libmusicbrainz3 and use both. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Comment #13 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-12-10 21:23:22 EDT --- (In reply to comment #12) - libmusicbrainz3 is what it's called upstream I don't think that is the case anymore: http://musicbrainz.org/doc/libmusicbrainzDownload But if it is going to cause lots of trouble we can leave things as are. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Orcan 'oget' Ogetbil [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Alias||libmusicbrainz Flag||fedora-review? --- Comment #7 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-10-29 00:19:19 EDT --- I did a full review on this package. Everything seems fine except * docs/mb_howto.txt should be included among %doc, or maybe in devel's %doc * the examples directory should be included in devel's %doc Other than these two things the package yields Fedora Guidelines. A question: Isn't it time to rename this package as libmusicbrainz2 and call libmusicbrainz3 as libmusicbrainz? Is there a particular reason why this is not done yet? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Brennan Ashton [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226034 Brennan Ashton [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libmusicbrainz https://bugzilla.redhat.com/show_bug.cgi?id=226034 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-09-13 10:18 EST --- I'm maintaining libtunepimp, would you like to comaintain these together? (If so, I can help review this) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libmusicbrainz https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Additional Comments From [EMAIL PROTECTED] 2007-09-13 11:19 EST --- libtunepimp is deprecated, isn't it? I'd be more than happy to have a libmusicbrainz co-maintainer, but I'm not really interested in maintaining a deprecated library :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libmusicbrainz https://bugzilla.redhat.com/show_bug.cgi?id=226034 --- Additional Comments From [EMAIL PROTECTED] 2007-09-13 13:32 EST --- doh, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226034] Merge Review: libmusicbrainz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libmusicbrainz https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226034 [EMAIL PROTECTED] changed: What|Removed |Added CC|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-02-08 06:11 EST --- New Initial Owner: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
