[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226152 --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2009-08-07 05:04:19 EDT --- I have committed changes in cvs. Can you build new release in rawhide? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226152 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ --- Comment #9 from Parag AN(पराग) panem...@gmail.com 2009-08-07 05:28:23 EDT --- http://koji.fedoraproject.org/koji/buildinfo?buildID=126147 Package built in rawhide is now APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226152 --- Comment #7 from Parag AN(पराग) panem...@gmail.com 2009-08-07 01:01:59 EDT --- I guess I can commit as you have reviewed patch and allowed me to do so. Will commit now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226152
--- Comment #6 from Parag AN(पराग) panem...@gmail.com 2009-07-14 09:51:35
EDT ---
(In reply to comment #5)
Looks good other than:
-Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing
httpd-devel)
+Requires: httpd-mmn
which is a regression - leave that line as-is.
I didn't get how is this regression and why we need that much long line in
Requires?
As I am reviewing this package, I cannot apply changes to this package even if
I don't need co-ownership for this package as I am in provenpackager group.
Can you commit changes then?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226152
Joe Orton jor...@redhat.com changed:
What|Removed |Added
Flag|needinfo?(jor...@redhat.com |
|) |
--- Comment #5 from Joe Orton jor...@redhat.com 2009-07-13 08:31:19 EDT ---
Looks good other than:
-Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing
httpd-devel)
+Requires: httpd-mmn
which is a regression - leave that line as-is.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226152 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-07-06 02:03:06 EDT --- staring review for this package.Also I would like to needinfo package owner so that he will not miss about this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226152 --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2009-07-06 02:09:46 EDT --- Created an attachment (id=350571) -- (https://bugzilla.redhat.com/attachment.cgi?id=350571) modified spec file Can you commit attached patch that fixes most of things according to packaging guidelines? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226152 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||needinfo?(jor...@redhat.com ||) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226152
--- Comment #3 from Parag AN(पराग) panem...@gmail.com 2009-07-06 05:23:32
EDT ---
(From update of attachment 350571)
--- mod_auth_mysql.spec2009-02-26 07:23:21.0 +0530
+++ mod_auth_mysql-new.spec2009-07-06 11:33:45.0 +0530
@@ -1,18 +1,18 @@
Summary: Basic authentication for the Apache web server using a MySQL database
Name: mod_auth_mysql
Version: 3.0.0
-Release: 8
+Release: 9%{?dist}
Epoch: 1
Group: System Environment/Daemons
URL: http://modauthmysql.sourceforge.net/
-Source: mod_auth_mysql-%{version}.tar.gz
+Source:
http://downloads.sourceforge.net/modauthmysql/mod_auth_mysql-%{version}.tar.gz
Source2: auth_mysql.conf
Patch0: mod_auth_mysql-3.0.0-apr1x.patch
Patch1: mod_auth_mysql-3.0.0-disable.patch
License: ASL 1.1
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: httpd-devel, mysql-devel
-Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing
httpd-devel)
+Requires: httpd-mmn
%description
mod_auth_mysql can be used to limit access to documents served by a
@@ -28,17 +28,17 @@
-c %{name}.c -L%{_libdir}/mysql -lmysqlclient
%install
-[ $RPM_BUILD_ROOT != / ] rm -rf $RPM_BUILD_ROOT
+rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT%{_libdir}/httpd/modules
install -m755 .libs/%{name}.so $RPM_BUILD_ROOT%{_libdir}/httpd/modules
# Install the config file
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d
-install -m 644 $RPM_SOURCE_DIR/auth_mysql.conf \
+install -p -m 644 %{SOURCE1} \
$RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d/
%clean
-[ $RPM_BUILD_ROOT != / ] rm -rf $RPM_BUILD_ROOT
+rm -rf $RPM_BUILD_ROOT
%files
%defattr(-,root,root)
@@ -47,6 +47,9 @@
%config(noreplace) %{_sysconfdir}/httpd/conf.d/*.conf
%changelog
+* Mon Jul 06 2009 Joe Orton jor...@redhat.com 1:3.0.0-9
+- Spec cleanup
+
* Wed Feb 25 2009 Fedora Release Engineering
rel-...@lists.fedoraproject.org - 1:3.0.0-8
- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226152] Merge Review: mod_auth_mysql
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226152
--- Comment #4 from Parag AN(पराग) panem...@gmail.com 2009-07-06 05:25:17
EDT ---
updated attachment as rpmlint complained on srpm that results to change
$RPM_SOURCE_DIR/auth_mysql.conf
to
%{SOURCE1}
as done in above comment.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
