[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226165 Dan Horák d...@danny.cz changed: What|Removed |Added CC||d...@danny.cz --- Comment #5 from Dan Horák d...@danny.cz 2009-12-02 05:46:09 EDT --- The stinit initscript was recently updated in F-12 and rawhide (see bug 541592 for details) and it doesn't start any daemon, but it does only a one-time initialization of tape devices, so I think it can live as it is. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226165 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #6 from Miroslav Lichvar mlich...@redhat.com 2009-12-02 06:05:55 EDT --- Ok, thanks. The package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226165
Miroslav Lichvar mlich...@redhat.com changed:
What|Removed |Added
CC||dho...@redhat.com
Flag||fedora-review?
--- Comment #4 from Miroslav Lichvar mlich...@redhat.com 2009-12-01 11:55:26
EDT ---
Review follows:
OK source files match upstream:
fdd5f5ec673c9f630a102ceff7612774 mt-st-1.1.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock.
OK debuginfo package looks complete.
NO rpmlint is silent.
mt-st.x86_64: W: service-default-enabled /etc/rc.d/init.d/stinit
mt-st.x86_64: E: no-status-entry /etc/rc.d/init.d/stinit
mt-st.x86_64: W: no-reload-entry /etc/rc.d/init.d/stinit
mt-st.x86_64: E: subsys-not-used /etc/rc.d/init.d/stinit
mt-st.x86_64: W: incoherent-init-script-name stinit ('mt-st', 'mt-std')
Enabled by default and incoherent name are ok, but the script should be
probably updated to match the Fedora init script guidelines.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK scriptlets are sane.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226165 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added CC||mlich...@redhat.com AssignedTo|nob...@fedoraproject.org|mlich...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mt-st https://bugzilla.redhat.com/show_bug.cgi?id=226165 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-09-05 07:02 EST --- Package Change Request == Package Name: mt-st Updated Fedora Owners: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mt-st https://bugzilla.redhat.com/show_bug.cgi?id=226165 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mt-st https://bugzilla.redhat.com/show_bug.cgi?id=226165 --- Additional Comments From [EMAIL PROTECTED] 2007-09-05 07:14 EST --- Agreed with ownership transition. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226165] Merge Review: mt-st
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mt-st https://bugzilla.redhat.com/show_bug.cgi?id=226165 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? | --- Additional Comments From [EMAIL PROTECTED] 2007-09-05 09:10 EST --- canceling request, it's now ok (via pkgdb) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
