[Bug 226237] Merge Review: pcmciautils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pcmciautils https://bugzilla.redhat.com/show_bug.cgi?id=226237 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226237] Merge Review: pcmciautils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pcmciautils https://bugzilla.redhat.com/show_bug.cgi?id=226237 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo? | --- Additional Comments From [EMAIL PROTECTED] 2007-11-30 06:54 EST --- APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226237] Merge Review: pcmciautils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pcmciautils https://bugzilla.redhat.com/show_bug.cgi?id=226237 [EMAIL PROTECTED] changed: What|Removed |Added Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|ASSIGNED|NEEDINFO Flag||fedora-review+, needinfo? --- Additional Comments From [EMAIL PROTECTED] 2007-11-30 06:48 EST --- rpmlint gave pcmciautils.i386: W: obsolete-not-provided pcmcia-cs pcmciautils.i386: W: obsolete-not-provided kernel-pcmcia-cs you SHOULD use make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p to preserve timestamps. Rest looks ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226237] Merge Review: pcmciautils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pcmciautils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226237 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 09:30 EST --- done... please check pcmciautils-014-6.fc7 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226237] Merge Review: pcmciautils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pcmciautils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226237 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review? | --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 13:35 EST --- (In reply to comment #2) done... please check pcmciautils-014-6.fc7 The changes look good to me, but as said in comment 1: No PCMCIA hardware here so I'll leave rest of the review to someone else. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226237] Merge Review: pcmciautils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pcmciautils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226237 --- Additional Comments From [EMAIL PROTECTED] 2007-03-03 07:13 EST --- Doesn't use $RPM_OPT_FLAGS. A simple fix is to do 'make OPTIMIZATION=$RPM_OPT_FLAGS' instead of 'make' in %build but that trumps the upstream -Os vs -O2 selection. Not a big deal, I think, but if there's a compelling reason to use -Os, pcmciautils-fedora.patch could be changed to do this in order to preserve it: CFLAGS += $(RPM_OPT_FLAGS) $(OPTIMIZATION) -D_GNU_SOURCE URL tag missing, a suitable one could be eg. http://www.kernel.org/pub/linux/utils/kernel/pcmcia/pcmcia.html Are the pcmcia-cs and kernel-pcmcia-cs Obsoletes still needed? If no, drop; if yes, should be made versioned. No PCMCIA hardware here so I'll leave rest of the review to someone else. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
