[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #17 from Jaroslav Reznik jrez...@redhat.com 2009-02-04 03:34:26 EDT --- (In reply to comment #16) Thanks for your work. APPROVED. Ok, thank you for your great review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #18 from Parag AN(पराग) panem...@gmail.com 2009-02-05 00:37:18 EDT --- package is in rawhide. Closing this review now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #15 from Jaroslav Reznik jrez...@redhat.com 2009-02-03 09:24:24 EDT --- Updated package in Rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #16 from Parag AN(पराग) panem...@gmail.com 2009-02-04 01:45:58 EDT --- Thanks for your work. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #12 from Parag AN(पराग) panem...@gmail.com 2009-01-29 04:27:28 EDT --- from build.log you can see warning: File listed twice: /tftpboot/linux-install/msgs warning: File listed twice: /tftpboot/linux-install/msgs/boot.msg warning: File listed twice: /tftpboot/linux-install/msgs/expert.msg warning: File listed twice: /tftpboot/linux-install/msgs/general.msg warning: File listed twice: /tftpboot/linux-install/msgs/param.msg warning: File listed twice: /tftpboot/linux-install/msgs/rescue.msg warning: File listed twice: /tftpboot/linux-install/msgs/snake.msg warning: File listed twice: /tftpboot/linux-install/pxelinux.0 warning: File listed twice: /tftpboot/linux-install/pxelinux.cfg Please see http://fedoraproject.org/wiki/PackagingGuidelines#Duplicate_Files === You want to have in %files of -cmd as only %config(noreplace) /tftpboot/linux-install/ This will make all files under this /tftpboot/linux-install/ directory as configuration files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226463
--- Comment #13 from Parag AN(पराग) panem...@gmail.com 2009-01-29 04:35:41
EDT ---
2) also, gtk-update-icon-cache scriptlet should be
%post
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
3) Buildroot should be one of values from
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||fab...@bernewireless.net AssignedTo|nob...@fedoraproject.org|panem...@gmail.com --- Comment #14 from Fabian Affolter fab...@bernewireless.net 2009-01-29 08:49:54 EDT --- Added Parag as 'Assignee' because the review is in progress. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Flag|needinfo? | --- Comment #11 from Jaroslav Reznik jrez...@redhat.com 2009-01-28 10:41:20 EDT --- Sorry, it takes so long but now it's already built for rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=103 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag||needinfo? --- Comment #10 from Parag AN(पराग) panem...@gmail.com 2009-01-19 23:34:24 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #9 from Jaroslav Reznik jrez...@redhat.com 2009-01-09 11:34:56 EDT --- (In reply to comment #8) thats ok then. Do you got new package to complete review with fixes other issues? I have to prepare new minor upstream release to fix rpmlint warnings, so I hope packages will be ready Monday. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2009-01-08 23:39:16 EDT --- (In reply to comment #7) Well I'm looking to rpmlint output now. W: non-etc-or-var-file-marked-as-conffile I think it's fine - these files are config files which SHOULD NOT be replaced but are not located in /etc or /var. thats ok then. Do you got new package to complete review with fixes other issues? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #7 from Jaroslav Reznik jrez...@redhat.com 2009-01-05 10:41:41 EDT --- Well I'm looking to rpmlint output now. W: non-etc-or-var-file-marked-as-conffile I think it's fine - these files are config files which SHOULD NOT be replaced but are not located in /etc or /var. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #4 from Parag AN(पराग) panem...@gmail.com 2008-12-22 03:23:17 EDT --- Created an attachment (id=327623) -- (https://bugzilla.redhat.com/attachment.cgi?id=327623) patch to silent rpmlint output on srpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Parag AN(पराग) panem...@gmail.com 2008-12-22 03:29:50 EDT --- Still there are rpmlint output not silent on rpms system-config-netboot.noarch: E: non-executable-script /usr/share/system-config-netboot/pxeosdialog.py 0644 system-config-netboot.noarch: E: non-readable /usr/share/system-config-netboot/netboot_gtk.py 0750 system-config-netboot.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/netboot_gtk.py 0750 system-config-netboot.noarch: E: script-without-shebang /usr/share/system-config-netboot/netboot_gtk.py system-config-netboot.noarch: E: non-readable /usr/share/system-config-netboot/system-config-netboot.py 0750 system-config-netboot.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/system-config-netboot.py 0750 system-config-netboot.noarch: W: no-dependency-on usermode system-config-netboot.noarch: W: obsolete-not-provided redhat-config-netboot AND system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/pxeos.py 0750 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/pxeos.py 0750 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/pxeboot.py 0750 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/pxeboot.py 0750 system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/firsttime.py 0644 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/updateDiskless 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/updateDiskless 0700 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/syncfiles 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/syncfiles 0700 system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/diskless/diskless.init 0644 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/disklessrc 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/disklessrc 0700 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/mkdiskless 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/mkdiskless 0700 system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/diskless.py 0644 system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/boot.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/expert.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/general.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/param.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/rescue.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/snake.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/pxelinux.0 Suggestions:- 1) why some of above mentioned files are non-readable? you can make them readable. 2) For config files guidelines says http://fedoraproject.org/wiki/PackagingGuidelines#Configuration_files 3) Desktop files must be installed as per given http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage 4) Use following scriptlet for icon files https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #6 from Jaroslav Reznik jrez...@redhat.com 2008-12-22 15:04:54 EDT --- Ok, so it looks it needs more love, I'll take a deeper look to fix it. Sorry I didn't checked rpmlint, hoping package is in better condition... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 --- Comment #3 from Jaroslav Reznik jrez...@redhat.com 2008-12-19 06:43:59 EDT --- Thank you for cc'ing me here, issues are fixed now in devel. I'm only not sure if we really need smp_flags - it's noarch package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226463 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||jrez...@redhat.com, ||panem...@gmail.com --- Comment #2 from Parag AN(पराग) panem...@gmail.com 2008-12-19 02:37:08 EDT --- cc'ing current owner of this package jrez...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226463] Merge Review: system-config-netboot
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226463
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #1 from Fabian Affolter fab...@bernewireless.net 2008-12-15
06:14:05 EDT ---
Just some comments on this spec file
- Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
- Use parallel make (make %{?_smp_mflags})
- Is there a reason that %makeinstall is used?
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
