[Bug 226528] Merge Review: virt-manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226528
Mark McLoughlin mar...@redhat.com changed:
What|Removed |Added
Status|MODIFIED|CLOSED
CC||mar...@redhat.com
Resolution||CURRENTRELEASE
--- Comment #5 from Mark McLoughlin mar...@redhat.com 2009-01-23 14:50:44
EDT ---
Okay, fixes were:
-ln -s %{_bindir}/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name}
+ln -s ../bin/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name}
-%{_sysconfdir}/pam.d/%{name}
+%config(noreplace) %{_sysconfdir}/pam.d/%{name}
Closing
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226528] Merge Review: virt-manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: virt-manager https://bugzilla.redhat.com/show_bug.cgi?id=226528 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-01-10 18:34 EST --- Cole, could you take care of the above spec changes so we can get the review finished ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226528] Merge Review: virt-manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: virt-manager https://bugzilla.redhat.com/show_bug.cgi?id=226528 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Additional Comments From [EMAIL PROTECTED] 2008-01-10 21:06 EST --- These fixes will be in the new rawhide build virt-manager-0_5_3-1_fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226528] Merge Review: virt-manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: virt-manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226528 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226528] Merge Review: virt-manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: virt-manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226528 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226528] Merge Review: virt-manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: virt-manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226528 --- Additional Comments From [EMAIL PROTECTED] 2007-05-03 18:03 EST --- Review is based on http://koji.fedoraproject.org/packages/virt-manager/0.4.0/1.fc7/src/virt-manager-0.4.0-1.fc7.src.rpm Overall, specfile looks good, conforms with packaging guidelines rpmlint reports: W: virt-manager non-conffile-in-etc /etc/security/console.apps/virt-manager W: virt-manager non-conffile-in-etc /etc/gconf/schemas/virt-manager.schemas W: virt-manager non-conffile-in-etc /etc/pam.d/virt-manager The pam.d file should be marked as %config(noreplace); the others seem ok W: virt-manager symlink-should-be-relative /usr/bin/virt-manager /usr/bin/consolehelper Easy fix E: virt-manager explicit-lib-dependency librsvg2 It seems that that is ok; AFAICT, rpm won't be able to find this dependency. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
