[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/show_bug.cgi?id=227032 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2008-07-09 16:48 EST --- objectweb-asm is already in fedora... closing this as WONTFIX. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/show_bug.cgi?id=227032 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review+ | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-08-13 19:41 EST --- *** Bug 252045 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032 --- Additional Comments From [EMAIL PROTECTED] 2007-08-13 19:42 EST --- (In reply to comment #6) *** Bug 252045 has been marked as a duplicate of this bug. *** This package is still needed. Please file a CVS request and subsequently merge with spec from bug 252045 if possible. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2007-04-25 14:37 EST --- This package was originally an indirect dependency of maven2, but is no longer needed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |ASSIGNED Keywords||Reopened Resolution|WONTFIX | --- Additional Comments From [EMAIL PROTECTED] 2007-04-25 15:26 EST --- On second thought, I think I will keep this open. Although it is non-critical, it should really be added into Fedora at some point.. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032 --- Additional Comments From [EMAIL PROTECTED] 2007-02-14 20:07 EST --- New spec and srpm are here: http://people.redhat.com/dbhole/fedora/asm/ buildroot fixed source locations fixed encoding warnings fixed javadoc attributes fixed license file added and marked %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 227032] Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement adaptable systems
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: asm-1.5.3-2jpp - A code manipulation tool to implement
adaptable systems
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227032
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-02-13 12:02 EST ---
asm-1.5.3-2jpp.src.rpm
Legend:
OK: passes criteria
NO: fails criteria (errors included between -- markers)
NA: non applicable
??: unable to verify
MUST:
OK * package is named appropriately
OK - match upstream tarball or project name
OK - try to match previous incarnations in other distributions/packagers for
consistency
OK - specfile should be %{name}.spec
OK - non-numeric characters should only be used in Release (ie. cvs or
something)
OK - for non-numerics (pre-release, CVS snapshots, etc.), see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PackageRelease
OK - if case sensitivity is requested by upstream or you feel it should be
not just lowercase, do so; otherwise, use all lower case for the name
OK * is it legal for Fedora to distribute this?
OK - OSI-approved
OK - not a kernel module
OK - not shareware
OK - is it covered by patents?
OK - it *probably* shouldn't be an emulator
OK - no binary firmware
OK * license field matches the actual license.
OK * license is open source-compatible.
OK - use acronyms for licences where common
OK * specfile name matches %{name}
?? * verify source and patches (md5sum matches upstream, know what the patches
do)
- if upstream doesn't release source drops, put *clear* instructions on
how to generate the the source drop; ie.
# svn export blah/tag blah
# tar cjf blah-version-src.tar.bz2 blah
OK * skim the summary and description for typos, etc.
NO * correct buildroot
- should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
--
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
--
NO * if %{?dist} is used, it should be in that form (note the ? and %
locations)
NO * license text included in package and marked with %doc
--
included but not marked with %doc
--
OK * keep old changelog entries; use judgement when removing (too old?
useless?)
OK * packages meets FHS (http://www.pathname.com/fhs/)
NO * rpmlint on this package.srpm gives no output
- justify warnings if you think they shouldn't be there
--
$ rpmlint asm-1.5.3-2jpp.src.rpm
W: asm non-standard-group Development/Libraries/Java
E: asm unknown-key GPG#c431416d
W: asm mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 31)
--
OK * changelog should be in one of these formats:
* Fri Jun 23 2006 Jesse Keating [EMAIL PROTECTED] - 0.6-4
- And fix the link syntax.
* Fri Jun 23 2006 Jesse Keating [EMAIL PROTECTED] 0.6-4
- And fix the link syntax.
* Fri Jun 23 2006 Jesse Keating [EMAIL PROTECTED]
- 0.6-4
- And fix the link syntax.
OK * Packager tag should not be used
NO * Vendor tag should not be used
--
Vendor: JPackage Project
--
OK * use License and not Copyright
OK * Summary tag should not end in a period
NA * if possible, replace PreReq with Requires(pre) and/or Requires(post)
OK * specfile is legible
- this is largely subjective; use your judgement
NO * package successfully compiles and builds on at least x86
--
Cannot find build req objectweb-anttask. Exiting.
--
?? * BuildRequires are proper
- builds in mock will flush out problems here
- the following packages don't need to be listed in BuildRequires:
bash
bzip2
coreutils
cpio
diffutils
fedora-release (and/or redhat-release)
gcc
gcc-c++
gzip
make
patch
perl
redhat-rpm-config
rpm-build
sed
tar
unzip
which
OK * summary should be a short and concise description of the package
OK * description expands upon summary (don't include installation
instructions)
OK * make sure lines are = 80 characters
OK * specfile written in American English
OK * make a -doc sub-package if necessary
- see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b
NA * packages including libraries should exclude static libraries if possible
OK * don't use rpath
NA * config files should usually be marked with %config(noreplace)
NA * GUI apps should contain .desktop files
NA * should the package contain a -devel sub-package?
NO * use macros appropriately and consistently
- ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
--
...
(cd $RPM_BUILD_ROOT%{_javadir}/%{name} for jar in *-%{version}*; do \
ln -sf ${jar} ${jar/-%{version}/}; done)
...
--
OK * don't use %makeinstall
NA * locale data handling correct (find_lang)
- if
