[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-04-25 15:01 EST --- Imported, built, and all that goodness. Thanks for the review! :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-04-24 05:13 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url e9c25c357b0e2a62fa91493b818a538f Workflow-0.26.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test t/action...ok t/action_field.ok t/action_null..ok t/base.ok t/conditionok t/condition_evaluate...ok t/config...Use of uninitialized value in numeric eq (==) at t/config.t line 41. ok t/context..ok t/exceptionok t/factory..ok t/factory_subclass.ok t/history..ok t/persister_dbiUse of uninitialized value in concatenation (.) or string at /usr/lib/perl5/vendor_perl/5.8.8/DBD/Mock.pm line 531. ok t/persister_dbi_extra_data.ok t/persister_file...ok t/persister_random_id..ok t/persister_spops..skipped all skipped: SPOPS not installed t/persister_uuid...skipped all skipped: Data::UUID not installed t/stateok t/validatorok t/validator_has_required_field.ok t/validator_in_enumerated_type.ok t/validator_matches_date_formatok t/workflow.Use of uninitialized value in concatenation (.) or string at /usr/lib/perl5/vendor_perl/5.8.8/DBD/Mock.pm line 531. ok All tests successful, 2 tests skipped. Files=24, Tests=192, 10 wallclock secs ( 7.04 cusr + 0.79 csys = 7.83 CPU) + Provides: perl(Workflow) perl(Workflow::Action) perl(Workflow::Action::InputField) perl(Workflow::Action::Null) perl(Workflow::Base) perl(Workflow::Condition) perl(Workflow::Condition::Evaluate) perl(Workflow::Condition::HasUser) perl(Workflow::Config) perl(Workflow::Config::Perl) perl(Workflow::Config::XML) perl(Workflow::Context) perl(Workflow::Exception) perl(Workflow::Factory) perl(Workflow::History) perl(Workflow::Persister) perl(Workflow::Persister::DBI) perl(Workflow::Persister::DBI::AutoGeneratedId) perl(Workflow::Persister::DBI::ExtraData) perl(Workflow::Persister::DBI::SequenceId) perl(Workflow::Persister::File) perl(Workflow::Persister::RandomId) perl(Workflow::Persister::SPOPS) perl(Workflow::Persister::UUID) perl(Workflow::State) perl(Workflow::Validator) perl(Workflow::Validator::HasRequiredField) perl(Workflow::Validator::InEnumeratedType) perl(Workflow::Validator::MatchesDateFormat) + Requires: perl(:MODULE_COMPAT_5.8.8) perl(DBI) perl(Data::Dumper) perl(Data::UUID) perl(DateTime) perl(DateTime::Format::Strptime) perl(Exception::Class) perl(File::Spec::Functions) perl(Log::Log4perl) perl(Safe) perl(Workflow) perl(Workflow::Action) perl(Workflow::Action::InputField) perl(Workflow::Condition) perl(Workflow::Condition::Evaluate) perl(Workflow::Config) perl(Workflow::Context) perl(Workflow::Exception) perl(Workflow::Factory) perl(Workflow::History) perl(Workflow::Persister) perl(Workflow::Persister::DBI::AutoGeneratedId) perl(Workflow::Persister::DBI::SequenceId) perl(Workflow::Persister::RandomId) perl(Workflow::State) perl(Workflow::Validator) perl(Workflow::Validator::HasRequiredField) perl(XML::Simple) perl(base) perl(constant) perl(strict) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-04-24 10:56 EST --- New Package CVS Request === Package Name: perl-Workflow Short Description: Simple, flexible system to implement workflows Owners: [EMAIL PROTECTED] Branches: FC-5, FC-6, devel InitialCC: [EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Priority|normal |medium --- Additional Comments From [EMAIL PROTECTED] 2007-04-24 01:12 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-04-09 10:48 EST --- (In reply to comment #7) Is perl-Class-Fields and perl(SPOPS) is in Fedora or its submitted for review? Neither are. perl-SPOPS would depend on perl-Class-Fields, and perl-Class-Fields fails its own tests currently. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-04-09 00:10 EST --- Is perl-Class-Fields and perl(SPOPS) is in Fedora or its submitted for review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-04-07 16:06 EST --- Added perl(Data::UUID) and perl(SPOPS) as BRs; however, perl(SPOPS) is commented out as it isn't in Fedora yet, and depends on perl(Class::Fields) whose tests fail. If Class-Fields cleans itself up and perl(SPOPS) makes it into Fedora, I'll uncomment it... SRPM URL: http://home.comcast.net/~ckweyl/perl-Workflow-0.26-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Workflow.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-04-04 00:51 EST --- I think you should add perl(Data::UUID) and SPOPS as make test showed me t/persister_spops..skipped all skipped: SPOPS not installed t/persister_uuid...skipped all skipped: Data::UUID not installed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 Bug 231758 depends on bug 232612, which changed state. Bug 232612 Summary: Review Request: perl-Class-Observable - Allow other classes and objects to respond to events in yours https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232612 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 Bug 231758 depends on bug 231753, which changed state. Bug 231753 Summary: Review Request: perl-DBD-Mock - Mock database driver for testing https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231753 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 Bug 231758 depends on bug 231754, which changed state. Bug 231754 Summary: Review Request: perl-Class-Factory - Base class for dynamic factory classes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231754 What|Old Value |New Value Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-03-17 06:18 EST --- Your package is requiring perl(Data::UUID). This seems to be problematic which is why I filtered the requirement from my version. The license.txt for Data::UUID states: The license under which this code was originally released is unknown, although its release has been interpreted as its release under an open source license. Attempts to contact the original author are underway. -- rjbs, 2006-11-14 I'd suggest you do filter that requirement as it is optional according to the readme. Alternatively, review my package. :D Less work for you. About the docs, I solved that problem by just running tar and gzip on the example file and packaging that tar.gz file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-03-17 12:35 EST --- (In reply to comment #3) Your package is requiring perl(Data::UUID). This seems to be problematic which is why I filtered the requirement from my version. The license.txt for Data::UUID states: The license under which this code was originally released is unknown, although its release has been interpreted as its release under an open source license. Attempts to contact the original author are underway. -- rjbs, 2006-11-14 I'd suggest you do filter that requirement as it is optional according to the readme. Alternatively, review my package. :D Less work for you. Data::UUID I didn't worry about too much -- it's in extras, so presumptively the license is OK. If a package license is under question, then a bug should be filed, an audit conducted, etc; otherwise I'm going to trust, in good faith, the reviewer, packager, and rjbs :) got it right. About the docs, I solved that problem by just running tar and gzip on the example file and packaging that tar.gz file. Yeah, I've never actually been a fan of that... if the docs are too large to reasonably keep with the base package, then a -docs subpackage is in order. The point is well taken though -- looking back at the package, it's ~400k installed, ~220k of which is %doc. So, that's a large percentage of the package taken up by %doc, but still a fairly small amount of disk space overall. I could easily be talked into splitting them out into -docs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added Alias||perl-Workflow -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 Bug 231758 depends on bug 231755, which changed state. Bug 231755 Summary: Review Request: perl-Class-Observable - Allow other classes and objects to respond to events in yours https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231755 What|Old Value |New Value Resolution||DUPLICATE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||232612 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows Alias: perl-Workflow https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-03-16 23:32 EST --- *** Bug 232734 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758 --- Additional Comments From [EMAIL PROTECTED] 2007-03-11 04:06 EST --- Note the rpmlint warning of: [EMAIL PROTECTED] noarch]$ rpmlint perl-Workflow-0.26-1.fc6.noarch.rpm W: perl-Workflow doc-file-dependency /usr/share/doc/perl-Workflow-0.26/eg/ticket/App/Web.pm perl(XML::Simple) ...is expected. perl(XML::Simple) is an actual requirement. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
