[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-04-22 04:16 EST --- Hi Alex, As discussed by mail, I'll take EPEL branches ownership. Regards, Xavier Package Change Request == Package Name: perl-XML-Writer New Branches: EL-4 EL-5 Updated EPEL Owners: xavierb Updated EPEL CC: xavierb alexlan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2008-04-22 04:28 EST --- Doh, I didn't add Alex to the owners... Corrected CVS request below : Package Change Request == Package Name: perl-XML-Writer New Branches: EL-4 EL-5 Updated EPEL Owners: xavierb alexlan Updated EPEL CC: xavierb alexlan -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-04-22 13:07 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2008-04-22 15:04 EST --- built for EL-4 and EL-5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 03:37 EST --- Updates as per previous comments. spec: http://allele5.biol.berkeley.edu/~alex/fedora/perl-XML-Writer.spec SRPM: http://allele5.biol.berkeley.edu/~alex/fedora/perl-XML-Writer-0.602-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 04:50 EST --- Thanks. APPROVED Again. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 04:56 EST --- New Package CVS Request === Package Name: perl-XML-Writer Short Description: A simple Perl module for writing XML documents Owners: [EMAIL PROTECTED] Branches: FC-5 FC-6 InitialCC: Another orphaned package being resurrected. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 21:56 EST --- Builds fine in devel, FC-6, FC-5. Closing bug. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 01:49 EST --- (In reply to comment #3) Pushing back to review, because of this: 1.) t/pod-coverageskipped all skipped: Test::Pod::Coverage required for testing pod coverage t/pod.skipped all skipped: Test::Pod 1.00 required for testing POD = BR: perl(Test::Pod::Coverage) BR: perl(Test::Pod) I thought its not much important as its only check section that said about skipping testing. 2. BuildRequires: perl = 1:5.6.1 = Superfluous Oops its not needed. Missed one ;) 3. Missing BuildRequires: perl(ExtUtils::MakeMaker) yes Parag, Alex, these remarks also seem to apply to most other perl-packages Parag nodded off today. Got some spare time to review packages :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 02:20 EST --- (In reply to comment #3) Pushing back to review, because of this: 1.) t/pod-coverageskipped all skipped: Test::Pod::Coverage required for testing pod coverage t/pod.skipped all skipped: Test::Pod 1.00 required for testing POD = BR: perl(Test::Pod::Coverage) BR: perl(Test::Pod) 2. BuildRequires: perl = 1:5.6.1 = Superfluous 3. Missing BuildRequires: perl(ExtUtils::MakeMaker) Do we have any wiki page that gives above information for perl package reviewers/packagers? Parag, Alex, these remarks also seem to apply to most other perl-packages Parag nodded off today. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 02:26 EST --- With new package SRPM +make test PERL_DL_NONLAZY=1 /usr/bin/perl -MExtUtils::Command::MM -e test_harness(0, 'blib/lib', 'blib/arch') t/*.t t/01_main.ok t/pod-coverageok t/pod.ok All tests successful. Files=3, Tests=215, 1 wallclock secs ( 0.46 cusr + 0.04 csys = 0.50 CPU) + exit 0 All other looks OK to me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 02:28 EST --- (In reply to comment #4) On a related note, I don't think testing for coverage of POD documentation is really that interesting at all from packaging point of view. Right, but it has always been our policy to enable them, when a perl-dist's test suite uses them (More precisely: It has been policy to check everything a test-suite can test for) I don't see any reason to make any exceptions. (In reply to comment #6) (In reply to comment #3) I thought its not much important as its only check section that said about skipping testing. Checks aren't only. We should test to the max, if possible. However you are right, Test::Pods aren't very important, but ... c.f. above. Finally, another remark: %check ||: Remove the ||: - This is an anachronism to please really ancient rpms and has been frowned upon for years. Use %check. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 02:44 EST --- update SPEC and resubmit package removing ||: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML
documents
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-03-23 07:19 EST ---
Kindly avoid hardcoding version number in Source URL tarball name. Instead use
%{version}
Anyway you can do that at time of importing package in CVS.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 07:20 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c715d6fd90ac775316cc313815ba3b77 XML-Writer-0.602.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl -MExtUtils::Command::MM -e test_harness(0, 'blib/lib', 'blib/arch') t/*.t t/01_main.ok t/pod-coverageskipped all skipped: Test::Pod::Coverage required for testing pod coverage t/pod.skipped all skipped: Test::Pod 1.00 required for testing POD All tests successful, 2 tests skipped. Files=3, Tests=213, 1 wallclock secs ( 0.30 cusr + 0.03 csys = 0.33 CPU) + Provides: perl(XML::Writer) = 0.602 perl(XML::Writer::Namespaces) perl(XML::Writer::_String) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review+ |fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 08:11 EST --- Pushing back to review, because of this: 1.) t/pod-coverageskipped all skipped: Test::Pod::Coverage required for testing pod coverage t/pod.skipped all skipped: Test::Pod 1.00 required for testing POD = BR: perl(Test::Pod::Coverage) BR: perl(Test::Pod) 2. BuildRequires: perl = 1:5.6.1 = Superfluous 3. Missing BuildRequires: perl(ExtUtils::MakeMaker) Parag, Alex, these remarks also seem to apply to most other perl-packages Parag nodded off today. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 13:52 EST --- On a related note, I don't think testing for coverage of POD documentation is really that interesting at all from packaging point of view. If the documentation coverage test fails, would you block a package from inclusion or being updated? So opting to explicity disable the POD coverage tests would IMO be actually even better than making sure that the associated build dependencies are around and that the tests are always run (which is acceptable too; the current non-explicit state of this package is not). Note: I'm talking about POD coverage tests only here, not about any other tests. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585 --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 20:56 EST --- Updates as per comment #3. spec: http://allele5.biol.berkeley.edu/~alex/fedora/perl-XML-Writer.spec SRPM: http://allele5.biol.berkeley.edu/~alex/fedora/perl-XML-Writer-0.602-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
