[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-05-03 23:16 EST --- Building, thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 --- Additional Comments From [EMAIL PROTECTED] 2007-05-01 02:09 EST --- (In reply to comment #12) PDF/API2/Basic/TTF/XMLparse.pm uses it. The module will build w/o it being installed, but if the test suite ever actally starts being comprehensive, chances are something will fail. So I'd call it a BR, though I may just be being super pedantic here... Ok, I'm convinced :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 --- Additional Comments From [EMAIL PROTECTED] 2007-04-30 22:24 EST --- I took a look at LICENSE; this package's licensing and (in specific) royalty-free, etc, etc, patent grants all look OK to me. The font license also looks similarly OK. You're missing BRs on perl(Test::More) and (a well hidden one) on perl(XML::Parser::Expat) -- both of which can be fixed post-import. + source files match upstream: 3e674248b44f68af13cc4d23f018ba50 PDF-API2-0.60.tar.gz 3e674248b44f68af13cc4d23f018ba50 PDF-API2-0.60.tar.gz.srpm + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text included in package. + latest version is being packaged. X BuildRequires are proper. + compiler flags are appropriate (noarch) + %clean is present. + package installs properly + debuginfo package looks complete. (noarch) + rpmlint is silent. + final provides and requires are sane: ** perl-PDF-API2-0.60-2.fc6.noarch.rpm == rpmlint == provides perl(PDF::API2) perl(PDF::API2::Annotation) perl(PDF::API2::Basic::PDF::ASCII85Decode) perl(PDF::API2::Basic::PDF::ASCIIHexDecode) perl(PDF::API2::Basic::PDF::Array) perl(PDF::API2::Basic::PDF::Bool) perl(PDF::API2::Basic::PDF::Dict) perl(PDF::API2::Basic::PDF::File) perl(PDF::API2::Basic::PDF::Filter) perl(PDF::API2::Basic::PDF::FlateDecode) perl(PDF::API2::Basic::PDF::LZWDecode) perl(PDF::API2::Basic::PDF::Literal) perl(PDF::API2::Basic::PDF::Name) perl(PDF::API2::Basic::PDF::Null) perl(PDF::API2::Basic::PDF::Number) perl(PDF::API2::Basic::PDF::Objind) perl(PDF::API2::Basic::PDF::Page) perl(PDF::API2::Basic::PDF::Pages) perl(PDF::API2::Basic::PDF::RunLengthDecode) perl(PDF::API2::Basic::PDF::String) perl(PDF::API2::Basic::PDF::Utils) perl(PDF::API2::Basic::TTF::AATKern) perl(PDF::API2::Basic::TTF::AATutils) perl(PDF::API2::Basic::TTF::Anchor) perl(PDF::API2::Basic::TTF::Bsln) perl(PDF::API2::Basic::TTF::Cmap) perl(PDF::API2::Basic::TTF::Coverage) perl(PDF::API2::Basic::TTF::Cvt_) = 0.0001 perl(PDF::API2::Basic::TTF::Delta) perl(PDF::API2::Basic::TTF::Fdsc) perl(PDF::API2::Basic::TTF::Feat) perl(PDF::API2::Basic::TTF::Fmtx) perl(PDF::API2::Basic::TTF::Font) = 0.32 perl(PDF::API2::Basic::TTF::Fpgm) = 0.0001 perl(PDF::API2::Basic::TTF::GDEF) perl(PDF::API2::Basic::TTF::GPOS) perl(PDF::API2::Basic::TTF::GSUB) perl(PDF::API2::Basic::TTF::Glyf) perl(PDF::API2::Basic::TTF::Glyph) perl(PDF::API2::Basic::TTF::Hdmx) perl(PDF::API2::Basic::TTF::Head) perl(PDF::API2::Basic::TTF::Hhea) perl(PDF::API2::Basic::TTF::Hmtx) perl(PDF::API2::Basic::TTF::Kern) perl(PDF::API2::Basic::TTF::Kern::ClassArray) perl(PDF::API2::Basic::TTF::Kern::CompactClassArray) perl(PDF::API2::Basic::TTF::Kern::OrderedList) perl(PDF::API2::Basic::TTF::Kern::StateTable) perl(PDF::API2::Basic::TTF::Kern::Subtable) perl(PDF::API2::Basic::TTF::LTSH) perl(PDF::API2::Basic::TTF::Loca) perl(PDF::API2::Basic::TTF::Maxp) perl(PDF::API2::Basic::TTF::Mort) perl(PDF::API2::Basic::TTF::Mort::Chain) perl(PDF::API2::Basic::TTF::Mort::Contextual) perl(PDF::API2::Basic::TTF::Mort::Insertion) perl(PDF::API2::Basic::TTF::Mort::Ligature) perl(PDF::API2::Basic::TTF::Mort::Noncontextual) perl(PDF::API2::Basic::TTF::Mort::Rearrangement) perl(PDF::API2::Basic::TTF::Mort::Subtable) perl(PDF::API2::Basic::TTF::Name) = 1.1 perl(PDF::API2::Basic::TTF::OS_2) perl(PDF::API2::Basic::TTF::OldCmap) perl(PDF::API2::Basic::TTF::OldMort) perl(PDF::API2::Basic::TTF::PCLT) perl(PDF::API2::Basic::TTF::PSNames) perl(PDF::API2::Basic::TTF::Post) = 0.01 perl(PDF::API2::Basic::TTF::Prep) = 0.0001 perl(PDF::API2::Basic::TTF::Prop) perl(PDF::API2::Basic::TTF::Segarr) = 0.0001 perl(PDF::API2::Basic::TTF::Table) = 0.0001 perl(PDF::API2::Basic::TTF::Ttc) = 0.0001 perl(PDF::API2::Basic::TTF::Ttopen) perl(PDF::API2::Basic::TTF::Utils) = 0.0001 perl(PDF::API2::Basic::TTF::Vhea) perl(PDF::API2::Basic::TTF::Vmtx) perl(PDF::API2::Basic::TTF::XMLparse) perl(PDF::API2::Content) perl(PDF::API2::Content::Text) perl(PDF::API2::Lite) perl(PDF::API2::Matrix) perl(PDF::API2::NamedDestination) perl(PDF::API2::Outline) perl(PDF::API2::Outlines) perl(PDF::API2::Page) perl(PDF::API2::Resource) perl(PDF::API2::Resource::BaseFont)
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-PDF-API2 - Perl module for creation and
modification of PDF files
Alias: perl-PDF-API2
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471
--- Additional Comments From [EMAIL PROTECTED] 2007-04-29 16:55 EST ---
Ok, so :) Sorry for the delay, but I wanted to both think this one through (and
had some sort of obsessive desire to get all of Catalyst-Devel's prereqs posted
for reviewgrin)
So, fonts. The key bits that control where fonts are looked for appears to be
at the beginning of lib/PDF/API2.pm:
@FontDirs = ( (map { $_/PDF/API2/fonts } @INC),
qw[ /usr/share/fonts /usr/local/share/fonts c:/windows/fonts
c:/winnt/fonts ] );
They do appear to be integral to the function and operation of the package.
I've taken a peek at a number of other font packages, the canonical place for
fonts seems to be /usr/share/fonts... The bitstream-vera-fonts package has
%post and %postun scriptlets that seem to help with enabling other apps to use
these fonts.
So, my suggestion here would be to:
1. make a little patch to change @FontDirs defaults to sensible paths
2. move the fonts from their location in @INC to %{_sharedir}/fonts/%{name}
3. break the fonts out into a subpackage, requiring that subpackage by the main
package (but not vice-versa)
4. determine what %post/%postun scriptlets are needed to get these fonts
recognized and usable by the system
5. (really post-approval/import/build) include the sub-package in the right spot
in the comps.xml files such that people will see it with other fonts packages
That should break these fonts out in a sensible fashion that makes them
available to the rest of the system without impacting the functioning of this
module.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 --- Additional Comments From [EMAIL PROTECTED] 2007-04-29 19:27 EST --- Wait, even better... I just notice that these fonts are just deja-vu fonts and are all located in either dejavu-fonts or dejavu-fonts-experimental packages in Fedora(-Extras). So I removed the fonts from the installation entirely and pointed the FontDir to search the dejavu font directory, and now require those packages. I think that gets us what we want right? Spec URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2.spec SRPM URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2-0.60-2.fc6.src.rpm * Sun Apr 29 2007 Bernard Johnson [EMAIL PROTECTED] - 0.60-2 - remove fonts and depend on dejavu-fonts and dejavu-fonts-experimental - change font search path - remove font docs -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 --- Additional Comments From [EMAIL PROTECTED] 2007-04-28 14:39 EST --- Spec URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2.spec SRPM URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2-0.60-1.fc6.src.rpm * Sat Apr 28 2007 Bernard Johnson [EMAIL PROTECTED] - 0.60-1 - v 0.60 - deliberately remove 027_winfont example as it wants Win32.pm - BR on perl(Ext::MakeMaker) rather than perl -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 --- Additional Comments From [EMAIL PROTECTED] 2007-04-24 09:53 EST --- (In reply to comment #4) As to the fonts, they look perfectly fine. However, they may fall under the heading of content, and thus need a FESCo ack... If someone with a better feel of this sections than the guidelines could post a comment here, I'd much appreciate it. Since they are an integral (or are they?) part of the package, I wasn't so worried about whether they were OK or not, just if there was a better way to handle their inclusion. The package defaults to installing them with the perl package itself, but I was wondering if it should/could be broken up to install with regular fonts (I didn't try that). Opinions? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files Alias: perl-PDF-API2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-04-24 01:55 EST --- (In reply to comment #3) Go read file LICENSE in the package :) It's always this simple when I actually ask :) As to the fonts, they look perfectly fine. However, they may fall under the heading of content, and thus need a FESCo ack... If someone with a better feel of this sections than the guidelines could post a comment here, I'd much appreciate it. Otherwise, I have a review all ready to post. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||235587 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235471] Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PDF-API2 - Perl module for creation and modification of PDF files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235471 --- Additional Comments From [EMAIL PROTECTED] 2007-04-06 04:10 EST --- Spec URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2.spec SRPM URL: http://symetrix.com/~bjohnson/projects/fedora/perl-PDF-API2-0.59.002-2.src.rpm * Fri Apr 06 2007 Bernard Johnson [EMAIL PROTECTED] - 0.59.002-2 - moving resource to docs was a mistake, fix it -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
