[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-18 12:42 EST --- mdsplib-0.11-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-06-14 13:19 EST --- All branches built fine, and the F-7 package is pending for updates-testing. Thanks for the review and for the CVS operations! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-14 17:12 EST --- mdsplib-0.11-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs- |fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-06-11 12:07 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-09 09:16 EST --- okay ;-) Sorry for the trouble here, but static libs are just to be avoided if possible, and it looks very possible here. ;) I do agree with that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-06-09 14:03 EST --- Well, Taking in account first part of full review above which doesn't change, OK - Removed Static lib from package OK - Sahred lib correctly generated/included in package. OK - Sub-packages are proper Ok - No sub-package -lib are required Ok - Scriptlets for shared lib are properly applied. -- rpmlint ouputs -- Silent from both rpm (main pakcage) and srpm. From -devel package: W: mdsplib-devel no-documentation Harmless, this can be ignored. == ** APPROVED ** == -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-06-08 05:06 EST --- Yeah, well, I'd really prefer having it as a shared lib, especially since the code itself hasn't changed at all in years. Hans : Could you maybe have a look and see if it would be easy to switch the build to produce a shared library? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-08 05:45 EST --- Created an attachment (id=156558) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156558action=view) Patch: make a shared lib instead of a static one Making a shared lib is simple with this package (no autohell, phew) this patch changes the makefile to make a shared lib instead of a static one. Modified spec will be attached next. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-08 05:45 EST --- Created an attachment (id=156559) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156559action=view) Modified spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Component|Package Review |915resolution --- Additional Comments From [EMAIL PROTECTED] 2007-06-08 07:21 EST --- Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/mdsplib/mdsplib.spec SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/mdsplib/mdsplib-0.11-3.src.rpm * Fri Jun 8 2007 Matthias Saou http://freshrpms.net/ 0.11-3 - Include patch from Hans de Goede to build the lib as shared. That was fast Hans, thanks a lot!!! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Component|915resolution |Package Review -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-08 15:55 EST --- Awesome work Hans! Xavier: Could you look this over and if it looks ok, (re) approve it? Sorry for the trouble here, but static libs are just to be avoided if possible, and it looks very possible here. ;) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-06-07 09:39 EST --- New Package CVS Request === Package Name: mdsplib Short Description: METAR Decoder Software Package Library Owners: [EMAIL PROTECTED] Branches: devel F-7 FC-6 FC-5 EL-4 EL-5 (all current) InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs?, fedora-review+ |fedora-review?, fedora-cvs- --- Additional Comments From [EMAIL PROTECTED] 2007-06-07 16:06 EST --- There are some issues with static libs that should be figured before this is imported into cvs... - MUST: Static libraries must be in a -static package Also see: http://fedoraproject.org/wiki/PackagingDrafts/StaticLinkage I think short term you could just move the static libs to a -static package, but fixing it to use dynamic would be better. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mdsplib - METAR Decoder Software Package Library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-06-07 19:09 EST ---
Sigh. Here is the page I was looking for earlier and couldn't find:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-82d97fc4a3421310f4e2971180e4165965b65662
So, you could also add a:
%package devel
Provides: foo-static = %{version}-%{release}
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-06-06 19:36 EST --- nice catch ! == ** APPROVED ** == -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-06-05 18:56 EST --- Why don't create directly the -devel package instead. Does this package plan to contains more than headers files in future release ? What do you mean by this? I'm already creating only the the -devel package, and yes, in the future I'd like to patch the sources in order to get a shared library, since this library hasn't changed in literally years it shouldn't be a problem, quite the contrary. See my initial Packager note :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 --- Additional Comments From [EMAIL PROTECTED] 2007-05-29 00:25 EST --- Well, OK - Mock : Built on FC6 en F-7 (i386 and x86_64) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is LGPL OK - License match extras packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: c529c07675431f50c517921db6fdd122 mdsplib-0.11.tar.gz OK - Package has correct buildroot. OK - extras BuildRequires not required for this package. OK - %build and %install stages is correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version Rpmlint output: OK - silent on both srpm and rpm. - sub-package: just a comment: Why don't create directly the -devel package instead. Does this package plan to contains more than headers files in future release ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-05-21 07:31 EST --- starting review... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 239546] Review Request: mdsplib - METAR Decoder Software Package Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdsplib - METAR Decoder Software Package Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239546 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||230549 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
