[Bug 240793] Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240793 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-07-12 09:47 EST --- D'oh, accidentally been sitting on this for nearly a month... I'll get it imported today... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 240793] Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240793 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-12 09:53 EST --- New Package CVS Request === Package Name: hdhomerun Short Description: tools for the Silicon Dust HDHomeRun Owners: [EMAIL PROTECTED], [EMAIL PROTECTED] Branches: F-7, FC-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 240793] Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240793 --- Additional Comments From [EMAIL PROTECTED] 2007-06-18 09:43 EST --- Okay, try these on for size: http://people.redhat.com/jwilson/packages/hdhomerun/hdhomerun-0.0-0.1.20070616.fc7.src.rpm http://people.redhat.com/jwilson/packages/hdhomerun/hdhomerun.spec 8 * Mon Jun 18 2007 Jarod Wilson [EMAIL PROTECTED] 0.0-0.1.20070616 - Update to 20070616 release - Don't install any of the header files and drop lib from the package name, since this really isn't a library -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 240793] Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240793
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Flag||fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2007-06-18 13:33 EST ---
1 - MUST: rpmlint must be run on every package. The output should be
posted in the review.
OK (rpmlint is silent)
2 - MUST: The package must be named according to the Package Naming
Guidelines.
OK
3 - MUST: The spec file name must match the base package %{name}, in
the format %{name}.spec
OK
4 - MUST: The package must meet the Packaging Guidelines.
OK - minor suggestion, use sed to manipulate the Makefile and drop
the BR on perl:
--- hdhomerun.spec 2007-06-18 08:40:19.0 -0500
+++ hdhomerun.spec.new 2007-06-18 07:14:12.0 -0500
@@ -9,7 +9,6 @@
URL: http://www.silicondust.com/
Source0:
http://download.silicondust.com/hdhomerun/libhdhomerun_%{releasedate}.tgz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildRequires: perl
%description
libhdhomerun contains the configuration and firmware upgrade
@@ -20,7 +19,7 @@
# Fix up linefeeds, drop execute bit and don't strip binaries
%{__sed} -i 's/\r//' *
%{__chmod} -x *
-%{__perl} -pi -e 's/strip.*//g' Makefile
+%{__sed} -i -e '/strip/d' -e 's/C\(PP\)\?FLAGS .=/C\1FLAGS ?=/' Makefile
Another minor point (not a blocker), the source files are encoded with
ISO-8859-1, converting them to UTF-8 might be helpful. Not a big deal
because AFAIK it only affects the © symbol in the header:
for f in *; do
/usr/bin/iconv -f iso-8859-1 -t utf-8 --output $f.new $f mv $f.new $f
done
%build
export CFLAGS=$RPM_OPT_FLAGS
5 - MUST: The package must be licensed with an open-source compatible
license and meet other legal requirements as defined in the
legal section of Packaging Guidelines.
OK (LGPL)
6 - MUST: The License field in the package spec file must match the
actual license.
OK
7 - MUST: If (and only if) the source package includes the text of
the license(s) in its own file, then that file, containing
the text of the license(s) for the package must be included
in %doc.
OK
8 - MUST: The spec file must be written in American English.
OK
9 - MUST: The spec file for the package MUST be legible. If the
reviewer is unable to read the spec file, it will be
impossible to perform a review. Fedora is not the place
for entries into the Obfuscated Code Contest ([WWW]
http://www.ioccc.org/).
OK
10 - MUST: The sources used to build the package must match the
upstream source, as provided in the spec URL. Reviewers
should use md5sum for this task.
OK
11 - MUST: The package must successfully compile and build into binary
rpms on at least one supported architecture.
OK (F-7/i386)
12 - MUST: If the package does not successfully compile, build or work
on an architecture, then those architectures should be
listed in the spec in ExcludeArch. Each architecture listed
in ExcludeArch needs to have a bug filed in bugzilla,
describing the reason that the package does not
compile/build/work on that architecture. The bug number
should then be placed in a comment, next to the
corresponding ExcludeArch line. New packages will not have
bugzilla entries during the review process, so they should
put this description in the comment until the package is
approved, then file the bugzilla entry, and replace the
long explanation with the bug number. (Extras Only) The bug
should be marked as blocking one (or more) of the following
bugs to simplify tracking such issues...
OK (Unable to test PPC)
13 - MUST: All build dependencies must be listed in BuildRequires,
except for any that are listed in the exceptions section of
Packaging Guidelines; inclusion of those as BuildRequires
is optional. Apply common sense.
OK
14 - MUST: The spec file MUST handle locales properly. This is done by
using the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
OK (no locale-specific files)
15 - MUST: If the package contains shared library files located in the
dynamic linker's default paths, that package must call
ldconfig in
[Bug 240793] Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240793 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-06-15 13:27 EST --- *** Bug 243704 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 240793] Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhdhomerun - tools for the Silicon Dust HDHomeRun https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240793 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: libhdhomerun|Review Request: libhdhomerun |- tools for the Silicon Dust|- tools for the Silicon Dust |HDHomeRun |HDHomeRun --- Additional Comments From [EMAIL PROTECTED] 2007-06-15 13:39 EST --- While the upstream tarball is called libhdhomerun there isn't really a library produced. That's why I chose to call the package that I put together hdhomerun. Also, I'm not sure how useful it is at this point to install the header files into a -devel subpackage because there's no library to link against. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
